| Message ID | 20220921133607.2808247-1-odivlad@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] spec: require python3-openvswitch for ovn-detrace | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/github-robot-_ovn-kubernetes | success | github build: passed |
On 9/21/22 15:36, Vladislav Odintsov wrote: > Signed-off-by: Vladislav Odintsov <odivlad@gmail.com> > --- Hi Vladislav, > rhel/ovn-fedora.spec.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/rhel/ovn-fedora.spec.in b/rhel/ovn-fedora.spec.in > index 821eb03cc..57dc977c1 100644 > --- a/rhel/ovn-fedora.spec.in > +++ b/rhel/ovn-fedora.spec.in > @@ -65,6 +65,7 @@ BuildRequires: tcpdump > BuildRequires: unbound unbound-devel > > Requires: openssl hostname iproute module-init-tools openvswitch > +Requires: python3-openvswitch > > Requires(post): systemd-units > Requires(preun): systemd-units This change looks good to me, I tested it locally and it works fine: Acked-by: Dumitru Ceara <dceara@redhat.com> Numan, you have more Fedora packaging experience, do you agree? This is not something this patch should fix but it reminded me of: OVS builds Debian packages in CI; there's a patch to do the same thing in OVN [0]; should we do it for Fedora packages too? [0] https://patchwork.ozlabs.org/project/ovn/patch/20220805203452.3060165-6-frode.nordahl@canonical.com/ Thanks, Dumitru
On Tue, Oct 4, 2022 at 5:41 AM Dumitru Ceara <dceara@redhat.com> wrote: > > On 9/21/22 15:36, Vladislav Odintsov wrote: > > Signed-off-by: Vladislav Odintsov <odivlad@gmail.com> > > --- > > Hi Vladislav, > > > rhel/ovn-fedora.spec.in | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/rhel/ovn-fedora.spec.in b/rhel/ovn-fedora.spec.in > > index 821eb03cc..57dc977c1 100644 > > --- a/rhel/ovn-fedora.spec.in > > +++ b/rhel/ovn-fedora.spec.in > > @@ -65,6 +65,7 @@ BuildRequires: tcpdump > > BuildRequires: unbound unbound-devel > > > > Requires: openssl hostname iproute module-init-tools openvswitch > > +Requires: python3-openvswitch > > > > Requires(post): systemd-units > > Requires(preun): systemd-units > > This change looks good to me, I tested it locally and it works fine: > > Acked-by: Dumitru Ceara <dceara@redhat.com> > > Numan, you have more Fedora packaging experience, do you agree? LGTM Thanks. I applied this patch to the main branch and backported till branch-22.03. > > This is not something this patch should fix but it reminded me of: OVS > builds Debian packages in CI; there's a patch to do the same thing in > OVN [0]; should we do it for Fedora packages too? +1. That would be beneficial IMO. Numan > > [0] > https://patchwork.ozlabs.org/project/ovn/patch/20220805203452.3060165-6-frode.nordahl@canonical.com/ > > Thanks, > Dumitru > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
diff --git a/rhel/ovn-fedora.spec.in b/rhel/ovn-fedora.spec.in index 821eb03cc..57dc977c1 100644 --- a/rhel/ovn-fedora.spec.in +++ b/rhel/ovn-fedora.spec.in @@ -65,6 +65,7 @@ BuildRequires: tcpdump BuildRequires: unbound unbound-devel Requires: openssl hostname iproute module-init-tools openvswitch +Requires: python3-openvswitch Requires(post): systemd-units Requires(preun): systemd-units
Signed-off-by: Vladislav Odintsov <odivlad@gmail.com> --- rhel/ovn-fedora.spec.in | 1 + 1 file changed, 1 insertion(+)