From patchwork Fri Aug 26 12:35:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dumitru Ceara X-Patchwork-Id: 1670719 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.133; helo=smtp2.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=RNl/jmAY; dkim-atps=neutral Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4MDfS64W0Qz1yhN for ; Fri, 26 Aug 2022 22:35:18 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 8927140FBC; Fri, 26 Aug 2022 12:35:16 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 8927140FBC Authentication-Results: smtp2.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=RNl/jmAY X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vtjSkje6Y6TT; Fri, 26 Aug 2022 12:35:12 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id CA7EB40192; Fri, 26 Aug 2022 12:35:11 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org CA7EB40192 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 9D347C0033; Fri, 26 Aug 2022 12:35:11 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 52BC7C002D for ; Fri, 26 Aug 2022 12:35:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 388AB40192 for ; Fri, 26 Aug 2022 12:35:10 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 388AB40192 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YnImPQ5Bvd6N for ; Fri, 26 Aug 2022 12:35:09 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org F3AB7404F5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp2.osuosl.org (Postfix) with ESMTPS id F3AB7404F5 for ; Fri, 26 Aug 2022 12:35:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661517307; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Gl/IHgPZqHPXPQZX0vn95hU3o04G7H3ET4t/3Cl8Cgs=; b=RNl/jmAY5Qt+p09llLaOvAm7FC9sELR8+hooJdygMJLAmilE6xDxmrFFkcxZlDZhLsZXf2 DvrhXBbQOUiyjoTposNUpGmyGNDN180VnpwipjPJwktrCotoEpdrr4XPs9pLbeF9QhyI7s CtxbdT3yRbZgHkNLstrMXUWwkSGxqGE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-591-jgeRZWqgNzG1Moy76xnKSQ-1; Fri, 26 Aug 2022 08:35:06 -0400 X-MC-Unique: jgeRZWqgNzG1Moy76xnKSQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1F3FA101A54E for ; Fri, 26 Aug 2022 12:35:06 +0000 (UTC) Received: from dceara.remote.csb (unknown [10.39.194.197]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7CFA72166B26 for ; Fri, 26 Aug 2022 12:35:05 +0000 (UTC) From: Dumitru Ceara To: ovs-dev@openvswitch.org Date: Fri, 26 Aug 2022 14:35:00 +0200 Message-Id: <20220826123500.3006444-1-dceara@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [ovs-dev] [PATCH ovn] lb: Remove unused ovn_northd_lb_vip vip_port_str member. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" Signed-off-by: Dumitru Ceara Acked-by: Ales Musil --- lib/lb.c | 5 +---- lib/lb.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/lib/lb.c b/lib/lb.c index 7b0ed1abe..580efe7f7 100644 --- a/lib/lb.c +++ b/lib/lb.c @@ -103,7 +103,6 @@ void ovn_northd_lb_vip_init(struct ovn_northd_lb_vip *lb_vip_nb, const struct nbrec_load_balancer *nbrec_lb, const char *vip_port_str, const char *backend_ips) { - lb_vip_nb->vip_port_str = xstrdup(vip_port_str); lb_vip_nb->backend_ips = xstrdup(backend_ips); lb_vip_nb->n_backends = lb_vip->n_backends; lb_vip_nb->backends_nb = xcalloc(lb_vip_nb->n_backends, @@ -121,8 +120,7 @@ void ovn_northd_lb_vip_init(struct ovn_northd_lb_vip *lb_vip_nb, } } else { for (size_t j = 0; j < nbrec_lb->n_health_check; j++) { - if (!strcmp(nbrec_lb->health_check[j]->vip, - lb_vip_nb->vip_port_str)) { + if (!strcmp(nbrec_lb->health_check[j]->vip, vip_port_str)) { lb_health_check = nbrec_lb->health_check[j]; break; } @@ -135,7 +133,6 @@ void ovn_northd_lb_vip_init(struct ovn_northd_lb_vip *lb_vip_nb, static void ovn_northd_lb_vip_destroy(struct ovn_northd_lb_vip *vip) { - free(vip->vip_port_str); free(vip->backend_ips); for (size_t i = 0; i < vip->n_backends; i++) { free(vip->backends_nb[i].svc_mon_src_ip); diff --git a/lib/lb.h b/lib/lb.h index 832ed31fb..4bcf123b3 100644 --- a/lib/lb.h +++ b/lib/lb.h @@ -70,7 +70,6 @@ struct ovn_lb_backend { /* ovn-northd specific backend information. */ struct ovn_northd_lb_vip { - char *vip_port_str; char *backend_ips; struct ovn_northd_lb_backend *backends_nb; size_t n_backends;