diff mbox series

[ovs-dev] ci: Add missing tests after switch to parallel jobs

Message ID 20220810111531.94491-1-amusil@redhat.com
State Superseded
Headers show
Series [ovs-dev] ci: Add missing tests after switch to parallel jobs | expand

Checks

Context Check Description
ovsrobot/apply-robot warning apply and check: warning
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/github-robot-_ovn-kubernetes fail github build: failed

Commit Message

Ales Musil Aug. 10, 2022, 11:15 a.m. UTC 
After switch to parallel jobs some tests
were missing due to way how filtering in autotest
works. Add new keyword for the OVN_FOR_EACH_NORTHD
tests and add jobs that will run them.

Fixes: d093905 ("OVN-CI: ovn unit tests run in parallel jobs.")
Signed-off-by: Ales Musil <amusil@redhat.com>
---
 .github/workflows/test.yml | 7 ++++++-
 tests/ovs-macros.at        | 4 +++-
 2 files changed, 9 insertions(+), 2 deletions(-)

Comments

0-day Robot Aug. 10, 2022, 11:43 a.m. UTC | #1 
Bleep bloop.  Greetings Ales Musil, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line is 82 characters long (recommended limit is 79)
#26 FILE: .github/workflows/test.yml:43:
        - { compiler: gcc, testsuite: test, testsuite_kw: "!ovn_for_each_northd" }

WARNING: Line is 108 characters long (recommended limit is 79)
#31 FILE: .github/workflows/test.yml:48:
        - { compiler: clang, testsuite: test, sanitizers: sanitizers, testsuite_kw: "!ovn_for_each_northd" }

WARNING: Line is 100 characters long (recommended limit is 79)
#36 FILE: .github/workflows/test.yml:53:
        - { compiler: gcc, testsuite: test, libs: -ljemalloc, testsuite_kw: "!ovn_for_each_northd" }

WARNING: Line is 102 characters long (recommended limit is 79)
#41 FILE: .github/workflows/test.yml:58:
        - { compiler: clang, testsuite: test, libs: -ljemalloc, testsuite_kw: "!ovn_for_each_northd" }

WARNING: Line is 107 characters long (recommended limit is 79)
#46 FILE: .github/workflows/test.yml:62:
        - { compiler: gcc, testsuite: system-test, testsuite_kw: "parallelization=no,ovn_monitor_all=yes" }

WARNING: Line is 89 characters long (recommended limit is 79)
#47 FILE: .github/workflows/test.yml:63:
        - { compiler: gcc, testsuite: system-test, testsuite_kw: "!ovn_for_each_northd" }

Lines checked: 68, Warnings: 6, Errors: 0


Please check this out.  If you feel there has been an error, please email aconole@redhat.com

Thanks,
0-day Robot
diff mbox series

Patch

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index afa984345..bae20d1fd 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -40,22 +40,27 @@  jobs:
         - { compiler: gcc, testsuite: test, testsuite_kw: "parallelization=yes,ovn_monitor_all=no" }
         - { compiler: gcc, testsuite: test, testsuite_kw: "parallelization=no,ovn_monitor_all=yes" }
         - { compiler: gcc, testsuite: test, testsuite_kw: "parallelization=no,ovn_monitor_all=no" }
+        - { compiler: gcc, testsuite: test, testsuite_kw: "!ovn_for_each_northd" }
         - { compiler: clang, testsuite: test, sanitizers: sanitizers, testsuite_kw: "parallelization=yes,ovn_monitor_all=yes" }
         - { compiler: clang, testsuite: test, sanitizers: sanitizers, testsuite_kw: "parallelization=yes,ovn_monitor_all=no" }
         - { compiler: clang, testsuite: test, sanitizers: sanitizers, testsuite_kw: "parallelization=no,ovn_monitor_all=yes" }
         - { compiler: clang, testsuite: test, sanitizers: sanitizers, testsuite_kw: "parallelization=no,ovn_monitor_all=no" }
+        - { compiler: clang, testsuite: test, sanitizers: sanitizers, testsuite_kw: "!ovn_for_each_northd" }
         - { compiler: gcc, testsuite: test, libs: -ljemalloc, testsuite_kw: "parallelization=yes,ovn_monitor_all=yes" }
         - { compiler: gcc, testsuite: test, libs: -ljemalloc, testsuite_kw: "parallelization=yes,ovn_monitor_all=no" }
         - { compiler: gcc, testsuite: test, libs: -ljemalloc, testsuite_kw: "parallelization=no,ovn_monitor_all=yes" }
         - { compiler: gcc, testsuite: test, libs: -ljemalloc, testsuite_kw: "parallelization=no,ovn_monitor_all=no" }
+        - { compiler: gcc, testsuite: test, libs: -ljemalloc, testsuite_kw: "!ovn_for_each_northd" }
         - { compiler: clang, testsuite: test, libs: -ljemalloc, testsuite_kw: "parallelization=yes,ovn_monitor_all=yes" }
         - { compiler: clang, testsuite: test, libs: -ljemalloc, testsuite_kw: "parallelization=yes,ovn_monitor_all=no" }
         - { compiler: clang, testsuite: test, libs: -ljemalloc, testsuite_kw: "parallelization=no,ovn_monitor_all=yes" }
         - { compiler: clang, testsuite: test, libs: -ljemalloc, testsuite_kw: "parallelization=no,ovn_monitor_all=no" }
+        - { compiler: clang, testsuite: test, libs: -ljemalloc, testsuite_kw: "!ovn_for_each_northd" }
         - { compiler: gcc, testsuite: system-test, testsuite_kw: "parallelization=yes,ovn_monitor_all=yes" }
         - { compiler: gcc, testsuite: system-test, testsuite_kw: "parallelization=yes,ovn_monitor_all=no" }
         - { compiler: gcc, testsuite: system-test, testsuite_kw: "parallelization=no,ovn_monitor_all=yes" }
-        - { compiler: gcc, testsuite: system-test, testsuite_kw: "parallelization=no,ovn_monitor_all=no" }
+        - { compiler: gcc, testsuite: system-test, testsuite_kw: "parallelization=no,ovn_monitor_all=yes" }
+        - { compiler: gcc, testsuite: system-test, testsuite_kw: "!ovn_for_each_northd" }
         - { compiler: gcc,  m32: m32, opts: --disable-ssl}
 
     steps:
diff --git a/tests/ovs-macros.at b/tests/ovs-macros.at
index 5a06fe956..b102e1f03 100644
--- a/tests/ovs-macros.at
+++ b/tests/ovs-macros.at
@@ -10,7 +10,9 @@  dnl   set it as a shell variable as well.
 m4_rename([AT_SETUP], [OVS_AT_SETUP])
 m4_define([AT_SETUP],
   [OVS_AT_SETUP($@[]m4_ifdef([NORTHD_TYPE], [ -- NORTHD_TYPE])[]m4_ifdef([NORTHD_USE_PARALLELIZATION], [ -- parallelization=NORTHD_USE_PARALLELIZATION])[]m4_ifdef([OVN_MONITOR_ALL], [ -- ovn_monitor_all=OVN_MONITOR_ALL]))
-m4_ifdef([NORTHD_TYPE], [[NORTHD_TYPE]=NORTHD_TYPE
+m4_ifdef([NORTHD_TYPE], [dnl
+[NORTHD_TYPE]=NORTHD_TYPE
+AT_KEYWORDS([ovn_for_each_northd])
 ])dnl
 m4_ifdef([NORTHD_USE_PARALLELIZATION], [[NORTHD_USE_PARALLELIZATION]=NORTHD_USE_PARALLELIZATION
 ])dnl