diff mbox series

[ovs-dev,branch-22.03,1/2] tests: check qos_max_rate and qos_burst are set

Message ID 20220728000243.507144-1-ihrachys@redhat.com
State Accepted
Headers show
Series [ovs-dev,branch-22.03,1/2] tests: check qos_max_rate and qos_burst are set | expand

Checks

Context Check Description
ovsrobot/apply-robot warning apply and check: warning
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/github-robot-_ovn-kubernetes fail github build: failed

Commit Message

Ihar Hrachyshka July 28, 2022, 12:02 a.m. UTC 
Signed-off-by: Ihar Hrachyshka <ihrachys@redhat.com>
Acked-by: Ales Musil <amusil@redhat.com>
Signed-off-by: Mark Michelson <mmichels@redhat.com>
(cherry picked from commit 8f4beb7ce310e4bcac0aff636fa948aa3ca438ac)
---
 tests/system-ovn.at | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Comments

0-day Robot July 28, 2022, 12:37 a.m. UTC | #1 
Bleep bloop.  Greetings Ihar Hrachyshka, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Mark Michelson <mmichels@redhat.com>
Lines checked: 38, Warnings: 1, Errors: 0


Please check this out.  If you feel there has been an error, please email aconole@redhat.com

Thanks,
0-day Robot
diff mbox series

Patch

diff --git a/tests/system-ovn.at b/tests/system-ovn.at
index ffab612d8..19fd28c12 100644
--- a/tests/system-ovn.at
+++ b/tests/system-ovn.at
@@ -6342,11 +6342,15 @@  ovn-nbctl lsp-add sw0 public \
         -- lsp-set-type public localnet \
         -- lsp-set-options public network_name=phynet
 
-AT_CHECK([ovn-nbctl set Logical_Switch_Port public options:qos_burst=1000])
+AT_CHECK([ovn-nbctl set Logical_Switch_Port public options:qos_max_rate=300000])
+AT_CHECK([ovn-nbctl set Logical_Switch_Port public options:qos_burst=3000000])
 AT_CHECK([ovs-vsctl set interface ovs-public external-ids:ovn-egress-iface=true])
 OVS_WAIT_UNTIL([tc qdisc show | grep -q 'htb 1: dev ovs-public'])
+OVS_WAIT_UNTIL([tc class show dev ovs-public | \
+                grep -q 'class htb .* ceil 300Kbit burst 375000b cburst 375000b'])
 
-AT_CHECK([ovn-nbctl remove Logical_Switch_Port public options qos_burst=1000])
+AT_CHECK([ovn-nbctl remove Logical_Switch_Port public options qos_max_rate=300000])
+AT_CHECK([ovn-nbctl remove Logical_Switch_Port public options qos_burst=3000000])
 OVS_WAIT_UNTIL([test "$(tc qdisc show | grep 'htb 1: dev ovs-public')" = ""])
 
 kill $(pidof ovn-controller)