| Message ID | 20220727232801.496030-1-ihrachys@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] tests: enable and fix vif-provider test scenario | expand |
Hello, Ihar, On Thu, Jul 28, 2022 at 1:28 AM Ihar Hrachyshka <ihrachys@redhat.com> wrote: > > Signed-off-by: Ihar Hrachyshka <ihrachys@redhat.com> > --- > controller/test-vif-plug.c | 2 +- > tests/ovn-vif-plug.at | 2 +- > tests/testsuite.at | 1 + > 3 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/controller/test-vif-plug.c b/controller/test-vif-plug.c > index 01ff37d8f..d7094199a 100644 > --- a/controller/test-vif-plug.c > +++ b/controller/test-vif-plug.c > @@ -36,7 +36,7 @@ test_vif_plug(struct ovs_cmdl_context *ctx OVS_UNUSED) > ovs_assert( > sset_contains( > vif_plug_get_maintained_iface_options(vif_plug_class), > - "plug-dummy-option")); > + "vif-plug-dummy-option")); > > struct vif_plug_port_ctx_in ctx_in = { > .op_type = PLUG_OP_CREATE, > diff --git a/tests/ovn-vif-plug.at b/tests/ovn-vif-plug.at > index 86b0b4b84..d4c225e90 100644 > --- a/tests/ovn-vif-plug.at > +++ b/tests/ovn-vif-plug.at > @@ -4,5 +4,5 @@ > AT_BANNER([OVN unit tests - vif-plug]) > > AT_SETUP([unit test -- plugging infrastructure tests]) > -AT_CHECK([ovstest test-plug run], [0], []) > +AT_CHECK([ovstest test-vif-plug run], [0], []) > AT_CLEANUP > diff --git a/tests/testsuite.at b/tests/testsuite.at > index 479e786bd..d3f00e1bf 100644 > --- a/tests/testsuite.at > +++ b/tests/testsuite.at > @@ -39,3 +39,4 @@ m4_include([tests/ovn-controller-vtep.at]) > m4_include([tests/ovn-ic.at]) > m4_include([tests/checkpatch.at]) > m4_include([tests/ovn-ipsec.at]) > +m4_include([tests/ovn-vif-plug.at]) > -- > 2.34.1 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev Looks like the unit tests were never enabled, thank you for catching that! I would reword the subject/commit message to use the words "unit test" instead of test scenario, as when you say test scenario I think about the functional test named "ovn-controller - VIF plugging" located in tests/ovn.at:31396-31515. With a updated commit message: Acked-by: Frode Nordahl <frode.nordahl@canonical.com>
On Thu, Jul 28, 2022 at 4:44 PM Frode Nordahl <frode.nordahl@canonical.com> wrote: > > Hello, Ihar, > > On Thu, Jul 28, 2022 at 1:28 AM Ihar Hrachyshka <ihrachys@redhat.com> wrote: > > > > Signed-off-by: Ihar Hrachyshka <ihrachys@redhat.com> > > --- > > controller/test-vif-plug.c | 2 +- > > tests/ovn-vif-plug.at | 2 +- > > tests/testsuite.at | 1 + > > 3 files changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/controller/test-vif-plug.c b/controller/test-vif-plug.c > > index 01ff37d8f..d7094199a 100644 > > --- a/controller/test-vif-plug.c > > +++ b/controller/test-vif-plug.c > > @@ -36,7 +36,7 @@ test_vif_plug(struct ovs_cmdl_context *ctx OVS_UNUSED) > > ovs_assert( > > sset_contains( > > vif_plug_get_maintained_iface_options(vif_plug_class), > > - "plug-dummy-option")); > > + "vif-plug-dummy-option")); > > > > struct vif_plug_port_ctx_in ctx_in = { > > .op_type = PLUG_OP_CREATE, > > diff --git a/tests/ovn-vif-plug.at b/tests/ovn-vif-plug.at > > index 86b0b4b84..d4c225e90 100644 > > --- a/tests/ovn-vif-plug.at > > +++ b/tests/ovn-vif-plug.at > > @@ -4,5 +4,5 @@ > > AT_BANNER([OVN unit tests - vif-plug]) > > > > AT_SETUP([unit test -- plugging infrastructure tests]) > > -AT_CHECK([ovstest test-plug run], [0], []) > > +AT_CHECK([ovstest test-vif-plug run], [0], []) > > AT_CLEANUP > > diff --git a/tests/testsuite.at b/tests/testsuite.at > > index 479e786bd..d3f00e1bf 100644 > > --- a/tests/testsuite.at > > +++ b/tests/testsuite.at > > @@ -39,3 +39,4 @@ m4_include([tests/ovn-controller-vtep.at]) > > m4_include([tests/ovn-ic.at]) > > m4_include([tests/checkpatch.at]) > > m4_include([tests/ovn-ipsec.at]) > > +m4_include([tests/ovn-vif-plug.at]) > > -- > > 2.34.1 > > > > _______________________________________________ > > dev mailing list > > dev@openvswitch.org > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > Looks like the unit tests were never enabled, thank you for catching that! > > I would reword the subject/commit message to use the words "unit test" > instead of test scenario, as when you say test scenario I think about > the functional test named "ovn-controller - VIF plugging" located in > tests/ovn.at:31396-31515. > > With a updated commit message: > Acked-by: Frode Nordahl <frode.nordahl@canonical.com> Thanks. I changed the commit message and applied the patch to main and back ported till branch-21.12. Numan > > -- > Frode Nordahl > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
diff --git a/controller/test-vif-plug.c b/controller/test-vif-plug.c index 01ff37d8f..d7094199a 100644 --- a/controller/test-vif-plug.c +++ b/controller/test-vif-plug.c @@ -36,7 +36,7 @@ test_vif_plug(struct ovs_cmdl_context *ctx OVS_UNUSED) ovs_assert( sset_contains( vif_plug_get_maintained_iface_options(vif_plug_class), - "plug-dummy-option")); + "vif-plug-dummy-option")); struct vif_plug_port_ctx_in ctx_in = { .op_type = PLUG_OP_CREATE, diff --git a/tests/ovn-vif-plug.at b/tests/ovn-vif-plug.at index 86b0b4b84..d4c225e90 100644 --- a/tests/ovn-vif-plug.at +++ b/tests/ovn-vif-plug.at @@ -4,5 +4,5 @@ AT_BANNER([OVN unit tests - vif-plug]) AT_SETUP([unit test -- plugging infrastructure tests]) -AT_CHECK([ovstest test-plug run], [0], []) +AT_CHECK([ovstest test-vif-plug run], [0], []) AT_CLEANUP diff --git a/tests/testsuite.at b/tests/testsuite.at index 479e786bd..d3f00e1bf 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -39,3 +39,4 @@ m4_include([tests/ovn-controller-vtep.at]) m4_include([tests/ovn-ic.at]) m4_include([tests/checkpatch.at]) m4_include([tests/ovn-ipsec.at]) +m4_include([tests/ovn-vif-plug.at])
Signed-off-by: Ihar Hrachyshka <ihrachys@redhat.com> --- controller/test-vif-plug.c | 2 +- tests/ovn-vif-plug.at | 2 +- tests/testsuite.at | 1 + 3 files changed, 3 insertions(+), 2 deletions(-)