[ovs-dev,v2] Fix compilation issue in fedora 37/rawhide.

From: Numan Siddique <numans@ovn.org>

Compilation is failing with the error:

File "Documentation/conf.py", line 61, in <module>
    with open(filename, 'rU') as f:
         ^^^^^^^^^^^^^^^^^^^^
ValueError: invalid mode: 'rU'

The python 3 documentation [1] says:

There is an additional mode character permitted, 'U', which no
longer has any effect, and is considered deprecated. It
previously enabled universal newlines in text mode, which
became the default behaviour in Python 3.0. Refer to the
documentation of the newline parameter for further details.

[1] - https://docs.python.org/3.9/library/functions.html#open

This patch fixes this issue.

Signed-off-by: Numan Siddique <numans@ovn.org>
---
 Documentation/conf.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

On 7/21/22 03:14, numans@ovn.org wrote:
> From: Numan Siddique <numans@ovn.org>
> 
> Compilation is failing with the error:
> 
> File "Documentation/conf.py", line 61, in <module>
>     with open(filename, 'rU') as f:
>          ^^^^^^^^^^^^^^^^^^^^
> ValueError: invalid mode: 'rU'
> 
> The python 3 documentation [1] says:
> 
> There is an additional mode character permitted, 'U', which no
> longer has any effect, and is considered deprecated. It
> previously enabled universal newlines in text mode, which
> became the default behaviour in Python 3.0. Refer to the
> documentation of the newline parameter for further details.
> 
> [1] - https://docs.python.org/3.9/library/functions.html#open
> 
> This patch fixes this issue.
> 
> Signed-off-by: Numan Siddique <numans@ovn.org>
> ---

Looks good to me, thanks!

Acked-by: Dumitru Ceara <dceara@redhat.com>

On Thu, Jul 21, 2022 at 3:44 PM Dumitru Ceara <dceara@redhat.com> wrote:
>
> On 7/21/22 03:14, numans@ovn.org wrote:
> > From: Numan Siddique <numans@ovn.org>
> >
> > Compilation is failing with the error:
> >
> > File "Documentation/conf.py", line 61, in <module>
> >     with open(filename, 'rU') as f:
> >          ^^^^^^^^^^^^^^^^^^^^
> > ValueError: invalid mode: 'rU'
> >
> > The python 3 documentation [1] says:
> >
> > There is an additional mode character permitted, 'U', which no
> > longer has any effect, and is considered deprecated. It
> > previously enabled universal newlines in text mode, which
> > became the default behaviour in Python 3.0. Refer to the
> > documentation of the newline parameter for further details.
> >
> > [1] - https://docs.python.org/3.9/library/functions.html#open
> >
> > This patch fixes this issue.
> >
> > Signed-off-by: Numan Siddique <numans@ovn.org>
> > ---
>
> Looks good to me, thanks!
>
> Acked-by: Dumitru Ceara <dceara@redhat.com>

Thanks.  I applied this patch to main and backported to branch-22.06
and branch-22.03.

Numan

>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>

On 7/22/22 03:18, Numan Siddique wrote:
> On Thu, Jul 21, 2022 at 3:44 PM Dumitru Ceara <dceara@redhat.com> wrote:
>>
>> On 7/21/22 03:14, numans@ovn.org wrote:
>>> From: Numan Siddique <numans@ovn.org>
>>>
>>> Compilation is failing with the error:
>>>
>>> File "Documentation/conf.py", line 61, in <module>
>>>     with open(filename, 'rU') as f:
>>>          ^^^^^^^^^^^^^^^^^^^^
>>> ValueError: invalid mode: 'rU'
>>>
>>> The python 3 documentation [1] says:
>>>
>>> There is an additional mode character permitted, 'U', which no
>>> longer has any effect, and is considered deprecated. It
>>> previously enabled universal newlines in text mode, which
>>> became the default behaviour in Python 3.0. Refer to the
>>> documentation of the newline parameter for further details.
>>>
>>> [1] - https://docs.python.org/3.9/library/functions.html#open
>>>
>>> This patch fixes this issue.
>>>
>>> Signed-off-by: Numan Siddique <numans@ovn.org>
>>> ---
>>
>> Looks good to me, thanks!
>>
>> Acked-by: Dumitru Ceara <dceara@redhat.com>
> 
> Thanks.  I applied this patch to main and backported to branch-22.06
> and branch-22.03.
> 

We're still backporting fixes on demand to branch-21.12.  So I went
ahead and backported this patch there so we have CI running on that
branch too.

Regards,
Dumitru