diff mbox series

[ovs-dev] ovn-nb: Properly document multicast flood config defaults.

Message ID 20220711113029.952402-1-dceara@redhat.com
State Accepted
Headers show
Series [ovs-dev] ovn-nb: Properly document multicast flood config defaults. | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test fail github build: failed
ovsrobot/github-robot-_ovn-kubernetes success github build: passed

Commit Message

Dumitru Ceara July 11, 2022, 11:30 a.m. UTC
Reported-by: Lucas Alvares Gomes <lucasagomes@gmail.com>
Signed-off-by: Dumitru Ceara <dceara@redhat.com>
---
 ovn-nb.xml | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

Comments

Mark Michelson July 11, 2022, 8:31 p.m. UTC | #1
Thanks Dumitru,

Acked-by: Mark Michelson <mmichels@redhat.com>

Since this is such a small thing. I've gone ahead and merged this to 
main, branch-22.03, branch-22.06, branch-21.12.

On 7/11/22 07:30, Dumitru Ceara wrote:
> Reported-by: Lucas Alvares Gomes <lucasagomes@gmail.com>
> Signed-off-by: Dumitru Ceara <dceara@redhat.com>
> ---
>   ovn-nb.xml | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/ovn-nb.xml b/ovn-nb.xml
> index 22b7e8779..e26afd83c 100644
> --- a/ovn-nb.xml
> +++ b/ovn-nb.xml
> @@ -603,6 +603,7 @@
>           Determines whether unregistered multicast traffic should be flooded
>           or not. Only applicable if
>           <ref column="other_config" key="mcast_snoop"/> is enabled.
> +        Default: <code>false</code>.
>         </column>
>         <column name="other_config" key="mcast_table_size"
>             type='{"type": "integer", "minInteger": 1, "maxInteger": 32766}'>
> @@ -1140,12 +1141,13 @@
>                   type='{"type": "boolean"}'>
>             If set to <code>true</code>, multicast packets (except reports) are
>             unconditionally forwarded to the specific port.
> +          Default: <code>false</code>.
>           </column>
>   
>           <column name="options" key="mcast_flood_reports"
>                   type='{"type": "boolean"}'>
>             If set to <code>true</code>, multicast reports are unconditionally
> -          forwarded to the specific port.
> +          forwarded to the specific port.  Default: <code>false</code>.
>           </column>
>         </group>
>   
> @@ -2911,6 +2913,10 @@
>             has <ref table="Logical_Router" column="options"/>:mcast_relay set
>             to <code>true</code>.
>           </p>
> +
> +        <p>
> +          Default: <code>false</code>.
> +        </p>
>         </column>
>   
>         <column name="options" key="requested-tnl-key"
>
diff mbox series

Patch

diff --git a/ovn-nb.xml b/ovn-nb.xml
index 22b7e8779..e26afd83c 100644
--- a/ovn-nb.xml
+++ b/ovn-nb.xml
@@ -603,6 +603,7 @@ 
         Determines whether unregistered multicast traffic should be flooded
         or not. Only applicable if
         <ref column="other_config" key="mcast_snoop"/> is enabled.
+        Default: <code>false</code>.
       </column>
       <column name="other_config" key="mcast_table_size"
           type='{"type": "integer", "minInteger": 1, "maxInteger": 32766}'>
@@ -1140,12 +1141,13 @@ 
                 type='{"type": "boolean"}'>
           If set to <code>true</code>, multicast packets (except reports) are
           unconditionally forwarded to the specific port.
+          Default: <code>false</code>.
         </column>
 
         <column name="options" key="mcast_flood_reports"
                 type='{"type": "boolean"}'>
           If set to <code>true</code>, multicast reports are unconditionally
-          forwarded to the specific port.
+          forwarded to the specific port.  Default: <code>false</code>.
         </column>
       </group>
 
@@ -2911,6 +2913,10 @@ 
           has <ref table="Logical_Router" column="options"/>:mcast_relay set
           to <code>true</code>.
         </p>
+
+        <p>
+          Default: <code>false</code>.
+        </p>
       </column>
 
       <column name="options" key="requested-tnl-key"