diff mbox series

[ovs-dev,v1] Do not set 'up' attribute in the port-binding table if ovn-northd is at an older version.

Message ID 20220506192925.24620-1-mary.manohar@nutanix.com
State Superseded
Headers show
Series [ovs-dev,v1] Do not set 'up' attribute in the port-binding table if ovn-northd is at an older version. | expand

Checks

Context Check Description
ovsrobot/apply-robot warning apply and check: warning
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/github-robot-_ovn-kubernetes fail github build: failed

Commit Message

Mary Manohar May 6, 2022, 7:29 p.m. UTC 
From: Mary Manohar <mary.manohar@nutanix.com>

Signed-off-by: mary.manohar <mary.manohar@nutanix.com>
---
 controller/binding.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

0-day Robot May 6, 2022, 7:39 p.m. UTC | #1 
References:  <20220506192925.24620-1-mary.manohar@nutanix.com>
 

Bleep bloop.  Greetings Mary Manohar, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
ERROR: Author Mary Manohar <mary.manohar@nutanix.com> needs to sign off.
WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: mary.manohar <mary.manohar@nutanix.com>
Lines checked: 28, Warnings: 1, Errors: 1


Please check this out.  If you feel there has been an error, please email aconole@redhat.com

Thanks,
0-day Robot
diff mbox series

Patch

diff --git a/controller/binding.c b/controller/binding.c
index e284704..e7dc537 100644
--- a/controller/binding.c
+++ b/controller/binding.c
@@ -908,7 +908,9 @@  claimed_lport_set_up(const struct sbrec_port_binding *pb,
     if (!notify_up) {
         bool up = true;
         if (!parent_pb || (parent_pb->n_up && parent_pb->up[0])) {
-            sbrec_port_binding_set_up(pb, &up, 1);
+            if (pb->n_up) {
+                sbrec_port_binding_set_up(pb, &up, 1);
+            }
         }
         return;
     }