| Message ID | 20220429074334.200194-1-amusil@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] ci: ovn-kubernetes: Add missing socat package | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | warning | apply and check: warning |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/github-robot-_ovn-kubernetes | success | github build: passed |
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 85 characters long (recommended limit is 79)
#20 FILE: .ci/ovn-kubernetes/Dockerfile:63:
iptables iproute iputils hostname unbound-libs kubernetes-client kmod socat" && \
Lines checked: 26, Warnings: 1, Errors: 0
Please check this out. If you feel there has been an error, please email aconole@redhat.com
Thanks,
0-day Robot
Good catch Ales, Acked-by: Mark Michelson <mmichels@redhat.com> On 4/29/22 03:43, Ales Musil wrote: > Signed-off-by: Ales Musil <amusil@redhat.com> > --- > .ci/ovn-kubernetes/Dockerfile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.ci/ovn-kubernetes/Dockerfile b/.ci/ovn-kubernetes/Dockerfile > index bd220b1e2..19662889e 100644 > --- a/.ci/ovn-kubernetes/Dockerfile > +++ b/.ci/ovn-kubernetes/Dockerfile > @@ -60,7 +60,7 @@ FROM fedora:35 > > # install needed dependencies > RUN INSTALL_PKGS=" \ > - iptables iproute iputils hostname unbound-libs kubernetes-client kmod" && \ > + iptables iproute iputils hostname unbound-libs kubernetes-client kmod socat" && \ > dnf install --best --refresh -y --setopt=tsflags=nodocs $INSTALL_PKGS && \ > dnf clean all && rm -rf /var/cache/dnf/* > >
On 4/29/22 09:43, Ales Musil wrote: > Signed-off-by: Ales Musil <amusil@redhat.com> > --- Acked-by: Dumitru Ceara <dceara@redhat.com> Mark, Numan, could we get this merged soon please, it makes the ovn-kubernetes CI run green again: https://github.com/ovsrobot/ovn/actions/runs/2244105281 Thanks, Dumitru > .ci/ovn-kubernetes/Dockerfile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.ci/ovn-kubernetes/Dockerfile b/.ci/ovn-kubernetes/Dockerfile > index bd220b1e2..19662889e 100644 > --- a/.ci/ovn-kubernetes/Dockerfile > +++ b/.ci/ovn-kubernetes/Dockerfile > @@ -60,7 +60,7 @@ FROM fedora:35 > > # install needed dependencies > RUN INSTALL_PKGS=" \ > - iptables iproute iputils hostname unbound-libs kubernetes-client kmod" && \ > + iptables iproute iputils hostname unbound-libs kubernetes-client kmod socat" && \ > dnf install --best --refresh -y --setopt=tsflags=nodocs $INSTALL_PKGS && \ > dnf clean all && rm -rf /var/cache/dnf/* >
I merged this to main, branch-22.03, and branch-21.12. On 5/11/22 07:34, Dumitru Ceara wrote: > On 4/29/22 09:43, Ales Musil wrote: >> Signed-off-by: Ales Musil <amusil@redhat.com> >> --- > > Acked-by: Dumitru Ceara <dceara@redhat.com> > > Mark, Numan, could we get this merged soon please, it makes the > ovn-kubernetes CI run green again: > > https://github.com/ovsrobot/ovn/actions/runs/2244105281 > > Thanks, > Dumitru > >> .ci/ovn-kubernetes/Dockerfile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/.ci/ovn-kubernetes/Dockerfile b/.ci/ovn-kubernetes/Dockerfile >> index bd220b1e2..19662889e 100644 >> --- a/.ci/ovn-kubernetes/Dockerfile >> +++ b/.ci/ovn-kubernetes/Dockerfile >> @@ -60,7 +60,7 @@ FROM fedora:35 >> >> # install needed dependencies >> RUN INSTALL_PKGS=" \ >> - iptables iproute iputils hostname unbound-libs kubernetes-client kmod" && \ >> + iptables iproute iputils hostname unbound-libs kubernetes-client kmod socat" && \ >> dnf install --best --refresh -y --setopt=tsflags=nodocs $INSTALL_PKGS && \ >> dnf clean all && rm -rf /var/cache/dnf/* >> >
diff --git a/.ci/ovn-kubernetes/Dockerfile b/.ci/ovn-kubernetes/Dockerfile index bd220b1e2..19662889e 100644 --- a/.ci/ovn-kubernetes/Dockerfile +++ b/.ci/ovn-kubernetes/Dockerfile @@ -60,7 +60,7 @@ FROM fedora:35 # install needed dependencies RUN INSTALL_PKGS=" \ - iptables iproute iputils hostname unbound-libs kubernetes-client kmod" && \ + iptables iproute iputils hostname unbound-libs kubernetes-client kmod socat" && \ dnf install --best --refresh -y --setopt=tsflags=nodocs $INSTALL_PKGS && \ dnf clean all && rm -rf /var/cache/dnf/*
Signed-off-by: Ales Musil <amusil@redhat.com> --- .ci/ovn-kubernetes/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)