| Message ID | 20220224010615.1406222-1-hzhou@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] lflow.c: Reapply the dbg log fix for handling a lflow for a non-local DP. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | fail | github build: failed |
| ovsrobot/github-robot-_ovn-kubernetes | fail | github build: failed |
On Wed, Feb 23, 2022 at 8:23 PM Han Zhou <hzhou@ovn.org> wrote: > > Reapply commit 385aedba7 ("lflow.c: Improve the debug log when handling > a lflow for a non-local DP.") which was dropped during the merge of the > commit 979feccd. > > Fixes: 979feccd ("controller: Use precomputed is_switch instead of querying external IDs.") > Signed-off-by: Han Zhou <hzhou@ovn.org> Acked-by: Numan Siddique <numans@ovn.org> Numan > --- > controller/lflow.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/controller/lflow.c b/controller/lflow.c > index 4a5c828cd..e936bb9f9 100644 > --- a/controller/lflow.c > +++ b/controller/lflow.c > @@ -795,8 +795,8 @@ consider_logical_flow__(const struct sbrec_logical_flow *lflow, > struct local_datapath *ldp = get_local_datapath(l_ctx_in->local_datapaths, > dp->tunnel_key); > if (!ldp) { > - VLOG_DBG("lflow "UUID_FMT" is not for local datapath, skip", > - UUID_ARGS(&lflow->header_.uuid)); > + VLOG_DBG("Skip lflow "UUID_FMT" for non-local datapath %"PRId64, > + UUID_ARGS(&lflow->header_.uuid), dp->tunnel_key); > return; > } > > -- > 2.30.2 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
On Wed, Feb 23, 2022 at 5:48 PM Numan Siddique <numans@ovn.org> wrote: > > On Wed, Feb 23, 2022 at 8:23 PM Han Zhou <hzhou@ovn.org> wrote: > > > > Reapply commit 385aedba7 ("lflow.c: Improve the debug log when handling > > a lflow for a non-local DP.") which was dropped during the merge of the > > commit 979feccd. > > > > Fixes: 979feccd ("controller: Use precomputed is_switch instead of querying external IDs.") > > Signed-off-by: Han Zhou <hzhou@ovn.org> > > Acked-by: Numan Siddique <numans@ovn.org> > > Numan Thanks Numan. Applied. > > > --- > > controller/lflow.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/controller/lflow.c b/controller/lflow.c > > index 4a5c828cd..e936bb9f9 100644 > > --- a/controller/lflow.c > > +++ b/controller/lflow.c > > @@ -795,8 +795,8 @@ consider_logical_flow__(const struct sbrec_logical_flow *lflow, > > struct local_datapath *ldp = get_local_datapath(l_ctx_in->local_datapaths, > > dp->tunnel_key); > > if (!ldp) { > > - VLOG_DBG("lflow "UUID_FMT" is not for local datapath, skip", > > - UUID_ARGS(&lflow->header_.uuid)); > > + VLOG_DBG("Skip lflow "UUID_FMT" for non-local datapath %"PRId64, > > + UUID_ARGS(&lflow->header_.uuid), dp->tunnel_key); > > return; > > } > > > > -- > > 2.30.2 > > > > _______________________________________________ > > dev mailing list > > dev@openvswitch.org > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > >
diff --git a/controller/lflow.c b/controller/lflow.c index 4a5c828cd..e936bb9f9 100644 --- a/controller/lflow.c +++ b/controller/lflow.c @@ -795,8 +795,8 @@ consider_logical_flow__(const struct sbrec_logical_flow *lflow, struct local_datapath *ldp = get_local_datapath(l_ctx_in->local_datapaths, dp->tunnel_key); if (!ldp) { - VLOG_DBG("lflow "UUID_FMT" is not for local datapath, skip", - UUID_ARGS(&lflow->header_.uuid)); + VLOG_DBG("Skip lflow "UUID_FMT" for non-local datapath %"PRId64, + UUID_ARGS(&lflow->header_.uuid), dp->tunnel_key); return; }
Reapply commit 385aedba7 ("lflow.c: Improve the debug log when handling a lflow for a non-local DP.") which was dropped during the merge of the commit 979feccd. Fixes: 979feccd ("controller: Use precomputed is_switch instead of querying external IDs.") Signed-off-by: Han Zhou <hzhou@ovn.org> --- controller/lflow.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)