| Message ID | 20220208173005.2577916-1-mmichels@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev,v2] northd: Document --dummy-numa option. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | warning | apply and check: warning |
| ovsrobot/github-robot-_Build_and_Test | fail | github build: failed |
| ovsrobot/github-robot-_ovn-kubernetes | fail | github build: failed |
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) WARNING: Line lacks whitespace around operator #80 FILE: northd/ovn-northd.c:528: --dummy-numa override default NUMA node and CPU core discovery\n\ Lines checked: 86, Warnings: 2, Errors: 0 Please check this out. If you feel there has been an error, please email aconole@redhat.com Thanks, 0-day Robot
On Tue, Feb 8, 2022 at 12:30 PM Mark Michelson <mmichels@redhat.com> wrote: > > Signed-off-by: Mark Michelson <mmichels@redhat.com> LGTM. Acked-by: Numan Siddique <numans@ovn.org> Numan > --- > v1 -> v2: > * Fixed a mismatched <p> tag in the XML > --- > northd/ovn-northd.8.xml | 49 +++++++++++++++++++++++++++++++++++++++++ > northd/ovn-northd.c | 1 + > 2 files changed, 50 insertions(+) > > diff --git a/northd/ovn-northd.8.xml b/northd/ovn-northd.8.xml > index 79f35bc16..cd2617b0a 100644 > --- a/northd/ovn-northd.8.xml > +++ b/northd/ovn-northd.8.xml > @@ -68,6 +68,55 @@ > restarting a process or disturbing a running system. > </p> > </dd> > + <dt><code>--dummy-numa</code></dt> > + <dd> > + <p> > + Typically, OVS uses sysfs to determine the number of NUMA nodes and > + CPU cores that are available on a machine. The parallelization code > + in OVN uses this information to determine if there are enough > + resources to use parallelization. The current algorithm enables > + parallelization if the total number of CPU cores divided by the > + number of NUMA nodes is greater than or equal to four. > + </p> > + > + <p> > + In certain situations, it may be desirable to enable parallelization > + on a system that otherwise would not have it allowed. The > + <code>--dummy-numa</code> option allows for you to fake the NUMA > + nodes and cores that OVS thinks your system has. The syntax consists > + of using numbers to represent the NUMA node IDs. The number of times > + that a NUMA node ID appears represents how many CPU cores that NUMA > + node contains. So for instance, if you did the following: > + </p> > + > + <p> > + <code>--dummy-numa=0,0,0,0</code> > + </p> > + > + <p> > + it would make OVS assume that you have a single NUMA node with ID 0, > + and that NUMA node consists of four CPU cores. Similarly, you could > + do: > + </p> > + > + <p> > + <code>--dummy-numa=0,0,0,0,0,0,1,1,1,1,1,1</code> > + </p> > + > + <p> > + to make OVS assume you have two NUMA nodes with IDs 0 and 1, each > + with six CPU cores. > + </p> > + > + <p> > + Currently, the only affect this option has is on whether > + parallelization can be enabled in ovn-northd. There are no NUMA node > + or CPU core-specific actions performed by OVN. Setting > + <code>--dummy-numa</code> in ovn-northd does not affect how other OVS > + processes on the system (such as ovs-vswitchd) count the number of > + NUMA nodes and CPU cores; this setting is local to ovn-northd. > + </p> > + </dd> > </dl> > <p> > <var>database</var> in the above options must be an OVSDB active or > diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c > index 80303503a..44d4ca706 100644 > --- a/northd/ovn-northd.c > +++ b/northd/ovn-northd.c > @@ -525,6 +525,7 @@ Options:\n\ > --ovnsb-db=DATABASE connect to ovn-sb database at DATABASE\n\ > (default: %s)\n\ > --dry-run start in paused state (do not commit db changes)\n\ > + --dummy-numa override default NUMA node and CPU core discovery\n\ > --unixctl=SOCKET override default control socket name\n\ > -h, --help display this help message\n\ > -o, --options list available options\n\ > -- > 2.31.1 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
On 2/9/22 14:04, Numan Siddique wrote: > On Tue, Feb 8, 2022 at 12:30 PM Mark Michelson <mmichels@redhat.com> wrote: >> >> Signed-off-by: Mark Michelson <mmichels@redhat.com> > > LGTM. > > Acked-by: Numan Siddique <numans@ovn.org> > > Numan > I pushed this to the main branch. > > >> --- >> v1 -> v2: >> * Fixed a mismatched <p> tag in the XML >> --- >> northd/ovn-northd.8.xml | 49 +++++++++++++++++++++++++++++++++++++++++ >> northd/ovn-northd.c | 1 + >> 2 files changed, 50 insertions(+) >> >> diff --git a/northd/ovn-northd.8.xml b/northd/ovn-northd.8.xml >> index 79f35bc16..cd2617b0a 100644 >> --- a/northd/ovn-northd.8.xml >> +++ b/northd/ovn-northd.8.xml >> @@ -68,6 +68,55 @@ >> restarting a process or disturbing a running system. >> </p> >> </dd> >> + <dt><code>--dummy-numa</code></dt> >> + <dd> >> + <p> >> + Typically, OVS uses sysfs to determine the number of NUMA nodes and >> + CPU cores that are available on a machine. The parallelization code >> + in OVN uses this information to determine if there are enough >> + resources to use parallelization. The current algorithm enables >> + parallelization if the total number of CPU cores divided by the >> + number of NUMA nodes is greater than or equal to four. >> + </p> >> + >> + <p> >> + In certain situations, it may be desirable to enable parallelization >> + on a system that otherwise would not have it allowed. The >> + <code>--dummy-numa</code> option allows for you to fake the NUMA >> + nodes and cores that OVS thinks your system has. The syntax consists >> + of using numbers to represent the NUMA node IDs. The number of times >> + that a NUMA node ID appears represents how many CPU cores that NUMA >> + node contains. So for instance, if you did the following: >> + </p> >> + >> + <p> >> + <code>--dummy-numa=0,0,0,0</code> >> + </p> >> + >> + <p> >> + it would make OVS assume that you have a single NUMA node with ID 0, >> + and that NUMA node consists of four CPU cores. Similarly, you could >> + do: >> + </p> >> + >> + <p> >> + <code>--dummy-numa=0,0,0,0,0,0,1,1,1,1,1,1</code> >> + </p> >> + >> + <p> >> + to make OVS assume you have two NUMA nodes with IDs 0 and 1, each >> + with six CPU cores. >> + </p> >> + >> + <p> >> + Currently, the only affect this option has is on whether >> + parallelization can be enabled in ovn-northd. There are no NUMA node >> + or CPU core-specific actions performed by OVN. Setting >> + <code>--dummy-numa</code> in ovn-northd does not affect how other OVS >> + processes on the system (such as ovs-vswitchd) count the number of >> + NUMA nodes and CPU cores; this setting is local to ovn-northd. >> + </p> >> + </dd> >> </dl> >> <p> >> <var>database</var> in the above options must be an OVSDB active or >> diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c >> index 80303503a..44d4ca706 100644 >> --- a/northd/ovn-northd.c >> +++ b/northd/ovn-northd.c >> @@ -525,6 +525,7 @@ Options:\n\ >> --ovnsb-db=DATABASE connect to ovn-sb database at DATABASE\n\ >> (default: %s)\n\ >> --dry-run start in paused state (do not commit db changes)\n\ >> + --dummy-numa override default NUMA node and CPU core discovery\n\ >> --unixctl=SOCKET override default control socket name\n\ >> -h, --help display this help message\n\ >> -o, --options list available options\n\ >> -- >> 2.31.1 >> >> _______________________________________________ >> dev mailing list >> dev@openvswitch.org >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >> >
diff --git a/northd/ovn-northd.8.xml b/northd/ovn-northd.8.xml index 79f35bc16..cd2617b0a 100644 --- a/northd/ovn-northd.8.xml +++ b/northd/ovn-northd.8.xml @@ -68,6 +68,55 @@ restarting a process or disturbing a running system. </p> </dd> + <dt><code>--dummy-numa</code></dt> + <dd> + <p> + Typically, OVS uses sysfs to determine the number of NUMA nodes and + CPU cores that are available on a machine. The parallelization code + in OVN uses this information to determine if there are enough + resources to use parallelization. The current algorithm enables + parallelization if the total number of CPU cores divided by the + number of NUMA nodes is greater than or equal to four. + </p> + + <p> + In certain situations, it may be desirable to enable parallelization + on a system that otherwise would not have it allowed. The + <code>--dummy-numa</code> option allows for you to fake the NUMA + nodes and cores that OVS thinks your system has. The syntax consists + of using numbers to represent the NUMA node IDs. The number of times + that a NUMA node ID appears represents how many CPU cores that NUMA + node contains. So for instance, if you did the following: + </p> + + <p> + <code>--dummy-numa=0,0,0,0</code> + </p> + + <p> + it would make OVS assume that you have a single NUMA node with ID 0, + and that NUMA node consists of four CPU cores. Similarly, you could + do: + </p> + + <p> + <code>--dummy-numa=0,0,0,0,0,0,1,1,1,1,1,1</code> + </p> + + <p> + to make OVS assume you have two NUMA nodes with IDs 0 and 1, each + with six CPU cores. + </p> + + <p> + Currently, the only affect this option has is on whether + parallelization can be enabled in ovn-northd. There are no NUMA node + or CPU core-specific actions performed by OVN. Setting + <code>--dummy-numa</code> in ovn-northd does not affect how other OVS + processes on the system (such as ovs-vswitchd) count the number of + NUMA nodes and CPU cores; this setting is local to ovn-northd. + </p> + </dd> </dl> <p> <var>database</var> in the above options must be an OVSDB active or diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index 80303503a..44d4ca706 100644 --- a/northd/ovn-northd.c +++ b/northd/ovn-northd.c @@ -525,6 +525,7 @@ Options:\n\ --ovnsb-db=DATABASE connect to ovn-sb database at DATABASE\n\ (default: %s)\n\ --dry-run start in paused state (do not commit db changes)\n\ + --dummy-numa override default NUMA node and CPU core discovery\n\ --unixctl=SOCKET override default control socket name\n\ -h, --help display this help message\n\ -o, --options list available options\n\
Signed-off-by: Mark Michelson <mmichels@redhat.com> --- v1 -> v2: * Fixed a mismatched <p> tag in the XML --- northd/ovn-northd.8.xml | 49 +++++++++++++++++++++++++++++++++++++++++ northd/ovn-northd.c | 1 + 2 files changed, 50 insertions(+)