diff mbox series

[ovs-dev,2/2] tests: fix flaky VXLAN check port/datapath key space limits test

Message ID 20211123170739.86576-2-odivlad@gmail.com
State Changes Requested, archived
Headers show
Series [ovs-dev,1/2] northd: allow having VXLAN encaps in ovn-ic enabled setup | expand

Checks

Context Check Description
ovsrobot/apply-robot fail apply and check: fail

Commit Message

Vladislav Odintsov Nov. 23, 2021, 5:07 p.m. UTC 
OVN requested-tnl-key VXLAN checks affect tunnel_key in
datapath_binding record only on datapath tunnel key assigning.
If a dp tnl key was already assigned and VXLAN-enabled chassis
is added after that, the value would never be changed.

The test didn't check the VXLAN-enabled chassis was created and
thus test could fail like this:

ovn.at:3777: waiting until test x`ovn-nbctl lsp-get-up lsp-bad` = xup...
ovn.at:3777: wait succeeded immediately
./ovn.at:3777: ovn-sbctl get Datapath_Binding ls-bad tunnel_key

Comments

0-day Robot Nov. 23, 2021, 5:19 p.m. UTC | #1 
Bleep bloop.  Greetings Vladislav Odintsov, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


git-am:
error: sha1 information is lacking or useless (builddir/build/BUILD/ovn-21.09.90/tests/testsuite.dir/at-groups/104/stdout).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch' to see the failed patch
Patch failed at 0001 tests: fix flaky VXLAN check port/datapath key space limits test
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".


Please check this out.  If you feel there has been an error, please email aconole@redhat.com

Thanks,
0-day Robot
diff mbox series

Patch

--- -	2021-11-23 17:34:51.646403185 +0300
+++ /builddir/build/BUILD/ovn-21.09.90/tests/testsuite.dir/at-groups/104/stdout	2021-11-23 17:34:51.644406189 +0300
@@ -1,2 +1,2 @@ 
-1
+5000

This patch fixes such fail by adding await for chassis to be
registered in SB DB.

Signed-off-by: Vladislav Odintsov <odivlad@gmail.com>
---
 tests/ovn.at | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/ovn.at b/tests/ovn.at
index 965eed809..c39f3162e 100644
--- a/tests/ovn.at
+++ b/tests/ovn.at
@@ -3783,6 +3783,7 @@  check ovs-vsctl add-br br-phys
 check ovs-vsctl set open . external-ids:ovn-bridge-mappings=phys:br-phys
 ovn_attach net br-phys 192.168.0.1 24 vxlan
 check ovn-nbctl --wait=sb sync
+OVS_WAIT_UNTIL([ovn-sbctl get chassis main _uuid])
 
 check ovn-nbctl ls-add ls-bad -- \
     set Logical_Switch ls-bad other_config:requested-tnl-key=5000