diff mbox series

[ovs-dev] tests: fix flaky "ovn-ic -- gateway sync" test

Message ID 20211007174953.302-1-odivlad@gmail.com
State Superseded, archived
Headers show
Series [ovs-dev] tests: fix flaky "ovn-ic -- gateway sync" test | expand

Checks

Context Check Description
ovsrobot/apply-robot fail apply and check: fail

Commit Message

Vladislav Odintsov Oct. 7, 2021, 5:49 p.m. UTC 
Sometimes when ovn-ic daemon was running less quick that usual
(more often in ASAN tests), test 'ovn-ic -- gateway sync'
failed if chassis was not created yet.

This patch fixes such situation by adding await for chassis to
appear.

../../../tests/ovn-ic.at:119: ovn_as az2 ovn-sbctl show | sort -r

Comments

0-day Robot Oct. 7, 2021, 6:01 p.m. UTC | #1 
Bleep bloop.  Greetings Vladislav Odintsov, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


git-am:
error: sha1 information is lacking or useless (home/runner/work/ovn/ovn/ovn-21.09.90/_build/sub/tests/testsuite.dir/at-groups/1069/stdout).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch' to see the failed patch
Patch failed at 0001 tests: fix flaky "ovn-ic -- gateway sync" test
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".


Please check this out.  If you feel there has been an error, please email aconole@redhat.com

Thanks,
0-day Robot
diff mbox series

Patch

--- -	2021-10-07 12:50:45.178529089 +0000
+++ /home/runner/work/ovn/ovn/ovn-21.09.90/_build/sub/tests/testsuite.dir/at-groups/1069/stdout	2021-10-07 12:50:45.169509348 +0000
@@ -1,9 +1 @@ 
-Chassis gw1
-    hostname: gw1
-    Encap vxlan
-    Encap geneve
-        options: {csum="true"}
-        options: {csum="true"}
-        ip: "192.168.0.1"
-        ip: "192.168.0.1"

1069. ovn-ic.at:119: 1069. ovn-ic -- gateway sync -- ovn-northd -- dp-groups=no (ovn-ic.at:119): FAILED (ovn-ic.at:119)

Signed-off-by: Vladislav Odintsov <odivlad@gmail.com>
---
 tests/ovn-ic.at | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/ovn-ic.at b/tests/ovn-ic.at
index 15560334d..3faa9629a 100644
--- a/tests/ovn-ic.at
+++ b/tests/ovn-ic.at
@@ -129,6 +129,7 @@  ovs-vsctl add-br br-phys
 ovn_az_attach az1 n1 br-phys 192.168.0.1
 ovs-vsctl set open . external-ids:ovn-is-interconn=true external-ids:hostname=gw1
 
+OVS_WAIT_UNTIL([ovn_as az2 ovn-sbctl show | grep "192.168.0.1"])
 AT_CHECK([ovn_as az2 ovn-sbctl show | sort -r], [0], [dnl
 Chassis gw1
     hostname: gw1