| Message ID | 20210810161537.71692-1-odivlad@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] northd: fix xxreg{0, 1} registers usage description in router pipeline | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-Build_and_Test | success | github build: passed |
| ovsrobot/github-robot-ovn-kubernetes | fail | github build: failed |
On Tue, Aug 10, 2021 at 12:16 PM Vladislav Odintsov <odivlad@gmail.com> wrote: > > XXREG0 and XXREG1 (128-bit registers), are currently used in > router pipeline to store NEXT_HOP_IPV6 and SRC_IPV6 respectively. > > First time XXREG0 register is written - in stage lr_in_defrag. > XXREG1 register is written first in lr_in_ip_routing. > This patch updates documentation, where it was wrongly pointed to > lr_in_ip_input router stage. > > Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2021-August/386607.html > Signed-off-by: Vladislav Odintsov <odivlad@gmail.com> Thanks for the fix. The patch was missing the same changes for ovn_northd.dl. So I updated the patch and applied to the main branch. Thanks Numan > --- > northd/ovn-northd.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c > index 4c164a744..713d81e4c 100644 > --- a/northd/ovn-northd.c > +++ b/northd/ovn-northd.c > @@ -312,7 +312,7 @@ enum ovn_stage { > * +-----+--------------------------+ G | (< IP_INPUT) | X | | > * | R1 | SRC_IPV4 for ARP-REQ | 0 | | R | | > * | | (>= IP_INPUT) | | | E | NEXT_HOP_IPV6 | > - * +-----+--------------------------+---+-----------------+ G | (>= IP_INPUT) | > + * +-----+--------------------------+---+-----------------+ G | ( >= DEFRAG ) | > * | R2 | UNUSED | X | | 0 | | > * | | | R | | | | > * +-----+--------------------------+ E | UNUSED | | | > @@ -324,8 +324,8 @@ enum ovn_stage { > * +-----+--------------------------+ E | UNUSED | X | | > * | R5 | UNUSED | G | | X | | > * | | | 2 | | R |SRC_IPV6 for NS| > - * +-----+--------------------------+---+-----------------+ E | (>= IP_INPUT) | > - * | R6 | UNUSED | X | | G | | > + * +-----+--------------------------+---+-----------------+ E | ( >= | > + * | R6 | UNUSED | X | | G | IN_IP_ROUTING)| > * | | | R | | 1 | | > * +-----+--------------------------+ E | UNUSED | | | > * | R7 | UNUSED | G | | | | > -- > 2.30.0 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index 4c164a744..713d81e4c 100644 --- a/northd/ovn-northd.c +++ b/northd/ovn-northd.c @@ -312,7 +312,7 @@ enum ovn_stage { * +-----+--------------------------+ G | (< IP_INPUT) | X | | * | R1 | SRC_IPV4 for ARP-REQ | 0 | | R | | * | | (>= IP_INPUT) | | | E | NEXT_HOP_IPV6 | - * +-----+--------------------------+---+-----------------+ G | (>= IP_INPUT) | + * +-----+--------------------------+---+-----------------+ G | ( >= DEFRAG ) | * | R2 | UNUSED | X | | 0 | | * | | | R | | | | * +-----+--------------------------+ E | UNUSED | | | @@ -324,8 +324,8 @@ enum ovn_stage { * +-----+--------------------------+ E | UNUSED | X | | * | R5 | UNUSED | G | | X | | * | | | 2 | | R |SRC_IPV6 for NS| - * +-----+--------------------------+---+-----------------+ E | (>= IP_INPUT) | - * | R6 | UNUSED | X | | G | | + * +-----+--------------------------+---+-----------------+ E | ( >= | + * | R6 | UNUSED | X | | G | IN_IP_ROUTING)| * | | | R | | 1 | | * +-----+--------------------------+ E | UNUSED | | | * | R7 | UNUSED | G | | | |
XXREG0 and XXREG1 (128-bit registers), are currently used in router pipeline to store NEXT_HOP_IPV6 and SRC_IPV6 respectively. First time XXREG0 register is written - in stage lr_in_defrag. XXREG1 register is written first in lr_in_ip_routing. This patch updates documentation, where it was wrongly pointed to lr_in_ip_input router stage. Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2021-August/386607.html Signed-off-by: Vladislav Odintsov <odivlad@gmail.com> --- northd/ovn-northd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)