| Message ID | 20210723112101.2395-1-dceara@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] ci: Use a newer version of ovn-kubernetes to improve reliability of the runs. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
On 23/07/2021 12:21, Dumitru Ceara wrote: > With the ovn-kubernetes version currently tagged for use within OVN CI > there were often failures that were unrelated to OVN itself. > > Update to the current ovn-kubernetes master branch version for improved > reliability of the test runs. > > Changes in ovn-kubernetes between the two versions: > https://github.com/ovn-org/ovn-kubernetes/compare/f669ef6d35c86bf46d7a1055072e48ea1506f88c...c9cd438575f11584871309740c78dde29752940b > > Signed-off-by: Dumitru Ceara <dceara@redhat.com> > --- > Successful ovn-kubernetes CI run (also when rerun) with this patch > applied: > https://github.com/dceara/ovn/runs/3142362509?check_suite_focus=true > --- > .github/workflows/ovn-kubernetes.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.github/workflows/ovn-kubernetes.yml b/.github/workflows/ovn-kubernetes.yml > index ee77613f6..03721c109 100644 > --- a/.github/workflows/ovn-kubernetes.yml > +++ b/.github/workflows/ovn-kubernetes.yml > @@ -11,7 +11,7 @@ on: > env: > GO_VERSION: "1.16.3" > K8S_VERSION: v1.20.2 > - OVNKUBE_COMMIT: "f669ef6d35c86bf46d7a1055072e48ea1506f88c" > + OVNKUBE_COMMIT: "c9cd438575f11584871309740c78dde29752940b" > KIND_CLUSTER_NAME: ovn > KIND_INSTALL_INGRESS: true > KIND_ALLOW_SYSTEM_WRITES: true > Any particular reason why you chose this commit? I wonder what our policy should be to decide when (and to what commit) we should bump to? Acked-by: Mark D. Gray <mark.d.gray@redhat.com>
On 7/23/21 5:06 PM, Mark Gray wrote: > On 23/07/2021 12:21, Dumitru Ceara wrote: >> With the ovn-kubernetes version currently tagged for use within OVN CI >> there were often failures that were unrelated to OVN itself. >> >> Update to the current ovn-kubernetes master branch version for improved >> reliability of the test runs. >> >> Changes in ovn-kubernetes between the two versions: >> https://github.com/ovn-org/ovn-kubernetes/compare/f669ef6d35c86bf46d7a1055072e48ea1506f88c...c9cd438575f11584871309740c78dde29752940b >> >> Signed-off-by: Dumitru Ceara <dceara@redhat.com> >> --- >> Successful ovn-kubernetes CI run (also when rerun) with this patch >> applied: >> https://github.com/dceara/ovn/runs/3142362509?check_suite_focus=true >> --- >> .github/workflows/ovn-kubernetes.yml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/.github/workflows/ovn-kubernetes.yml b/.github/workflows/ovn-kubernetes.yml >> index ee77613f6..03721c109 100644 >> --- a/.github/workflows/ovn-kubernetes.yml >> +++ b/.github/workflows/ovn-kubernetes.yml >> @@ -11,7 +11,7 @@ on: >> env: >> GO_VERSION: "1.16.3" >> K8S_VERSION: v1.20.2 >> - OVNKUBE_COMMIT: "f669ef6d35c86bf46d7a1055072e48ea1506f88c" >> + OVNKUBE_COMMIT: "c9cd438575f11584871309740c78dde29752940b" >> KIND_CLUSTER_NAME: ovn >> KIND_INSTALL_INGRESS: true >> KIND_ALLOW_SYSTEM_WRITES: true >> > > Any particular reason why you chose this commit? I wonder what our > policy should be to decide when (and to what commit) we should bump to? I just chose the current master commit in ovn-kubernetes because tests seem to be less flaky with it. I agree we need a policy for how to bump this version from now on, but for now, I just wanted to try to have the ovn-kubernetes job pass more often (it currently fails on almost every run). > > Acked-by: Mark D. Gray <mark.d.gray@redhat.com> > Thanks for the review!
On Fri, Jul 23, 2021, 11:47 AM Dumitru Ceara <dceara@redhat.com> wrote: > On 7/23/21 5:06 PM, Mark Gray wrote: > > On 23/07/2021 12:21, Dumitru Ceara wrote: > >> With the ovn-kubernetes version currently tagged for use within OVN CI > >> there were often failures that were unrelated to OVN itself. > >> > >> Update to the current ovn-kubernetes master branch version for improved > >> reliability of the test runs. > >> > >> Changes in ovn-kubernetes between the two versions: > >> > https://github.com/ovn-org/ovn-kubernetes/compare/f669ef6d35c86bf46d7a1055072e48ea1506f88c...c9cd438575f11584871309740c78dde29752940b > >> > >> Signed-off-by: Dumitru Ceara <dceara@redhat.com> > >> --- > >> Successful ovn-kubernetes CI run (also when rerun) with this patch > >> applied: > >> https://github.com/dceara/ovn/runs/3142362509?check_suite_focus=true > >> --- > >> .github/workflows/ovn-kubernetes.yml | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/.github/workflows/ovn-kubernetes.yml > b/.github/workflows/ovn-kubernetes.yml > >> index ee77613f6..03721c109 100644 > >> --- a/.github/workflows/ovn-kubernetes.yml > >> +++ b/.github/workflows/ovn-kubernetes.yml > >> @@ -11,7 +11,7 @@ on: > >> env: > >> GO_VERSION: "1.16.3" > >> K8S_VERSION: v1.20.2 > >> - OVNKUBE_COMMIT: "f669ef6d35c86bf46d7a1055072e48ea1506f88c" > >> + OVNKUBE_COMMIT: "c9cd438575f11584871309740c78dde29752940b" > >> KIND_CLUSTER_NAME: ovn > >> KIND_INSTALL_INGRESS: true > >> KIND_ALLOW_SYSTEM_WRITES: true > >> > > > > Any particular reason why you chose this commit? I wonder what our > > policy should be to decide when (and to what commit) we should bump to? > > I just chose the current master commit in ovn-kubernetes because tests > seem to be less flaky with it. > > I agree we need a policy for how to bump this version from now on, but > for now, I just wanted to try to have the ovn-kubernetes job pass more > often (it currently fails on almost every run). > > > > > Acked-by: Mark D. Gray <mark.d.gray@redhat.com> > > > > Thanks for the review! > Thanks. I applied this patch. Numan > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > >
On 7/23/21 6:05 PM, Numan Siddique wrote: > On Fri, Jul 23, 2021, 11:47 AM Dumitru Ceara <dceara@redhat.com> wrote: > >> On 7/23/21 5:06 PM, Mark Gray wrote: >>> On 23/07/2021 12:21, Dumitru Ceara wrote: >>>> With the ovn-kubernetes version currently tagged for use within OVN CI >>>> there were often failures that were unrelated to OVN itself. >>>> >>>> Update to the current ovn-kubernetes master branch version for improved >>>> reliability of the test runs. >>>> >>>> Changes in ovn-kubernetes between the two versions: >>>> >> https://github.com/ovn-org/ovn-kubernetes/compare/f669ef6d35c86bf46d7a1055072e48ea1506f88c...c9cd438575f11584871309740c78dde29752940b >>>> >>>> Signed-off-by: Dumitru Ceara <dceara@redhat.com> >>>> --- >>>> Successful ovn-kubernetes CI run (also when rerun) with this patch >>>> applied: >>>> https://github.com/dceara/ovn/runs/3142362509?check_suite_focus=true >>>> --- >>>> .github/workflows/ovn-kubernetes.yml | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/.github/workflows/ovn-kubernetes.yml >> b/.github/workflows/ovn-kubernetes.yml >>>> index ee77613f6..03721c109 100644 >>>> --- a/.github/workflows/ovn-kubernetes.yml >>>> +++ b/.github/workflows/ovn-kubernetes.yml >>>> @@ -11,7 +11,7 @@ on: >>>> env: >>>> GO_VERSION: "1.16.3" >>>> K8S_VERSION: v1.20.2 >>>> - OVNKUBE_COMMIT: "f669ef6d35c86bf46d7a1055072e48ea1506f88c" >>>> + OVNKUBE_COMMIT: "c9cd438575f11584871309740c78dde29752940b" >>>> KIND_CLUSTER_NAME: ovn >>>> KIND_INSTALL_INGRESS: true >>>> KIND_ALLOW_SYSTEM_WRITES: true >>>> >>> >>> Any particular reason why you chose this commit? I wonder what our >>> policy should be to decide when (and to what commit) we should bump to? >> >> I just chose the current master commit in ovn-kubernetes because tests >> seem to be less flaky with it. >> >> I agree we need a policy for how to bump this version from now on, but >> for now, I just wanted to try to have the ovn-kubernetes job pass more >> often (it currently fails on almost every run). >> >>> >>> Acked-by: Mark D. Gray <mark.d.gray@redhat.com> >>> >> >> Thanks for the review! >> > > > Thanks. I applied this patch. > > Numan > + Antonio, Dan I stand corrected, we just got one more failure with this version too, sorry for the noise: https://github.com/ovn-org/ovn/actions/runs/1060150002 I *think* those are test issues but we probably need to investigate some more. I wonder if it makes sense to skip the ones that have issues for now. Thoughts? Regards, Dumitru
diff --git a/.github/workflows/ovn-kubernetes.yml b/.github/workflows/ovn-kubernetes.yml index ee77613f6..03721c109 100644 --- a/.github/workflows/ovn-kubernetes.yml +++ b/.github/workflows/ovn-kubernetes.yml @@ -11,7 +11,7 @@ on: env: GO_VERSION: "1.16.3" K8S_VERSION: v1.20.2 - OVNKUBE_COMMIT: "f669ef6d35c86bf46d7a1055072e48ea1506f88c" + OVNKUBE_COMMIT: "c9cd438575f11584871309740c78dde29752940b" KIND_CLUSTER_NAME: ovn KIND_INSTALL_INGRESS: true KIND_ALLOW_SYSTEM_WRITES: true
With the ovn-kubernetes version currently tagged for use within OVN CI there were often failures that were unrelated to OVN itself. Update to the current ovn-kubernetes master branch version for improved reliability of the test runs. Changes in ovn-kubernetes between the two versions: https://github.com/ovn-org/ovn-kubernetes/compare/f669ef6d35c86bf46d7a1055072e48ea1506f88c...c9cd438575f11584871309740c78dde29752940b Signed-off-by: Dumitru Ceara <dceara@redhat.com> --- Successful ovn-kubernetes CI run (also when rerun) with this patch applied: https://github.com/dceara/ovn/runs/3142362509?check_suite_focus=true --- .github/workflows/ovn-kubernetes.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)