Message ID | 20210709184919.1012951-1-hzhou@ovn.org |
---|---|
State | Accepted |
Headers | show |
Series | [ovs-dev] ovn-nb.xml: Fix the description for LB's skip_snat option. | expand |
Context | Check | Description |
---|---|---|
ovsrobot/apply-robot | success | apply and check: success |
On Fri, Jul 9, 2021 at 2:49 PM Han Zhou <hzhou@ovn.org> wrote: > > lb_force_snat_ip is a flag set in logical flow pipeline, while > lb_force_snat_ip is the option configured in NB DB. In NB document we > should mention the actual option configured in NB instead of the flow > details. > > Signed-off-by: Han Zhou <hzhou@ovn.org> Acked-by: Numan Siddique <numans@ovn.org> Numan > --- > ovn-nb.xml | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/ovn-nb.xml b/ovn-nb.xml > index b6a0d1f43..d5efbb33e 100644 > --- a/ovn-nb.xml > +++ b/ovn-nb.xml > @@ -1712,8 +1712,9 @@ > > <column name="options" key="skip_snat"> > If the load balancing rule is configured with <code>skip_snat</code> > - option, the force_snat_for_lb option configured for the router > - pipeline will not be applied for this load balancer. > + option, the option lb_force_snat_ip configured for the logical router > + that references this load balancer will not be applied for this load > + balancer. > </column> > > <column name="options" key="add_route"> > -- > 2.30.2 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
On Mon, Jul 12, 2021 at 12:42 PM Numan Siddique <numans@ovn.org> wrote: > > On Fri, Jul 9, 2021 at 2:49 PM Han Zhou <hzhou@ovn.org> wrote: > > > > lb_force_snat_ip is a flag set in logical flow pipeline, while > > lb_force_snat_ip is the option configured in NB DB. In NB document we > > should mention the actual option configured in NB instead of the flow > > details. > > > > Signed-off-by: Han Zhou <hzhou@ovn.org> > > Acked-by: Numan Siddique <numans@ovn.org> > > Numan Thanks Numan! Applied. > > > --- > > ovn-nb.xml | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/ovn-nb.xml b/ovn-nb.xml > > index b6a0d1f43..d5efbb33e 100644 > > --- a/ovn-nb.xml > > +++ b/ovn-nb.xml > > @@ -1712,8 +1712,9 @@ > > > > <column name="options" key="skip_snat"> > > If the load balancing rule is configured with <code>skip_snat</code> > > - option, the force_snat_for_lb option configured for the router > > - pipeline will not be applied for this load balancer. > > + option, the option lb_force_snat_ip configured for the logical router > > + that references this load balancer will not be applied for this load > > + balancer. > > </column> > > > > <column name="options" key="add_route"> > > -- > > 2.30.2 > > > > _______________________________________________ > > dev mailing list > > dev@openvswitch.org > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > >
diff --git a/ovn-nb.xml b/ovn-nb.xml index b6a0d1f43..d5efbb33e 100644 --- a/ovn-nb.xml +++ b/ovn-nb.xml @@ -1712,8 +1712,9 @@ <column name="options" key="skip_snat"> If the load balancing rule is configured with <code>skip_snat</code> - option, the force_snat_for_lb option configured for the router - pipeline will not be applied for this load balancer. + option, the option lb_force_snat_ip configured for the logical router + that references this load balancer will not be applied for this load + balancer. </column> <column name="options" key="add_route">
lb_force_snat_ip is a flag set in logical flow pipeline, while lb_force_snat_ip is the option configured in NB DB. In NB document we should mention the actual option configured in NB instead of the flow details. Signed-off-by: Han Zhou <hzhou@ovn.org> --- ovn-nb.xml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)