| Message ID | 20210506211727.226725-1-blp@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] configure: Report OVS version in the usual Autoconf style. | expand |
On Thu, May 6, 2021 at 2:17 PM Ben Pfaff <blp@ovn.org> wrote: > > Without this patch, configure reports the OVS version like this: > OVS version is $OVSVERSION > > This doesn't match the usual style for messages from configure, so this > patch changes it so that it does, like this: > Checking OVS version... $OVSVERSION > > Signed-off-by: Ben Pfaff <blp@ovn.org> > --- > acinclude.m4 | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/acinclude.m4 b/acinclude.m4 > index 30d108bd9b30..d3fb15a1fa46 100644 > --- a/acinclude.m4 > +++ b/acinclude.m4 > @@ -416,5 +416,6 @@ AC_DEFUN([OVN_CHECK_OVS], [ > AC_SUBST(OVSBUILDDIR) > OVSVERSION=`sed -n 's/^#define PACKAGE_VERSION//p' $OVSBUILDDIR/config.h | tr \\\n ' ' | sed 's/^[ \t]*//;s/[ \t]*$//' | sed 's/\"//g'` > AC_SUBST(OVSVERSION) > - AC_MSG_RESULT([OVS version is $OVSVERSION]) > + AC_MSG_CHECKING([OVS version]) > + AC_MSG_RESULT([$OVSVERSION]) > ]) > -- > 2.31.1 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev Acked-by: Han Zhou <hzhou@ovn.org>
On Thu, May 06, 2021 at 10:48:42PM -0700, Han Zhou wrote: > On Thu, May 6, 2021 at 2:17 PM Ben Pfaff <blp@ovn.org> wrote: > > > > Without this patch, configure reports the OVS version like this: > > OVS version is $OVSVERSION > > > > This doesn't match the usual style for messages from configure, so this > > patch changes it so that it does, like this: > > Checking OVS version... $OVSVERSION > > > > Signed-off-by: Ben Pfaff <blp@ovn.org> > > --- > > acinclude.m4 | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/acinclude.m4 b/acinclude.m4 > > index 30d108bd9b30..d3fb15a1fa46 100644 > > --- a/acinclude.m4 > > +++ b/acinclude.m4 > > @@ -416,5 +416,6 @@ AC_DEFUN([OVN_CHECK_OVS], [ > > AC_SUBST(OVSBUILDDIR) > > OVSVERSION=`sed -n 's/^#define PACKAGE_VERSION//p' > $OVSBUILDDIR/config.h | tr \\\n ' ' | sed 's/^[ \t]*//;s/[ \t]*$//' | sed > 's/\"//g'` > > AC_SUBST(OVSVERSION) > > - AC_MSG_RESULT([OVS version is $OVSVERSION]) > > + AC_MSG_CHECKING([OVS version]) > > + AC_MSG_RESULT([$OVSVERSION]) > > ]) > > -- > > 2.31.1 > > > > _______________________________________________ > > dev mailing list > > dev@openvswitch.org > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > Acked-by: Han Zhou <hzhou@ovn.org> Thanks! I applied to this master.
diff --git a/acinclude.m4 b/acinclude.m4 index 30d108bd9b30..d3fb15a1fa46 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -416,5 +416,6 @@ AC_DEFUN([OVN_CHECK_OVS], [ AC_SUBST(OVSBUILDDIR) OVSVERSION=`sed -n 's/^#define PACKAGE_VERSION//p' $OVSBUILDDIR/config.h | tr \\\n ' ' | sed 's/^[ \t]*//;s/[ \t]*$//' | sed 's/\"//g'` AC_SUBST(OVSVERSION) - AC_MSG_RESULT([OVS version is $OVSVERSION]) + AC_MSG_CHECKING([OVS version]) + AC_MSG_RESULT([$OVSVERSION]) ])
Without this patch, configure reports the OVS version like this: OVS version is $OVSVERSION This doesn't match the usual style for messages from configure, so this patch changes it so that it does, like this: Checking OVS version... $OVSVERSION Signed-off-by: Ben Pfaff <blp@ovn.org> --- acinclude.m4 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)