From patchwork Thu Apr 29 01:55:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Han Zhou X-Patchwork-Id: 1471483 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FVz9y32Wzz9rx6 for ; Thu, 29 Apr 2021 11:56:06 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 5290884667; Thu, 29 Apr 2021 01:56:00 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h5X3oGvwrSlX; Thu, 29 Apr 2021 01:55:59 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTP id A0B37845A9; Thu, 29 Apr 2021 01:55:58 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 716D8C000F; Thu, 29 Apr 2021 01:55:58 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id CFC8DC000D for ; Thu, 29 Apr 2021 01:55:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id B5AAE845DB for ; Thu, 29 Apr 2021 01:55:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kcuxvJO4s4O4 for ; Thu, 29 Apr 2021 01:55:56 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by smtp1.osuosl.org (Postfix) with ESMTPS id D0D90845A9 for ; Thu, 29 Apr 2021 01:55:55 +0000 (UTC) X-Originating-IP: 216.228.112.21 Received: from localhost.localdomain.com (searspoint.nvidia.com [216.228.112.21]) (Authenticated sender: hzhou@ovn.org) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 870D7FF804; Thu, 29 Apr 2021 01:55:51 +0000 (UTC) From: Han Zhou To: dev@openvswitch.org Date: Wed, 28 Apr 2021 18:55:43 -0700 Message-Id: <20210429015543.2265627-1-hzhou@ovn.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Cc: Ilya Maximets Subject: [ovs-dev] [PATCH ovn] Revert "lflow.c: Use warn level log for a lflow that has neither dp nor dpg." X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" This reverts commit 0ba2e1a2e2c413f057ac198e4c2bcf00ac40b19f. System tests with "dp-groups=yes" are all failing due to the warning log. Need to investigate why the warning appears. But before that is clear, revert this log level change to make CI pass. Cc: Ilya Maximets Signed-off-by: Han Zhou Acked-by: Dumitru Ceara --- controller/lflow.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/controller/lflow.c b/controller/lflow.c index b8424e1fb..680b8cca1 100644 --- a/controller/lflow.c +++ b/controller/lflow.c @@ -916,9 +916,8 @@ consider_logical_flow(const struct sbrec_logical_flow *lflow, bool ret = true; if (!dp_group && !dp) { - static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 1); - VLOG_WARN_RL(&rl, "lflow "UUID_FMT" has no datapath binding, skip", - UUID_ARGS(&lflow->header_.uuid)); + VLOG_DBG("lflow "UUID_FMT" has no datapath binding, skip", + UUID_ARGS(&lflow->header_.uuid)); return true; } ovs_assert(!dp_group || !dp);