From patchwork Fri Apr 23 13:08:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dumitru Ceara X-Patchwork-Id: 1469567 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.137; helo=smtp4.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=DbkV4Tbz; dkim-atps=neutral Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FRZPJ6wSlz9sPf for ; Fri, 23 Apr 2021 23:09:06 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 4941C403C3; Fri, 23 Apr 2021 13:09:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UKDThIGvIL4H; Fri, 23 Apr 2021 13:09:03 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTP id 4C88540320; Fri, 23 Apr 2021 13:09:02 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 10CECC000F; Fri, 23 Apr 2021 13:09:02 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 8B73DC000B for ; Fri, 23 Apr 2021 13:09:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 63158400DA for ; Fri, 23 Apr 2021 13:09:01 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LOCSI3kGtWGW for ; Fri, 23 Apr 2021 13:09:00 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp2.osuosl.org (Postfix) with ESMTPS id 2CB69400C1 for ; Fri, 23 Apr 2021 13:09:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619183338; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BSTpNmz33cR9+ICnJZblLHoX9bRXpPoDf6S/aU3RzBc=; b=DbkV4TbzYjieGm6YV545W8r6ZggFGabH6GuhFjZJ5799xj/2GpOvFcOwn+1OHpeuKPz06w aSN84HyKBJ7D04Dzg153EeuDuXEU43+sP2BOV5HCN5Xnl59jMpnBZRp7a7N5G5RRsDw3N5 IQEeLQj5QXTy9tyJNK1VdDnc1wEAxy8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-396-eljZJjZNMiuZ4czfagyuaw-1; Fri, 23 Apr 2021 09:08:56 -0400 X-MC-Unique: eljZJjZNMiuZ4czfagyuaw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C60CE835B4F for ; Fri, 23 Apr 2021 13:08:55 +0000 (UTC) Received: from dceara.remote.csb (ovpn-113-197.ams2.redhat.com [10.36.113.197]) by smtp.corp.redhat.com (Postfix) with ESMTP id E871160BE5 for ; Fri, 23 Apr 2021 13:08:54 +0000 (UTC) From: Dumitru Ceara To: ovs-dev@openvswitch.org Date: Fri, 23 Apr 2021 15:08:50 +0200 Message-Id: <20210423130850.1130-1-dceara@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dceara@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [ovs-dev] [PATCH ovn] checkpatch: Re-enforce line length checks. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" This check was removed by accident, re-add it. Also add a test for it. Fixes: 0e77b3bcbfe2 ("ovn-northd-ddlog: New implementation of ovn-northd based on ddlog.") Signed-off-by: Dumitru Ceara Acked-by: Mark D. Gray --- tests/checkpatch.at | 12 ++++++++++++ utilities/checkpatch.py | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/tests/checkpatch.at b/tests/checkpatch.at index 8f45beac9..0c724d3d6 100755 --- a/tests/checkpatch.at +++ b/tests/checkpatch.at @@ -329,3 +329,15 @@ try_checkpatch \ " AT_CLEANUP + +AT_SETUP([checkpatch - line too long]) +try_checkpatch \ + "COMMON_PATCH_HEADER + +/* This is a very long line.................................................. */ + " \ + "WARNING: Line is 80 characters long (recommended limit is 79) +#8 FILE: A.c:1: +/* This is a very long line.................................................. */ +" + +AT_CLEANUP diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index af7bcfc29..9e8d17653 100755 --- a/utilities/checkpatch.py +++ b/utilities/checkpatch.py @@ -184,7 +184,7 @@ skip_signoff_check = False # # Python isn't checked as flake8 performs these checks during build. line_length_blacklist = re.compile( - r'\.(am|at|etc|in|m4|mk|patch|py|dl)|$|debian/rules') + r'\.(am|at|etc|in|m4|mk|patch|py|dl)$|debian/rules') # Don't enforce a requirement that leading whitespace be all spaces on # files that include these characters in their name, since these kinds