| Message ID | 20210422184421.493431-1-hzhou@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] ovn.at: Improve test case "Port Group". | expand |
On 4/22/21 8:44 PM, Han Zhou wrote: > There are error logs when running this test case: > > 2021-04-21T17:14:35.021Z|00019|lflow|WARN|error parsing match "outport == @pg1 && ip4.src == $pg2_ip4": Syntax error at `@pg1' expecting port group name. > > It is not an issue of the implementation but in fact the inappropriate > ACL added to ls3 in the test case. This patch removes the ACL to avoid > confusion. > > Signed-off-by: Han Zhou <hzhou@ovn.org> > --- Looks good to me, thanks! Acked-by: Dumitru Ceara <dceara@redhat.com>
On Wed, Apr 28, 2021 at 1:09 AM Dumitru Ceara <dceara@redhat.com> wrote: > > On 4/22/21 8:44 PM, Han Zhou wrote: > > There are error logs when running this test case: > > > > 2021-04-21T17:14:35.021Z|00019|lflow|WARN|error parsing match "outport == @pg1 && ip4.src == $pg2_ip4": Syntax error at `@pg1' expecting port group name. > > > > It is not an issue of the implementation but in fact the inappropriate > > ACL added to ls3 in the test case. This patch removes the ACL to avoid > > confusion. > > > > Signed-off-by: Han Zhou <hzhou@ovn.org> > > --- > > Looks good to me, thanks! > > Acked-by: Dumitru Ceara <dceara@redhat.com> > Thanks Dumitru. I applied this to master.
diff --git a/tests/ovn.at b/tests/ovn.at index 3d0a7f63f..0bc7e930e 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -13453,10 +13453,10 @@ done ovn-nbctl create Port_Group name=pg1 ports="$pg1_ports" ovn-nbctl create Port_Group name=pg2 ports="$pg2_ports" -# create ACLs on all lswitches to drop traffic from pg2 to pg1 +# create ACLs on ls1 and ls2 (where ports of pg1 reside) to drop all traffic +# from pg2 to pg1 ovn-nbctl acl-add ls1 to-lport 1001 'outport == @pg1 && ip4.src == $pg2_ip4' drop ovn-nbctl acl-add ls2 to-lport 1001 'outport == @pg1 && ip4.src == $pg2_ip4' drop -ovn-nbctl acl-add ls3 to-lport 1001 'outport == @pg1 && ip4.src == $pg2_ip4' drop # Physical network: #
There are error logs when running this test case: 2021-04-21T17:14:35.021Z|00019|lflow|WARN|error parsing match "outport == @pg1 && ip4.src == $pg2_ip4": Syntax error at `@pg1' expecting port group name. It is not an issue of the implementation but in fact the inappropriate ACL added to ls3 in the test case. This patch removes the ACL to avoid confusion. Signed-off-by: Han Zhou <hzhou@ovn.org> --- tests/ovn.at | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)