diff mbox series

[ovs-dev] documentation: add sudo to install

Message ID 20210405225006.2752169-1-aidan.shribman@gmail.com
State Superseded
Headers show
Series [ovs-dev] documentation: add sudo to install | expand

Commit Message

Aidan Shribman April 5, 2021, 10:50 p.m. UTC 
add documentation of install sequence sudo to support running install
sequence as non-root user

Signed-off-by: hunchback <aidan.shribman@gmail.com>
---
 Documentation/intro/install/general.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Ben Pfaff April 5, 2021, 11:15 p.m. UTC | #1 
On Mon, Apr 05, 2021 at 10:50:07PM +0000, hunchback wrote:
> -       $ mkdir -p /usr/local/etc/ovn
> +       $ sudo mkdir -m 777 -p /usr/local/etc/ovn

Thanks for the patch!

Here and in another case later, it seems like a really bad idea to make
directories world-writable.
Aidan Shribman April 6, 2021, 8:28 a.m. UTC | #2 
agree, see an alternative fix (v2) in which I run the ovsdb-tool and
ovsdb-server under sudo as well

On Tue, Apr 6, 2021 at 12:15 AM Ben Pfaff <blp@ovn.org> wrote:

> On Mon, Apr 05, 2021 at 10:50:07PM +0000, hunchback wrote:
> > -       $ mkdir -p /usr/local/etc/ovn
> > +       $ sudo mkdir -m 777 -p /usr/local/etc/ovn
>
> Thanks for the patch!
>
> Here and in another case later, it seems like a really bad idea to make
> directories world-writable.
>
diff mbox series

Patch

diff --git a/Documentation/intro/install/general.rst b/Documentation/intro/install/general.rst
index 08a03a632..23a7f5149 100644
--- a/Documentation/intro/install/general.rst
+++ b/Documentation/intro/install/general.rst
@@ -371,7 +371,7 @@  Building
 3. Run ``make install`` to install the executables and manpages into the
    running system, by default under ``/usr/local``::
 
-       $ make install
+       $ sudo make install
 
 .. _general-starting:
 
@@ -422,7 +422,7 @@  Before starting ovn-northd you need to start OVN Northbound and Southbound
 ovsdb-servers. Before ovsdb-servers can be started,
 configure the Northbound and Southbound databases::
 
-       $ mkdir -p /usr/local/etc/ovn
+       $ sudo mkdir -m 777 -p /usr/local/etc/ovn
        $ ovsdb-tool create /usr/local/etc/ovn/ovnnb_db.db \
          ovn-nb.ovsschema
        $ ovsdb-tool create /usr/local/etc/ovn/ovnsb_db.db \
@@ -431,7 +431,7 @@  configure the Northbound and Southbound databases::
 Configure ovsdb-servers to use databases created above, to listen on a Unix
 domain socket and to use the SSL configuration in the database::
 
-   $ mkdir -p /usr/local/var/run/ovn
+   $ sudo mkdir -m 777 -p /usr/local/var/run/ovn
    $ ovsdb-server /usr/local/etc/ovn/ovnnb_db.db --remote=punix:/usr/local/var/run/ovn/ovnnb_db.sock \
         --remote=db:OVN_Northbound,NB_Global,connections \
         --private-key=db:OVN_Northbound,SSL,private_key \