From patchwork Thu Mar 4 04:10:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Pfaff X-Patchwork-Id: 1447079 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.133; helo=smtp2.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Drcpw3dcwz9sRf for ; Thu, 4 Mar 2021 15:10:32 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 7AE14431D7; Thu, 4 Mar 2021 04:10:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tPcAxCtRh644; Thu, 4 Mar 2021 04:10:28 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTP id 0C4C0431D6; Thu, 4 Mar 2021 04:10:26 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id E1E61C000D; Thu, 4 Mar 2021 04:10:26 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 28EB8C0001 for ; Thu, 4 Mar 2021 04:10:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 1908842FBF for ; Thu, 4 Mar 2021 04:10:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MKxKdTbmuc5A for ; Thu, 4 Mar 2021 04:10:22 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by smtp2.osuosl.org (Postfix) with ESMTPS id 52CF54017F for ; Thu, 4 Mar 2021 04:10:22 +0000 (UTC) X-Originating-IP: 75.54.222.30 Received: from sigfpe.attlocal.net (75-54-222-30.lightspeed.rdcyca.sbcglobal.net [75.54.222.30]) (Authenticated sender: blp@ovn.org) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id F0C59FF805; Thu, 4 Mar 2021 04:10:19 +0000 (UTC) From: Ben Pfaff To: dev@openvswitch.org Date: Wed, 3 Mar 2021 20:10:03 -0800 Message-Id: <20210304041012.4128938-3-blp@ovn.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210304041012.4128938-1-blp@ovn.org> References: <20210304041012.4128938-1-blp@ovn.org> MIME-Version: 1.0 Cc: Ben Pfaff Subject: [ovs-dev] [PATCH ovn 02/11] ovs-sandbox: Make it possible to disable recording ddlog input. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" The recording is useful for debugging and reproducing runs, but it does cost CPU time, so with this option it can be disabled. Signed-off-by: Ben Pfaff --- tutorial/ovs-sandbox | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tutorial/ovs-sandbox b/tutorial/ovs-sandbox index 21bc594467a0..08a3629be7f6 100755 --- a/tutorial/ovs-sandbox +++ b/tutorial/ovs-sandbox @@ -73,6 +73,7 @@ installed=false built=false ovn=true ddlog=false +ddlog_record=true ovnsb_schema= ovnnb_schema= ic_sb_schema= @@ -145,6 +146,7 @@ General options: OVN options: --ddlog use ovn-northd-ddlog + --no-ddlog-record do not record ddlog transactions (for performance) --no-ovn-rbac disable role-based access control for OVN --n-northds=NUMBER run NUMBER copies of northd (default: 1) --n-ics=NUMBER run NUMBER copies of ic (default: 1) @@ -239,6 +241,9 @@ EOF --ddlog) ddlog=true ;; + --no-ddlog-record | --no-record-ddlog) + ddlog_record=false + ;; --no-ovn-rbac) ovn_rbac=false ;; @@ -624,7 +629,7 @@ fi for i in $(seq $n_northds); do if [ $i -eq 1 ]; then inst=""; else inst=$i; fi - if $ddlog; then + if $ddlog && $ddlog_record; then northd_args=--ddlog-record=replay$inst.txt fi rungdb $gdb_ovn_northd $gdb_ovn_northd_ex $OVN_NORTHD --detach \