[ovs-dev] vtep tests: Fix the failing test - ovn-controller-vtep - binding 1.

From: Numan Siddique <numans@ovn.org>

The below check in the test - "ovn-controller-vtep - binding 1." is
failing after the commit [1].

Before the commit[1], the check was -
  ovn-sbctl --timeout=10 wait-until Port_Binding br-vtep_lswitch0_dup chassis!='[[]]'

And after this commit, the check is -
  check ovn-sbctl wait-until Port_Binding br-vtep_lswitch0_dup chassis!='[[]]'

The test expects 'br-vtep_lswitch0_dup' to be claimed by the chassis,
but there is already a logical port - 'br-vtep_lswitch0' which is
claimed by the same chassis. Both these logical ports are set with the
same options, which means the lport - 'br-vtep_lswitch0_dup' is a
duplicate and it should not be claimed. The test also checks if there is
warning message from ovn-controller-vtep about it.

So looks like the test case was wrong from the beginning itself.  The
"ovn-sbctl --timeout=10 .. " command before the commit [1] was also failing,
but there was no check to fail the test before. But the commit [1] makes the
test fail because its wrapped with 'check' helper function.

This patch removes this wrong test check.

[1] - 5fedcce6c3e0("tests: Remove explicit timeouts from most utility invocations.")
Signed-off-by: Numan Siddique <numans@ovn.org>
---
 tests/ovn-controller-vtep.at | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

On Mon, Nov 30, 2020 at 2:37 PM <numans@ovn.org> wrote:
>
> From: Numan Siddique <numans@ovn.org>
>
> The below check in the test - "ovn-controller-vtep - binding 1." is
> failing after the commit [1].
>
> Before the commit[1], the check was -
>   ovn-sbctl --timeout=10 wait-until Port_Binding br-vtep_lswitch0_dup chassis!='[[]]'
>
> And after this commit, the check is -
>   check ovn-sbctl wait-until Port_Binding br-vtep_lswitch0_dup chassis!='[[]]'
>
> The test expects 'br-vtep_lswitch0_dup' to be claimed by the chassis,
> but there is already a logical port - 'br-vtep_lswitch0' which is
> claimed by the same chassis. Both these logical ports are set with the
> same options, which means the lport - 'br-vtep_lswitch0_dup' is a
> duplicate and it should not be claimed. The test also checks if there is
> warning message from ovn-controller-vtep about it.
>
> So looks like the test case was wrong from the beginning itself.  The
> "ovn-sbctl --timeout=10 .. " command before the commit [1] was also failing,
> but there was no check to fail the test before. But the commit [1] makes the
> test fail because its wrapped with 'check' helper function.
>
> This patch removes this wrong test check.
>
> [1] - 5fedcce6c3e0("tests: Remove explicit timeouts from most utility invocations.")
> Signed-off-by: Numan Siddique <numans@ovn.org>

Please ignore this patch. I will submit v2 with an updated commit
message and add a
proper check rather than removing the test check.

Thanks
Numan

> ---
>  tests/ovn-controller-vtep.at | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/ovn-controller-vtep.at b/tests/ovn-controller-vtep.at
> index 8b4c180b16..d109cfdb40 100644
> --- a/tests/ovn-controller-vtep.at
> +++ b/tests/ovn-controller-vtep.at
> @@ -203,7 +203,7 @@ ${chassis_uuid}
>
>  # adds another logical switch port in ovn-nb database for lswitch0.
>  OVN_NB_ADD_VTEP_PORT([br-test], [br-vtep_lswitch0_dup], [br-vtep], [lswitch0])
> -check ovn-sbctl wait-until Port_Binding br-vtep_lswitch0_dup chassis!='[[]]'
> +
>  # it is not allowed to have more than one ovn-nb logical port for the same
>  # vtep logical switch on a vtep gateway chassis, so should still see only
>  # two port_binding entries bound.
> --
> 2.28.0
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>