diff mbox series

[ovs-dev,14/14] ovn-nbctl: Fix leak of array of new policies.

Message ID 20201120001724.2424494-15-i.maximets@ovn.org
State Accepted
Headers show
Series Pack of fixes for memory leaks. | expand

Commit Message

Ilya Maximets Nov. 20, 2020, 12:17 a.m. UTC
CC: Tao YunXiang <taoyunxiang@cmss.chinamobile.com>
Fixes: 5820502a5507 ("ovn-nbctl.c: Fix lr-policy-del command")
Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
---
 utilities/ovn-nbctl.c | 1 +
 1 file changed, 1 insertion(+)

Comments

taoyunxiang Nov. 20, 2020, 2:41 a.m. UTC | #1
LGTM.


--------------
taoyunxiang@cmss.chinamobile.com
>CC: Tao YunXiang <taoyunxiang@cmss.chinamobile.com>
>Fixes: 5820502a5507 ("ovn-nbctl.c: Fix lr-policy-del command")
>Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
>---
> utilities/ovn-nbctl.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/utilities/ovn-nbctl.c b/utilities/ovn-nbctl.c
>index 448c86f42..fa1522152 100644
>--- a/utilities/ovn-nbctl.c
>+++ b/utilities/ovn-nbctl.c
>@@ -3758,6 +3758,7 @@ nbctl_lr_policy_del(struct ctl_context *ctx)
>                 if (!shash_find(&ctx->options, "--if-exists")) {
>                     ctl_error(ctx, "Logical router policy uuid is not found.");
>                 }
>+                free(new_policies);
>                 return;
>             }
>
>--
>2.25.4
>
diff mbox series

Patch

diff --git a/utilities/ovn-nbctl.c b/utilities/ovn-nbctl.c
index 448c86f42..fa1522152 100644
--- a/utilities/ovn-nbctl.c
+++ b/utilities/ovn-nbctl.c
@@ -3758,6 +3758,7 @@  nbctl_lr_policy_del(struct ctl_context *ctx)
                 if (!shash_find(&ctx->options, "--if-exists")) {
                     ctl_error(ctx, "Logical router policy uuid is not found.");
                 }
+                free(new_policies);
                 return;
             }