diff mbox series

[ovs-dev,11/14] ovn-nbctl: Fix leak of IPs while configuring NAT.

Message ID 20201120001724.2424494-12-i.maximets@ovn.org
State Accepted
Headers show
Series Pack of fixes for memory leaks. | expand

Commit Message

Ilya Maximets Nov. 20, 2020, 12:17 a.m. UTC 
CC: Ankur Sharma <ankur.sharma@nutanix.com>
Fixes: 20bc58a67f39 ("External IP based NAT: Add Columns and CLI")
Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
---
 utilities/ovn-nbctl.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Ankur Sharma Nov. 20, 2020, 9:23 p.m. UTC | #1 
Acked-by: Ankur Sharma <ankur.sharma@nutanix.com>

Regards,
Ankur
diff mbox series

Patch

diff --git a/utilities/ovn-nbctl.c b/utilities/ovn-nbctl.c
index fb6766839..89537edf0 100644
--- a/utilities/ovn-nbctl.c
+++ b/utilities/ovn-nbctl.c
@@ -4601,8 +4601,11 @@  nbctl_lr_nat_set_ext_ips(struct ctl_context *ctx)
             } else {
                 nbrec_nat_set_allowed_ext_ips(nat, addr_set);
             }
+            free(nat_ip);
+            free(old_ip);
             return;
         }
+        free(old_ip);
     }
 
     if (!nat_found) {