From patchwork Fri Oct 30 00:24:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Pfaff X-Patchwork-Id: 1390528 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.136; helo=silver.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ovn.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CMjkX4Csqz9sSn for ; Fri, 30 Oct 2020 11:25:08 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id BCC46229D4; Fri, 30 Oct 2020 00:25:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uiNETuOOKuxL; Fri, 30 Oct 2020 00:25:01 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 4E4582047C; Fri, 30 Oct 2020 00:25:01 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 178D8C0859; Fri, 30 Oct 2020 00:25:01 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id BCBD6C0051 for ; Fri, 30 Oct 2020 00:24:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id B028E2046E for ; Fri, 30 Oct 2020 00:24:59 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sG4NNN-S5te8 for ; Fri, 30 Oct 2020 00:24:58 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by silver.osuosl.org (Postfix) with ESMTPS id 5F41220354 for ; Fri, 30 Oct 2020 00:24:58 +0000 (UTC) X-Originating-IP: 75.54.222.30 Received: from sigfpe.attlocal.net (75-54-222-30.lightspeed.rdcyca.sbcglobal.net [75.54.222.30]) (Authenticated sender: blp@ovn.org) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id CF5E540002; Fri, 30 Oct 2020 00:24:52 +0000 (UTC) From: Ben Pfaff To: dev@openvswitch.org Date: Thu, 29 Oct 2020 17:24:32 -0700 Message-Id: <20201030002447.936548-1-blp@ovn.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Cc: Ben Pfaff Subject: [ovs-dev] [PATCH ovn 01/16] tests: Drop support for glibc before version 2.11. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" The "ldd" call here didn't work if libtool was involved and would print an error message. We could fix that, but the check is only needed for glibc earlier than 2.11. glibc 2.11 was released in 2009, so it should be safe to expect that testers are running it or a newer version. Signed-off-by: Ben Pfaff Acked-by: Numan Siddique --- tests/atlocal.in | 18 +----------------- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/tests/atlocal.in b/tests/atlocal.in index 26681f02d851..4517ebf72fab 100644 --- a/tests/atlocal.in +++ b/tests/atlocal.in @@ -46,23 +46,7 @@ esac case `uname` in Linux) MALLOC_PERTURB_=165; export MALLOC_PERTURB_ - - # Before glibc 2.11, the feature enabled by MALLOC_CHECK_ was not - # thread-safe. See https://bugzilla.redhat.com/show_bug.cgi?id=585674 and - # in particular the patch attached there, which was applied to glibc CVS as - # "Restore locking in free_check." between 1.11 and 1.11.1. - binary=$abs_top_builddir/controller/ovn-controller - glibc=`ldd $binary | sed -n 's/^ libc\.[^ ]* => \([^ ]*\) .*/\1/p'` - glibc_version=`$glibc | sed -n '1s/.*version \([0-9]\{1,\}\.[0-9]\{1,\}\).*/\1/p'` - case $glibc_version in - 2.[0-9] | 2.1[01]) mcheck=disabled ;; - *) mcheck=enabled ;; - esac - if test $mcheck = enabled; then - MALLOC_CHECK_=2; export MALLOC_CHECK_ - else - echo >&2 "glibc $glibc_version detected, disabling memory checking" - fi + MALLOC_CHECK_=2; export MALLOC_CHECK_ ;; FreeBSD) case `uname -r` in