diff mbox series

[ovs-dev,4/7] northd: Don't redundantly set Port_Binding options.

Message ID 20201026181626.1827014-4-blp@ovn.org
State Accepted
Headers show
Series [ovs-dev,1/7] northd: Count mask length and priority correctly for IPv6 addresses. | expand

Commit Message

Ben Pfaff Oct. 26, 2020, 6:16 p.m. UTC
This is called twice within a few lines of code.

Signed-off-by: Ben Pfaff <blp@ovn.org>
---
 northd/ovn-northd.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Numan Siddique Oct. 27, 2020, 3:39 p.m. UTC | #1
On Mon, Oct 26, 2020 at 11:47 PM Ben Pfaff <blp@ovn.org> wrote:
>
> This is called twice within a few lines of code.
>
> Signed-off-by: Ben Pfaff <blp@ovn.org>

Acked-by: Numan Siddique <numans@ovn.org>

Thanks
Numan

> ---
>  northd/ovn-northd.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c
> index e69845fbb219..f25f5cd82f39 100644
> --- a/northd/ovn-northd.c
> +++ b/northd/ovn-northd.c
> @@ -10223,7 +10223,6 @@ build_ND_RA_flows_for_lrouter_port(
>      }
>      smap_add(&options, "ipv6_prefix_delegation",
>               prefix_delegation ? "true" : "false");
> -    sbrec_port_binding_set_options(op->sb, &options);
>
>      bool ipv6_prefix = smap_get_bool(&op->nbrp->options,
>                                       "prefix", false);
> --
> 2.26.2
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
diff mbox series

Patch

diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c
index e69845fbb219..f25f5cd82f39 100644
--- a/northd/ovn-northd.c
+++ b/northd/ovn-northd.c
@@ -10223,7 +10223,6 @@  build_ND_RA_flows_for_lrouter_port(
     }
     smap_add(&options, "ipv6_prefix_delegation",
              prefix_delegation ? "true" : "false");
-    sbrec_port_binding_set_options(op->sb, &options);
 
     bool ipv6_prefix = smap_get_bool(&op->nbrp->options,
                                      "prefix", false);