| Message ID | 20201020113804.1247701-1-numans@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] Use the correct command name in ovn-nbctl --help | expand |
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Numan Siddique <numans@ovn.org> WARNING: Line lacks whitespace around operator #40 FILE: utilities/ovn-nbctl.c:771: ha-chassis-group-remove-chassis GRP CHASSIS Removes the HA chassis\ Lines checked: 46, Warnings: 2, Errors: 0 Please check this out. If you feel there has been an error, please email aconole@redhat.com Thanks, 0-day Robot
On Tue, Oct 20, 2020 at 5:08 PM <numans@ovn.org> wrote: > > From: Kai Li <likailichee@gmail.com> > Thanks Kai Li for the PR. I applied this patch to master and closed the PR. Numan > Command to remove the chassis from a ha chassis group is > "ha-chassis-group-remove-chassis". Use the correct function name in > "ovn-nbctl --help". > > Reported-at: https://github.com/ovn-org/ovn/issues/58 > Submitted-at: https://github.com/ovn-org/ovn/pull/59 > Signed-off-by: Kai Li <likailichee@gmail.com> > Signed-off-by: Numan Siddique <numans@ovn.org> > --- > AUTHORS.rst | 1 + > utilities/ovn-nbctl.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/AUTHORS.rst b/AUTHORS.rst > index 862407c81..b6c22b131 100644 > --- a/AUTHORS.rst > +++ b/AUTHORS.rst > @@ -202,6 +202,7 @@ Jun Nakajima jun.nakajima@intel.com > JunhanYan juyan@redhat.com > JunoZhu zhunatuzi@gmail.com > Justin Pettit jpettit@ovn.org > +Kai Li likailichee@gmail.com > Kaige Fu fukaige@huawei.com > Keith Amidon > Ken Ajiro ajiro@mxw.nes.nec.co.jp > diff --git a/utilities/ovn-nbctl.c b/utilities/ovn-nbctl.c > index caf99dfeb..abc674f4a 100644 > --- a/utilities/ovn-nbctl.c > +++ b/utilities/ovn-nbctl.c > @@ -768,7 +768,7 @@ HA chassis group commands:\n\ > ha-chassis-group-list List the HA chassis groups\n\ > ha-chassis-group-add-chassis GRP CHASSIS [PRIORITY] Adds an HA\ > chassis with optional PRIORITY to the HA chassis group GRP\n\ > - ha-chassis-group-del-chassis GRP CHASSIS Deletes the HA chassis\ > + ha-chassis-group-remove-chassis GRP CHASSIS Removes the HA chassis\ > CHASSIS from the HA chassis group GRP\n\ > \n\ > %s\ > -- > 2.26.2 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
diff --git a/AUTHORS.rst b/AUTHORS.rst index 862407c81..b6c22b131 100644 --- a/AUTHORS.rst +++ b/AUTHORS.rst @@ -202,6 +202,7 @@ Jun Nakajima jun.nakajima@intel.com JunhanYan juyan@redhat.com JunoZhu zhunatuzi@gmail.com Justin Pettit jpettit@ovn.org +Kai Li likailichee@gmail.com Kaige Fu fukaige@huawei.com Keith Amidon Ken Ajiro ajiro@mxw.nes.nec.co.jp diff --git a/utilities/ovn-nbctl.c b/utilities/ovn-nbctl.c index caf99dfeb..abc674f4a 100644 --- a/utilities/ovn-nbctl.c +++ b/utilities/ovn-nbctl.c @@ -768,7 +768,7 @@ HA chassis group commands:\n\ ha-chassis-group-list List the HA chassis groups\n\ ha-chassis-group-add-chassis GRP CHASSIS [PRIORITY] Adds an HA\ chassis with optional PRIORITY to the HA chassis group GRP\n\ - ha-chassis-group-del-chassis GRP CHASSIS Deletes the HA chassis\ + ha-chassis-group-remove-chassis GRP CHASSIS Removes the HA chassis\ CHASSIS from the HA chassis group GRP\n\ \n\ %s\