| Message ID | 1bf91b95e3cbe3ecbcf332725aba89a971cdd997.1716218408.git.lorenzo.bianconi@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] ovn-nbctl: Show bfd option man for lr-policy-add command. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/github-robot-_ovn-kubernetes | fail | github build: failed |
On Mon, May 20, 2024 at 5:22 PM Lorenzo Bianconi < lorenzo.bianconi@redhat.com> wrote: > Add missing bfd option in ovn-nbctl manual for lr-policy-add command > > Fixes: 62d5491c0155 ("northd: Add BFD support for ECMP route policy.") > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com> > --- > utilities/ovn-nbctl.8.xml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/utilities/ovn-nbctl.8.xml b/utilities/ovn-nbctl.8.xml > index ea2b201a5..340312b38 100644 > --- a/utilities/ovn-nbctl.8.xml > +++ b/utilities/ovn-nbctl.8.xml > @@ -1095,7 +1095,8 @@ > <h2>Logical Router Policy Commands</h2> > > <dl> > - <dt>[<code>--may-exist</code>]<code>lr-policy-add</code> > + <dt>[<code>--may-exist</code>] [<code>--bfd</code>] > + <code>lr-policy-add</code> > <var>router</var> <var>priority</var> <var>match</var> > <var>action</var> [<var>nexthop</var>[,<var>nexthop</var>,...]] > [<var>options key=value]</var>] </dt> > -- > 2.45.1 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > Looks good to me, thanks. Acked-by: Ales Musil <amusil@redhat.com>
Thanks Lorenzo and Ales, I pushed this to main and branch-24.03. I also added the following: Reported-at: https://issues.redhat.com/browse/FDP-550 On 5/22/24 03:49, Ales Musil wrote: > On Mon, May 20, 2024 at 5:22 PM Lorenzo Bianconi < > lorenzo.bianconi@redhat.com> wrote: > >> Add missing bfd option in ovn-nbctl manual for lr-policy-add command >> >> Fixes: 62d5491c0155 ("northd: Add BFD support for ECMP route policy.") >> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com> >> --- >> utilities/ovn-nbctl.8.xml | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/utilities/ovn-nbctl.8.xml b/utilities/ovn-nbctl.8.xml >> index ea2b201a5..340312b38 100644 >> --- a/utilities/ovn-nbctl.8.xml >> +++ b/utilities/ovn-nbctl.8.xml >> @@ -1095,7 +1095,8 @@ >> <h2>Logical Router Policy Commands</h2> >> >> <dl> >> - <dt>[<code>--may-exist</code>]<code>lr-policy-add</code> >> + <dt>[<code>--may-exist</code>] [<code>--bfd</code>] >> + <code>lr-policy-add</code> >> <var>router</var> <var>priority</var> <var>match</var> >> <var>action</var> [<var>nexthop</var>[,<var>nexthop</var>,...]] >> [<var>options key=value]</var>] </dt> >> -- >> 2.45.1 >> >> _______________________________________________ >> dev mailing list >> dev@openvswitch.org >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >> >> > Looks good to me, thanks. > > Acked-by: Ales Musil <amusil@redhat.com>
diff --git a/utilities/ovn-nbctl.8.xml b/utilities/ovn-nbctl.8.xml index ea2b201a5..340312b38 100644 --- a/utilities/ovn-nbctl.8.xml +++ b/utilities/ovn-nbctl.8.xml @@ -1095,7 +1095,8 @@ <h2>Logical Router Policy Commands</h2> <dl> - <dt>[<code>--may-exist</code>]<code>lr-policy-add</code> + <dt>[<code>--may-exist</code>] [<code>--bfd</code>] + <code>lr-policy-add</code> <var>router</var> <var>priority</var> <var>match</var> <var>action</var> [<var>nexthop</var>[,<var>nexthop</var>,...]] [<var>options key=value]</var>] </dt>
Add missing bfd option in ovn-nbctl manual for lr-policy-add command Fixes: 62d5491c0155 ("northd: Add BFD support for ECMP route policy.") Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com> --- utilities/ovn-nbctl.8.xml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)