| Message ID | 167155026080.1303384.3721672215096962293.stgit@dceara.remote.csb |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Fix ovn-kubernetes CI jobs on stable branches. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | warning | apply and check: warning |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/github-robot-_ovn-kubernetes | success | github build: passed |
Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line has non-spaces leading whitespace WARNING: Line has trailing whitespace #43 FILE: .ci/ovn-kubernetes/custom.patch:22: WARNING: Line has non-spaces leading whitespace WARNING: Line has trailing whitespace #49 FILE: .ci/ovn-kubernetes/custom.patch:28: WARNING: Line has trailing whitespace #50 FILE: .ci/ovn-kubernetes/custom.patch:29:
On Tue, Dec 20, 2022 at 4:31 PM Dumitru Ceara <dceara@redhat.com> wrote: > The OVN feature used to implement session affinity timeout doesn't exist > on this branch. ovn-kubernetes code already moved to implementing the > feature by using the newer OVN option so, in order to keep testing as > many features as possible in CI, we now disable all session affinity > tests (but keep executing the rest). > > Signed-off-by: Dumitru Ceara <dceara@redhat.com> > --- > NOTE: This commit should only be applied to branches <= branch-22.09. > --- > .ci/ovn-kubernetes/custom.patch | 31 +++++++++++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > > diff --git a/.ci/ovn-kubernetes/custom.patch > b/.ci/ovn-kubernetes/custom.patch > index e69de29bb2..ea5dd75408 100644 > --- a/.ci/ovn-kubernetes/custom.patch > +++ b/.ci/ovn-kubernetes/custom.patch > @@ -0,0 +1,31 @@ > +From 903eef2dd6f9fec818a580760f4757d8137b9974 Mon Sep 17 00:00:00 2001 > +From: Dumitru Ceara <dceara@redhat.com> > +Date: Mon, 19 Dec 2022 12:18:55 +0100 > +Subject: [PATCH] DOWNSTREAM: Disable session affinity tests. > + > +Commit https://github.com/ovn-org/ovn-kubernetes/commit/898d2f8f10c4 > +enabled affinity timeout tests but the underlying OVN feature is > +not supported in this branch. Disable affinity tests. > + > +Signed-off-by: Dumitru Ceara <dceara@redhat.com> > +--- > + test/scripts/e2e-kind.sh | 3 +++ > + 1 file changed, 3 insertions(+) > + > +diff --git a/test/scripts/e2e-kind.sh b/test/scripts/e2e-kind.sh > +index 69959fa1b..c3b2a5c3e 100755 > +--- a/test/scripts/e2e-kind.sh > ++++ b/test/scripts/e2e-kind.sh > +@@ -26,6 +26,9 @@ kube-proxy > + should set TCP CLOSE_WAIT timeout > + \[Feature:ProxyTerminatingEndpoints\] > + > ++# Disable session affinity tests completely. > ++session affinity > ++ > + # NOT IMPLEMENTED; SEE DISCUSSION IN > https://github.com/ovn-org/ovn-kubernetes/pull/1225 > + named port.+\[Feature:NetworkPolicy\] > + > +-- > +2.31.1 > + > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > Looks good to me, thanks. Acked-by: Ales Musil <amusil@redhat.com>
diff --git a/.ci/ovn-kubernetes/custom.patch b/.ci/ovn-kubernetes/custom.patch index e69de29bb2..ea5dd75408 100644 --- a/.ci/ovn-kubernetes/custom.patch +++ b/.ci/ovn-kubernetes/custom.patch @@ -0,0 +1,31 @@ +From 903eef2dd6f9fec818a580760f4757d8137b9974 Mon Sep 17 00:00:00 2001 +From: Dumitru Ceara <dceara@redhat.com> +Date: Mon, 19 Dec 2022 12:18:55 +0100 +Subject: [PATCH] DOWNSTREAM: Disable session affinity tests. + +Commit https://github.com/ovn-org/ovn-kubernetes/commit/898d2f8f10c4 +enabled affinity timeout tests but the underlying OVN feature is +not supported in this branch. Disable affinity tests. + +Signed-off-by: Dumitru Ceara <dceara@redhat.com> +--- + test/scripts/e2e-kind.sh | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/test/scripts/e2e-kind.sh b/test/scripts/e2e-kind.sh +index 69959fa1b..c3b2a5c3e 100755 +--- a/test/scripts/e2e-kind.sh ++++ b/test/scripts/e2e-kind.sh +@@ -26,6 +26,9 @@ kube-proxy + should set TCP CLOSE_WAIT timeout + \[Feature:ProxyTerminatingEndpoints\] + ++# Disable session affinity tests completely. ++session affinity ++ + # NOT IMPLEMENTED; SEE DISCUSSION IN https://github.com/ovn-org/ovn-kubernetes/pull/1225 + named port.+\[Feature:NetworkPolicy\] + +-- +2.31.1 +
The OVN feature used to implement session affinity timeout doesn't exist on this branch. ovn-kubernetes code already moved to implementing the feature by using the newer OVN option so, in order to keep testing as many features as possible in CI, we now disable all session affinity tests (but keep executing the rest). Signed-off-by: Dumitru Ceara <dceara@redhat.com> --- NOTE: This commit should only be applied to branches <= branch-22.09. --- .ci/ovn-kubernetes/custom.patch | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+)