From patchwork Tue Sep 1 19:20:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dumitru Ceara X-Patchwork-Id: 1355330 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=PGdd4hij; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bgxjg58vSz9sTg for ; Wed, 2 Sep 2020 05:20:21 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id E6B66865AB; Tue, 1 Sep 2020 19:20:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fC3X9MnOxhoC; Tue, 1 Sep 2020 19:20:19 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id 3882B84595; Tue, 1 Sep 2020 19:20:19 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1861FC07FF; Tue, 1 Sep 2020 19:20:19 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 55C24C0051 for ; Tue, 1 Sep 2020 19:20:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 4479086C73 for ; Tue, 1 Sep 2020 19:20:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gQ-N1R8tul1j for ; Tue, 1 Sep 2020 19:20:15 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by whitealder.osuosl.org (Postfix) with ESMTPS id 5B2EB8678B for ; Tue, 1 Sep 2020 19:20:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598988013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type; bh=sJUB5ecyxO/Qp9ehl+MAjOTSbm4J9qw19B5lG7j9/KM=; b=PGdd4hijKzEj7J4DCGyQbmOD6+Y9juxF8TQB9Zk6qoptn65EFPFBJcJ0mjL9CP/D7kzMkH PFMr7UOMAgVFki7V0kuwJMnbA1BY2PoyRPzzAEszkBbglOaqO9k1AlsmS/aODWQ4dpK/0a eEOCQ/qxSf2fbgEcLIcoqZ1+8z0yJOg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-539-KxehKp1FO_mVD93zpxKd_Q-1; Tue, 01 Sep 2020 15:20:10 -0400 X-MC-Unique: KxehKp1FO_mVD93zpxKd_Q-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DDD7618B9EC0; Tue, 1 Sep 2020 19:20:08 +0000 (UTC) Received: from dceara.remote.csb (ovpn-113-81.ams2.redhat.com [10.36.113.81]) by smtp.corp.redhat.com (Postfix) with ESMTP id 423275C1BB; Tue, 1 Sep 2020 19:20:08 +0000 (UTC) From: Dumitru Ceara To: dev@openvswitch.org Date: Tue, 1 Sep 2020 21:20:04 +0200 Message-Id: <1598988004-2216-1-git-send-email-dceara@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dceara@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Cc: Han Zhou Subject: [ovs-dev] [PATCH ovn] ovn-northd: Rate limit missing chassis log. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" This log does indicate a problem so it's useful to log it at WARN level but there's not much use to spam at every iteration of ovn-northd. CC: Han Zhou Fixes: 4adc10f58127 ("Avoid nb_cfg update notification flooding") Signed-off-by: Dumitru Ceara --- northd/ovn-northd.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index f2e3104..7be0e85 100644 --- a/northd/ovn-northd.c +++ b/northd/ovn-northd.c @@ -12265,8 +12265,10 @@ update_northbound_cfg(struct northd_context *ctx, continue; } } else { - VLOG_WARN("Chassis not exist for Chassis_Private record, " - "name: %s", chassis_priv->name); + static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 1); + VLOG_WARN_RL(&rl, "Chassis does not exist for " + "Chassis_Private record, name: %s", + chassis_priv->name); } if (chassis_priv->nb_cfg < hv_cfg) {