| Message ID | 1361e1a4d631ed1c6b27e9afc80fa7b10f03344a.1680258943.git.lorenzo.bianconi@redhat.com |
|---|---|
| State | RFC |
| Headers | show |
| Series | rework OVN QoS implementation | expand |
On Fri, Mar 31, 2023 at 6:41 AM Lorenzo Bianconi <lorenzo.bianconi@redhat.com> wrote: > > Similar to qos_max_rate and qos_burst, take into account qos_min_rate in > port_has_qos_params routine. > > Fixes: 8dda482b80 ("Check and allocate free qdisc queue id for ports with qos parameters") This should point to dbf12e5fe1f7ab2acef4152854c239b999b70188 that introduced support for min-rate. > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com> > --- > northd/northd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/northd/northd.c b/northd/northd.c > index 7a10e4dcf..57ec10956 100644 > --- a/northd/northd.c > +++ b/northd/northd.c > @@ -559,7 +559,7 @@ free_chassis_queueid(struct hmap *set, const struct uuid *uuid, > static inline bool > port_has_qos_params(const struct smap *opts) > { > - return (smap_get(opts, "qos_max_rate") || > + return (smap_get(opts, "qos_max_rate") || smap_get(opts, "qos_min_rate") || > smap_get(opts, "qos_burst")); > } > > -- > 2.39.2 >
diff --git a/northd/northd.c b/northd/northd.c index 7a10e4dcf..57ec10956 100644 --- a/northd/northd.c +++ b/northd/northd.c @@ -559,7 +559,7 @@ free_chassis_queueid(struct hmap *set, const struct uuid *uuid, static inline bool port_has_qos_params(const struct smap *opts) { - return (smap_get(opts, "qos_max_rate") || + return (smap_get(opts, "qos_max_rate") || smap_get(opts, "qos_min_rate") || smap_get(opts, "qos_burst")); }
Similar to qos_max_rate and qos_burst, take into account qos_min_rate in port_has_qos_params routine. Fixes: 8dda482b80 ("Check and allocate free qdisc queue id for ports with qos parameters") Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com> --- northd/northd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)