From patchwork Thu Feb 8 18:17:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ales Musil X-Patchwork-Id: 1896708 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=WcNkmoEE; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.138; helo=smtp1.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TW4vy3mlPz23h2 for ; Fri, 9 Feb 2024 05:17:34 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 45BDA851D2; Thu, 8 Feb 2024 18:17:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3wSu0-sYpwcS; Thu, 8 Feb 2024 18:17:30 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.9.56; helo=lists.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org D1A0284E63 Authentication-Results: smtp1.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=WcNkmoEE Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id D1A0284E63; Thu, 8 Feb 2024 18:17:29 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 7BF22C0072; Thu, 8 Feb 2024 18:17:29 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id D13A6C0037 for ; Thu, 8 Feb 2024 18:17:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id BE2784CF79 for ; Thu, 8 Feb 2024 18:17:26 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id seHzBB4kYmuw for ; Thu, 8 Feb 2024 18:17:26 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=170.10.133.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=amusil@redhat.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org D353F4B4F3 Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=none dis=none) header.from=redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org D353F4B4F3 Authentication-Results: smtp4.osuosl.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=WcNkmoEE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp4.osuosl.org (Postfix) with ESMTPS id D353F4B4F3 for ; Thu, 8 Feb 2024 18:17:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707416244; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=NvwS6vpUy4vyyTgmkd4z2cTj0YrciaFCOiiTt/yP4NE=; b=WcNkmoEEhECGfiCkQzBtIYFwLnhX3v8eFQFGyjipmZihWxXSvntR9jZ/4xD8HEFpcA1bBQ wPf48SjZsAknNSHlNHDvC69JnO84spjI+LWA7xspBypAnlLe0l9+/ruC/jioYMU+FZMoFf DBwsiZ8AhNKJEKO/mC7CsNal3yZFngk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-548--rCxdLpRMy6yUMTYlVFO1w-1; Thu, 08 Feb 2024 13:17:21 -0500 X-MC-Unique: -rCxdLpRMy6yUMTYlVFO1w-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EC55A830DD2 for ; Thu, 8 Feb 2024 18:17:20 +0000 (UTC) Received: from amusil.redhat.com (unknown [10.45.224.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 36B651C02E2C; Thu, 8 Feb 2024 18:17:20 +0000 (UTC) From: Ales Musil To: dev@openvswitch.org Date: Thu, 8 Feb 2024 19:17:15 +0100 Message-ID: <20240208181719.224501-1-amusil@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [ovs-dev] [PATCH ovn v3 0/4] Remove most of the hardcoded table numbers X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" This series has the remaing patches that weren't yet accepted with addition that fixes table numbers in comments. A lot of tests were relying on exact table numbers for flow comparison either logical or OpenFlows. In order to take care of table references into OpenFlow through logical flow stage, new binary is added called ovn-debug. The new binary provides command that will translate stage name into OpenFlow table number. Only test that is still hardcoded is "action parsing", because it compares the direct output from the test binary. Ales Musil (4): tests: Remove hardcoded numbers from comments checkpatch: Add rule to check for hardcoded table numbers. utilities: Add ovn-debug binary tool. tests: Use the ovn-debug binary to determine table numbers. NEWS | 5 + README.rst | 1 + debian/ovn-common.install | 1 + debian/ovn-common.manpages | 1 + rhel/ovn-fedora.spec.in | 2 + tests/ovn-controller.at | 342 ++++++++++++++++++-------------- tests/ovn-northd.at | 2 +- tests/ovn.at | 397 +++++++++++++++++++++---------------- tests/system-ovn-kmod.at | 16 +- tests/system-ovn.at | 20 +- utilities/.gitignore | 2 + utilities/automake.mk | 10 +- utilities/checkpatch.py | 12 ++ utilities/ovn-debug.8.xml | 28 +++ utilities/ovn-debug.c | 155 +++++++++++++++ 15 files changed, 659 insertions(+), 335 deletions(-) create mode 100644 utilities/ovn-debug.8.xml create mode 100644 utilities/ovn-debug.c