mbox series

[ovs-dev,0/3] m4: Fix autoconf 2.70+ warnings.

Message ID 20230816222627.3873712-1-i.maximets@ovn.org
Headers show
Series m4: Fix autoconf 2.70+ warnings. | expand

Message

Ilya Maximets Aug. 16, 2023, 10:26 p.m. UTC 
autoconf 2.70+ complais about these obsolete macros.
Replacements are available in our baseline 2.63, so
use them instead.

It also complains about AC_PROG_CC_C99, but I'm not
sure if we want to or how to correctly replace it.
Suggested AC_PROG_CC enables C11 by default and that
might not be a desired behavior.

This patch set is similar to what I did for OVS about
a year ago.

Ilya Maximets (3):
  m4: Replace obsolete AC_HELP_STRING with AS_HELP_STRING.
  m4: Replace obsolete AC_ERROR with AC_MSG_ERROR.
  m4: Update ax_func_posix_memalign to the latest version.

 acinclude.m4                 | 23 +++++++++++++----------
 m4/ax_func_posix_memalign.m4 |  8 ++++----
 m4/ovn.m4                    | 16 ++++++++--------
 3 files changed, 25 insertions(+), 22 deletions(-)

Comments

Ales Musil Aug. 17, 2023, 9:31 a.m. UTC | #1 
On Thu, Aug 17, 2023 at 12:26 AM Ilya Maximets <i.maximets@ovn.org> wrote:

> autoconf 2.70+ complais about these obsolete macros.
> Replacements are available in our baseline 2.63, so
> use them instead.
>
> It also complains about AC_PROG_CC_C99, but I'm not
> sure if we want to or how to correctly replace it.
> Suggested AC_PROG_CC enables C11 by default and that
> might not be a desired behavior.
>
> This patch set is similar to what I did for OVS about
> a year ago.
>
> Ilya Maximets (3):
>   m4: Replace obsolete AC_HELP_STRING with AS_HELP_STRING.
>   m4: Replace obsolete AC_ERROR with AC_MSG_ERROR.
>   m4: Update ax_func_posix_memalign to the latest version.
>
>  acinclude.m4                 | 23 +++++++++++++----------
>  m4/ax_func_posix_memalign.m4 |  8 ++++----
>  m4/ovn.m4                    | 16 ++++++++--------
>  3 files changed, 25 insertions(+), 22 deletions(-)
>
> --
> 2.40.1
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>
The whole series looks good to me, thanks.

Acked-by: Ales Musil <amusil@redhat.com>
Dumitru Ceara Aug. 17, 2023, 10:59 a.m. UTC | #2 
On 8/17/23 11:31, Ales Musil wrote:
> On Thu, Aug 17, 2023 at 12:26 AM Ilya Maximets <i.maximets@ovn.org> wrote:
> 
>> autoconf 2.70+ complais about these obsolete macros.
>> Replacements are available in our baseline 2.63, so
>> use them instead.
>>
>> It also complains about AC_PROG_CC_C99, but I'm not
>> sure if we want to or how to correctly replace it.
>> Suggested AC_PROG_CC enables C11 by default and that
>> might not be a desired behavior.
>>
>> This patch set is similar to what I did for OVS about
>> a year ago.
>>
>> Ilya Maximets (3):
>>   m4: Replace obsolete AC_HELP_STRING with AS_HELP_STRING.
>>   m4: Replace obsolete AC_ERROR with AC_MSG_ERROR.
>>   m4: Update ax_func_posix_memalign to the latest version.
>>
>>  acinclude.m4                 | 23 +++++++++++++----------
>>  m4/ax_func_posix_memalign.m4 |  8 ++++----
>>  m4/ovn.m4                    | 16 ++++++++--------
>>  3 files changed, 25 insertions(+), 22 deletions(-)
>>
>> --
>> 2.40.1
>>
>> _______________________________________________
>> dev mailing list
>> dev@openvswitch.org
>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>>
>>
> The whole series looks good to me, thanks.
> 
> Acked-by: Ales Musil <amusil@redhat.com>
> 

Ah, I apologize, Ales, I just pushed the series and missed adding your
ack.  Thanks for reviewing it though and thanks, Ilya, for the patches!

Regards,
Dumitru