| Message ID | 20221202135137.1728564-1-xsimonar@redhat.com |
|---|---|
| Headers | show |
| Series | Fixes to multiple Unit and System Tests | expand |
On Fri, Dec 2, 2022 at 2:51 PM Xavier Simonart <xsimonar@redhat.com> wrote: > Xavier Simonart (12): > tests: Fixed flaky system tests "ACL reject" and "ACL after lb - > reject" > tests: Fixed flaky system-test ACL log_related > tests: Fixed system-test "load balancing affinity sessions" > tests: Fixed load balancing system-tests > tests: Fixed typo in macros > tests: Fixed flaky system-test "ECMP symmetric reply" > tests: Fixed flaky ACL fair Meters > tests: Fixed typo in "incremetal processing" test > tests: Removed macro reset_iface_pcap_file > tests: Fixed some tests failing on (very) slow systems > tests: Fixed "vtep: 3 HVs, 1 VIFs/HV, 1 GW, 1 LS" > tests: Fixed "IPv6 periodic RA" and "snat-ct-zone with common NAT > zone" > > tests/atlocal.in | 3 + > tests/network-functions.at | 18 +- > tests/ovn-macros.at | 21 -- > tests/ovn-northd.at | 7 +- > tests/ovn-performance.at | 2 +- > tests/ovn.at | 54 ++-- > tests/system-common-macros.at | 2 +- > tests/system-kmod-macros.at | 1 - > tests/system-ovn.at | 456 +++++++++++++++++++--------------- > 9 files changed, 317 insertions(+), 247 deletions(-) > > -- > 2.31.1 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > Whole series looks good to me, thanks! Acked-by: Ales Musil <amusil@redhat.com>
Hi Xavier. I did a review of this series. For patches 1, 2, 3, 5, 6, 8, 9, 11, and 12: Acked-by: Mark Michelson <mmichels@redhat.com> For patches 4, 7, and 10 I have some comments. On 12/2/22 08:51, Xavier Simonart wrote: > Xavier Simonart (12): > tests: Fixed flaky system tests "ACL reject" and "ACL after lb - > reject" > tests: Fixed flaky system-test ACL log_related > tests: Fixed system-test "load balancing affinity sessions" > tests: Fixed load balancing system-tests > tests: Fixed typo in macros > tests: Fixed flaky system-test "ECMP symmetric reply" > tests: Fixed flaky ACL fair Meters > tests: Fixed typo in "incremetal processing" test > tests: Removed macro reset_iface_pcap_file > tests: Fixed some tests failing on (very) slow systems > tests: Fixed "vtep: 3 HVs, 1 VIFs/HV, 1 GW, 1 LS" > tests: Fixed "IPv6 periodic RA" and "snat-ct-zone with common NAT > zone" > > tests/atlocal.in | 3 + > tests/network-functions.at | 18 +- > tests/ovn-macros.at | 21 -- > tests/ovn-northd.at | 7 +- > tests/ovn-performance.at | 2 +- > tests/ovn.at | 54 ++-- > tests/system-common-macros.at | 2 +- > tests/system-kmod-macros.at | 1 - > tests/system-ovn.at | 456 +++++++++++++++++++--------------- > 9 files changed, 317 insertions(+), 247 deletions(-) >
Hi Mark, Ales Thanks for your review and feedback. I'll send v2 for patch 4 and 7, and comments on patch 10. Thanks Xavier On Mon, Dec 12, 2022 at 10:33 PM Mark Michelson <mmichels@redhat.com> wrote: > Hi Xavier. I did a review of this series. > > For patches 1, 2, 3, 5, 6, 8, 9, 11, and 12: > > Acked-by: Mark Michelson <mmichels@redhat.com> > > For patches 4, 7, and 10 I have some comments. > > On 12/2/22 08:51, Xavier Simonart wrote: > > Xavier Simonart (12): > > tests: Fixed flaky system tests "ACL reject" and "ACL after lb - > > reject" > > tests: Fixed flaky system-test ACL log_related > > tests: Fixed system-test "load balancing affinity sessions" > > tests: Fixed load balancing system-tests > > tests: Fixed typo in macros > > tests: Fixed flaky system-test "ECMP symmetric reply" > > tests: Fixed flaky ACL fair Meters > > tests: Fixed typo in "incremetal processing" test > > tests: Removed macro reset_iface_pcap_file > > tests: Fixed some tests failing on (very) slow systems > > tests: Fixed "vtep: 3 HVs, 1 VIFs/HV, 1 GW, 1 LS" > > tests: Fixed "IPv6 periodic RA" and "snat-ct-zone with common NAT > > zone" > > > > tests/atlocal.in | 3 + > > tests/network-functions.at | 18 +- > > tests/ovn-macros.at | 21 -- > > tests/ovn-northd.at | 7 +- > > tests/ovn-performance.at | 2 +- > > tests/ovn.at | 54 ++-- > > tests/system-common-macros.at | 2 +- > > tests/system-kmod-macros.at | 1 - > > tests/system-ovn.at | 456 +++++++++++++++++++--------------- > > 9 files changed, 317 insertions(+), 247 deletions(-) > > > >
On Tue, Dec 13, 2022 at 10:07 AM Xavier Simonart <xsimonar@redhat.com> wrote: > > Hi Mark, Ales > > Thanks for your review and feedback. > I'll send v2 for patch 4 and 7, and comments on patch 10. > > Thanks > Xavier > > On Mon, Dec 12, 2022 at 10:33 PM Mark Michelson <mmichels@redhat.com> wrote: > > > Hi Xavier. I did a review of this series. > > > > For patches 1, 2, 3, 5, 6, 8, 9, 11, and 12: > > > > Acked-by: Mark Michelson <mmichels@redhat.com> Thanks. I applied the patches - 1, 2, 3, 5, 6, 8, 9, 11, and 12 to the main branch. Numan > > > > For patches 4, 7, and 10 I have some comments. > > > > On 12/2/22 08:51, Xavier Simonart wrote: > > > Xavier Simonart (12): > > > tests: Fixed flaky system tests "ACL reject" and "ACL after lb - > > > reject" > > > tests: Fixed flaky system-test ACL log_related > > > tests: Fixed system-test "load balancing affinity sessions" > > > tests: Fixed load balancing system-tests > > > tests: Fixed typo in macros > > > tests: Fixed flaky system-test "ECMP symmetric reply" > > > tests: Fixed flaky ACL fair Meters > > > tests: Fixed typo in "incremetal processing" test > > > tests: Removed macro reset_iface_pcap_file > > > tests: Fixed some tests failing on (very) slow systems > > > tests: Fixed "vtep: 3 HVs, 1 VIFs/HV, 1 GW, 1 LS" > > > tests: Fixed "IPv6 periodic RA" and "snat-ct-zone with common NAT > > > zone" > > > > > > tests/atlocal.in | 3 + > > > tests/network-functions.at | 18 +- > > > tests/ovn-macros.at | 21 -- > > > tests/ovn-northd.at | 7 +- > > > tests/ovn-performance.at | 2 +- > > > tests/ovn.at | 54 ++-- > > > tests/system-common-macros.at | 2 +- > > > tests/system-kmod-macros.at | 1 - > > > tests/system-ovn.at | 456 +++++++++++++++++++--------------- > > > 9 files changed, 317 insertions(+), 247 deletions(-) > > > > > > > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
Xavier Simonart (12): tests: Fixed flaky system tests "ACL reject" and "ACL after lb - reject" tests: Fixed flaky system-test ACL log_related tests: Fixed system-test "load balancing affinity sessions" tests: Fixed load balancing system-tests tests: Fixed typo in macros tests: Fixed flaky system-test "ECMP symmetric reply" tests: Fixed flaky ACL fair Meters tests: Fixed typo in "incremetal processing" test tests: Removed macro reset_iface_pcap_file tests: Fixed some tests failing on (very) slow systems tests: Fixed "vtep: 3 HVs, 1 VIFs/HV, 1 GW, 1 LS" tests: Fixed "IPv6 periodic RA" and "snat-ct-zone with common NAT zone" tests/atlocal.in | 3 + tests/network-functions.at | 18 +- tests/ovn-macros.at | 21 -- tests/ovn-northd.at | 7 +- tests/ovn-performance.at | 2 +- tests/ovn.at | 54 ++-- tests/system-common-macros.at | 2 +- tests/system-kmod-macros.at | 1 - tests/system-ovn.at | 456 +++++++++++++++++++--------------- 9 files changed, 317 insertions(+), 247 deletions(-)