mbox series

[ovs-dev,branch-21.12,0/6] Use ct_mark for masked access to make flows HW-offloading friendly.

Message ID 20220523193838.9544.70716.stgit@dceara.remote.csb
Headers show
Series Use ct_mark for masked access to make flows HW-offloading friendly. | expand

Message

Dumitru Ceara May 23, 2022, 7:38 p.m. UTC
This is a series to explicitly backport a075230e4a0f ("Use ct_mark for
masked access to make flows HW-offloading friendly.") and its
dependencies to branch-21.12.

The conflicts were minimal, mainly due to the lack of the "ACL
log-related" feature on branch-21.12.

Han Zhou (6):
      ovn-sb.xml: Fix ct_lb documentation.
      actions: Add action ct_lb_mark.
      actions: Add stack push and pop actions.
      ovn-northd: Improve the doc and tests for ecmp-symmetric-reply.
      ovn-controller: Handle SB_Global:options:northd_internal_version in I-P engine.
      Use ct_mark for masked access to make flows HW-offloading friendly.

 NEWS                         |    2 
 controller/lflow.c           |   33 ++-
 controller/lflow.h           |    1 
 controller/ovn-controller.c  |   79 +++++++
 include/ovn/actions.h        |   11 +
 include/ovn/logical-fields.h |    3 
 lib/actions.c                |  128 ++++++++++-
 lib/logical-fields.c         |   17 +
 lib/ovn-util.c               |   25 ++
 lib/ovn-util.h               |    4 
 northd/northd.c              |   97 +++++----
 northd/ovn-northd.8.xml      |   59 +++--
 ovn-sb.xml                   |   54 ++++-
 tests/ovn-controller.at      |   48 ++++
 tests/ovn-northd.at          |  478 +++++++++++++++++++++---------------------
 tests/ovn.at                 |  208 ++++++++++--------
 tests/system-ovn.at          |  178 ++++++++--------
 utilities/ovn-trace.c        |   72 ++++++
 18 files changed, 987 insertions(+), 510 deletions(-)

Comments

Han Zhou May 24, 2022, 4:56 p.m. UTC | #1
On Mon, May 23, 2022 at 12:38 PM Dumitru Ceara <dceara@redhat.com> wrote:
>
> This is a series to explicitly backport a075230e4a0f ("Use ct_mark for
> masked access to make flows HW-offloading friendly.") and its
> dependencies to branch-21.12.
>
> The conflicts were minimal, mainly due to the lack of the "ACL
> log-related" feature on branch-21.12.
>

Thanks Dumitru for backporting!
I pushed the series to branch-21.12, with the minor changes discussed for
patch (5), as well as an extra note in the commit message of patch (6) for
the log-related related part:

(note: this paragraph can be ignored because "log-related" is not in this
branch yet when this patch is backported here)

Thanks,
Han

> Han Zhou (6):
>       ovn-sb.xml: Fix ct_lb documentation.
>       actions: Add action ct_lb_mark.
>       actions: Add stack push and pop actions.
>       ovn-northd: Improve the doc and tests for ecmp-symmetric-reply.
>       ovn-controller: Handle SB_Global:options:northd_internal_version in
I-P engine.
>       Use ct_mark for masked access to make flows HW-offloading friendly.
>
>  NEWS                         |    2
>  controller/lflow.c           |   33 ++-
>  controller/lflow.h           |    1
>  controller/ovn-controller.c  |   79 +++++++
>  include/ovn/actions.h        |   11 +
>  include/ovn/logical-fields.h |    3
>  lib/actions.c                |  128 ++++++++++-
>  lib/logical-fields.c         |   17 +
>  lib/ovn-util.c               |   25 ++
>  lib/ovn-util.h               |    4
>  northd/northd.c              |   97 +++++----
>  northd/ovn-northd.8.xml      |   59 +++--
>  ovn-sb.xml                   |   54 ++++-
>  tests/ovn-controller.at      |   48 ++++
>  tests/ovn-northd.at          |  478
+++++++++++++++++++++---------------------
>  tests/ovn.at                 |  208 ++++++++++--------
>  tests/system-ovn.at          |  178 ++++++++--------
>  utilities/ovn-trace.c        |   72 ++++++
>  18 files changed, 987 insertions(+), 510 deletions(-)
>
Dumitru Ceara May 24, 2022, 5:49 p.m. UTC | #2
On 5/24/22 18:56, Han Zhou wrote:
> On Mon, May 23, 2022 at 12:38 PM Dumitru Ceara <dceara@redhat.com> wrote:
>>
>> This is a series to explicitly backport a075230e4a0f ("Use ct_mark for
>> masked access to make flows HW-offloading friendly.") and its
>> dependencies to branch-21.12.
>>
>> The conflicts were minimal, mainly due to the lack of the "ACL
>> log-related" feature on branch-21.12.
>>
> 
> Thanks Dumitru for backporting!
> I pushed the series to branch-21.12, with the minor changes discussed for
> patch (5), as well as an extra note in the commit message of patch (6) for
> the log-related related part:
> 
> (note: this paragraph can be ignored because "log-related" is not in this
> branch yet when this patch is backported here)
> 
> Thanks,
> Han
> 

Thanks!
Dumitru Ceara June 1, 2022, 2:39 p.m. UTC | #3
On 5/24/22 19:49, Dumitru Ceara wrote:
> On 5/24/22 18:56, Han Zhou wrote:
>> On Mon, May 23, 2022 at 12:38 PM Dumitru Ceara <dceara@redhat.com> wrote:
>>>
>>> This is a series to explicitly backport a075230e4a0f ("Use ct_mark for
>>> masked access to make flows HW-offloading friendly.") and its
>>> dependencies to branch-21.12.
>>>
>>> The conflicts were minimal, mainly due to the lack of the "ACL
>>> log-related" feature on branch-21.12.
>>>
>>
>> Thanks Dumitru for backporting!
>> I pushed the series to branch-21.12, with the minor changes discussed for
>> patch (5), as well as an extra note in the commit message of patch (6) for
>> the log-related related part:
>>
>> (note: this paragraph can be ignored because "log-related" is not in this
>> branch yet when this patch is backported here)
>>
>> Thanks,
>> Han
>>
> 
> Thanks!

Hi Han,

It seems that backporting this caused an issue for RHEV (Red Hat
Virtualization).  I just posted a patch to allow us to use the feature
on older, stable, branches.

https://patchwork.ozlabs.org/project/ovn/list/?series=302899&state=*

Regards,
Dumitru