From patchwork Thu Jun 10 12:47:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dumitru Ceara X-Patchwork-Id: 1490493 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=SHF6OE0u; dkim-atps=neutral Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4G13fH3nvJz9sRK for ; Thu, 10 Jun 2021 22:47:35 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id DA0B882DFC; Thu, 10 Jun 2021 12:47:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H3tHfi4rDjsI; Thu, 10 Jun 2021 12:47:32 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTPS id 45FC7826C1; Thu, 10 Jun 2021 12:47:31 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1398AC000E; Thu, 10 Jun 2021 12:47:31 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id BDEE6C000B for ; Thu, 10 Jun 2021 12:47:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id B99F160664 for ; Thu, 10 Jun 2021 12:47:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QmAXbakskAlY for ; Thu, 10 Jun 2021 12:47:28 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by smtp3.osuosl.org (Postfix) with ESMTPS id 806E560645 for ; Thu, 10 Jun 2021 12:47:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623329247; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=J6wsnyrk9ZSopBibV2g4w3MEhxlW0Ip26jOZeKNTE1k=; b=SHF6OE0upy5euj/h4DhwtBk54MmEON8qSgc08VwHo+AcHHARK0U85/58s0DzMTHliImNWK BoTrPVaUVxTZnFRCqcSCuaUvOXoEwZoJpGvTpP9vXC2PLj4tPJkfv1C3lLb7lOnjBc+yK3 gPnGcRpmfPR01oOQvMzeRc/x/28YZ+8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-15-nGXjFGHVP7mC6ey_caVJ5g-1; Thu, 10 Jun 2021 08:47:24 -0400 X-MC-Unique: nGXjFGHVP7mC6ey_caVJ5g-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 387709F92A; Thu, 10 Jun 2021 12:47:23 +0000 (UTC) Received: from dceara.remote.csb (ovpn-112-150.ams2.redhat.com [10.36.112.150]) by smtp.corp.redhat.com (Postfix) with ESMTP id 05B0E19801; Thu, 10 Jun 2021 12:47:21 +0000 (UTC) From: Dumitru Ceara To: ovs-dev@openvswitch.org Date: Thu, 10 Jun 2021 14:47:17 +0200 Message-Id: <20210610124705.30043.13200.stgit@dceara.remote.csb> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dceara@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Cc: dceara@redhat.com Subject: [ovs-dev] [PATCH v2 ovn 0/3] Optimize load balancer IP config parsing. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" This is a new version of the single-patch v1 previously posted at: http://patchwork.ozlabs.org/project/ovn/patch/20210601170320.30490-1-dceara@redhat.com/ V2: - Turned this into a series. - Added patch 1/3 that removes some unused fields in ovn-northd load balancer structures, saving a tiny amount of CPU. - Added patch 2/3 that consolidates load balancer healthcheck/svc config parsing, allowing further optimization in 3/3. - Patch 3/3 is the original v1 patch with the added part that now we parse load balancer IP sets only once, per load balancer, instead of once for each datapath + load_balancer. This improves processing times by an additional ~5%. Dumitru Ceara (3): lb: Remove hairpin_snat_ips from northd load balancers. northd: Consolidate load balancer healthcheck/svc code. northd: Precompute load balancer IP sets. lib/lb.c | 49 ++------ lib/lb.h | 12 +- northd/ovn-northd.c | 316 +++++++++++++++++++++++++++------------------------ 3 files changed, 181 insertions(+), 196 deletions(-) Acked-by: Mark Michelson