mbox series

[ovs-dev,v2,0/3] Optimize load balancer IP config parsing.

Message ID 20210610124705.30043.13200.stgit@dceara.remote.csb
Headers show
Series Optimize load balancer IP config parsing. | expand

Message

Dumitru Ceara June 10, 2021, 12:47 p.m. UTC
This is a new version of the single-patch v1 previously posted at:
http://patchwork.ozlabs.org/project/ovn/patch/20210601170320.30490-1-dceara@redhat.com/

V2:
- Turned this into a series.
- Added patch 1/3 that removes some unused fields in ovn-northd load
  balancer structures, saving a tiny amount of CPU.
- Added patch 2/3 that consolidates load balancer healthcheck/svc
  config parsing, allowing further optimization in 3/3.
- Patch 3/3 is the original v1 patch with the added part that now we
  parse load balancer IP sets only once, per load balancer, instead of
  once for each datapath + load_balancer.  This improves processing
  times by an additional ~5%.

Dumitru Ceara (3):
      lb: Remove hairpin_snat_ips from northd load balancers.
      northd: Consolidate load balancer healthcheck/svc code.
      northd: Precompute load balancer IP sets.

 lib/lb.c            |   49 ++------
 lib/lb.h            |   12 +-
 northd/ovn-northd.c |  316 +++++++++++++++++++++++++++------------------------
 3 files changed, 181 insertions(+), 196 deletions(-)

Comments

Mark Michelson June 11, 2021, 5:31 p.m. UTC | #1
Acked-by: Mark Michelson <mmichels@redhat.com>

On 6/10/21 8:47 AM, Dumitru Ceara wrote:
> This is a new version of the single-patch v1 previously posted at:
> http://patchwork.ozlabs.org/project/ovn/patch/20210601170320.30490-1-dceara@redhat.com/
> 
> V2:
> - Turned this into a series.
> - Added patch 1/3 that removes some unused fields in ovn-northd load
>    balancer structures, saving a tiny amount of CPU.
> - Added patch 2/3 that consolidates load balancer healthcheck/svc
>    config parsing, allowing further optimization in 3/3.
> - Patch 3/3 is the original v1 patch with the added part that now we
>    parse load balancer IP sets only once, per load balancer, instead of
>    once for each datapath + load_balancer.  This improves processing
>    times by an additional ~5%.
> 
> Dumitru Ceara (3):
>        lb: Remove hairpin_snat_ips from northd load balancers.
>        northd: Consolidate load balancer healthcheck/svc code.
>        northd: Precompute load balancer IP sets.
> 
>   lib/lb.c            |   49 ++------
>   lib/lb.h            |   12 +-
>   northd/ovn-northd.c |  316 +++++++++++++++++++++++++++------------------------
>   3 files changed, 181 insertions(+), 196 deletions(-)
>