| Message ID | 169167146062.2447623.4263905982665736274.stgit@dceara.remote.csb |
|---|---|
| Headers | show |
| Series | Add port group incremental processing in northd. | expand |
Hi Dumitru, I had a look through the series, and it looks good to me. Acked-by: Mark Michelson <mmichels@redhat.com> On 8/10/23 08:44, Dumitru Ceara wrote: > This series cleans up, factors out and then adds incremental processing > support to the code that processes port group updates in ovn-northd. > > Some performance results are shared in the commit message of the last > patch in this series. > > Dumitru Ceara (5): > ovn-util: Factor out struct sorted_addresses into sorted_array. > northd: Merge port group related structures. > northd: Move port group processing to its separate module. > northd: Move port group processing to its own I-P node. > northd: Add incremental processing for NB port groups. > > > lib/stopwatch-names.h | 1 + > northd/automake.mk | 2 + > northd/en-lflow.c | 21 +- > northd/en-lflow.h | 1 + > northd/en-northd.c | 4 - > northd/en-port-group.c | 636 +++++++++++++++++++++++++++++++++++++++ > northd/en-port-group.h | 114 +++++++ > northd/inc-proc-northd.c | 22 +- > northd/northd.c | 317 +++++-------------- > northd/northd.h | 12 +- > northd/ovn-northd.c | 4 + > tests/ovn-northd.at | 254 +++++++++++++++- > 12 files changed, 1118 insertions(+), 270 deletions(-) > create mode 100644 northd/en-port-group.c > create mode 100644 northd/en-port-group.h >
On 8/17/23 21:42, Mark Michelson wrote: > Hi Dumitru, > > I had a look through the series, and it looks good to me. > > Acked-by: Mark Michelson <mmichels@redhat.com> > Thanks, Ales, Mark and Han, for the reviews! I addressed Han's comment on patch 1/5 and then I pushed the first 4 patches to the main branch. I'll post a v2 of the last patch soon. Regards, Dumitru
On 8/30/23 13:03, Dumitru Ceara wrote: > On 8/17/23 21:42, Mark Michelson wrote: >> Hi Dumitru, >> >> I had a look through the series, and it looks good to me. >> >> Acked-by: Mark Michelson <mmichels@redhat.com> >> > > Thanks, Ales, Mark and Han, for the reviews! > > I addressed Han's comment on patch 1/5 and then I pushed the first 4 > patches to the main branch. > > I'll post a v2 of the last patch soon. > V2 posted: https://patchwork.ozlabs.org/project/ovn/patch/20230830135015.353207-1-dceara@redhat.com/ Thanks, Dumitru
This series cleans up, factors out and then adds incremental processing support to the code that processes port group updates in ovn-northd. Some performance results are shared in the commit message of the last patch in this series. Dumitru Ceara (5): ovn-util: Factor out struct sorted_addresses into sorted_array. northd: Merge port group related structures. northd: Move port group processing to its separate module. northd: Move port group processing to its own I-P node. northd: Add incremental processing for NB port groups. lib/stopwatch-names.h | 1 + northd/automake.mk | 2 + northd/en-lflow.c | 21 +- northd/en-lflow.h | 1 + northd/en-northd.c | 4 - northd/en-port-group.c | 636 +++++++++++++++++++++++++++++++++++++++ northd/en-port-group.h | 114 +++++++ northd/inc-proc-northd.c | 22 +- northd/northd.c | 317 +++++-------------- northd/northd.h | 12 +- northd/ovn-northd.c | 4 + tests/ovn-northd.at | 254 +++++++++++++++- 12 files changed, 1118 insertions(+), 270 deletions(-) create mode 100644 northd/en-port-group.c create mode 100644 northd/en-port-group.h