From patchwork Thu Dec 31 23:00:05 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vittorio Gambaletta X-Patchwork-Id: 561993 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from arrakis.dune.hu (arrakis.dune.hu [78.24.191.176]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40911140BF7 for ; Fri, 1 Jan 2016 10:03:54 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (4096-bit key; unprotected) header.d=vittgam.net header.i=@vittgam.net header.b=Sy4j42rH; dkim-atps=neutral Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id D601A28BFE4; Fri, 1 Jan 2016 00:00:20 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on arrakis.dune.hu X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id 671672807A8 for ; Thu, 31 Dec 2015 23:59:46 +0100 (CET) X-policyd-weight: using cached result; rate:hard: -7.6 Received: from mail.vittgam.net (server1.vittgam.net [213.239.197.142]) by arrakis.dune.hu (Postfix) with ESMTPS for ; Thu, 31 Dec 2015 23:59:39 +0100 (CET) X-DKIM: OpenDKIM Filter v2.4.2 mail.vittgam.net tBVN00oo082907 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=vittgam.net; s=20150519; t=1451602804; bh=TYpkCsTHIr+ZOulGWwRidIt3rSTKFheYvVZfICpFl4k=; h=From:To:Date:Subject:Content-Type:Message-ID:In-Reply-To: References; b=Sy4j42rHp5Retc9wLhLwoolCt0DWleRqhSA81M0hmbw8kmaA+G3JVKBlndHxypfep EvOxZezNaeg2b/K2LLMYfZa3GxHCmWHN2t9EfRQln3RKMBVOaUsbv7TnxJbh/tm1y8 lNN1XmdRyFhZuIruMOqNp6LhDuBq4U1v3Utj7pSfLzq2TExN6SHM+tIDf4n0QIj+P2 kKZwiTe+OkLhtjXn09ESKf2O39e1ZV5rj7a+h2GH3T4iezFiIuKaYG91N5JJAn2yXu tdhjTf+5Ub7YiVB8KcuGaL6bbuI5EZAgNQZgG+wYmYE8pARX+KatrOefUBSFkUWYCq zE1a30G5daDqjRvZozUCBGJHDCoKsc26/9TXlAi6rlpnhrpfinlIfKJC1VyIafDRKs HoqIb57fSNTf8rpTvO27TXXyNqbAi60YjfN14yjs8bhRjPV+SWJMO6upGFBuI0L+Zp Wbj90ZHrt0DFKxadt1xqgcmjlh2LFa0Fb7rZCDykeaK7wBEFWolOJorSxNynt1FYQY bv5QohAWAx6uTwkS+L7TlZIokUIhXsvkvNQ0y8V4bajSAdPrcpQyzyp6EJtyppdECr TE9Y8rFWg6z2OXgKoYtio4/qDgQap+IjDrcOdmrvU0VBu3ld7XogOGdKXXzr99sNnS 0b83t/hHto/eGuR7Nk+dYgjA= Received: from vl2 (vittgamlaptop2.r1.network.mietitrebbia.rocks [10.48.3.146]) by mail.vittgam.net with SMTP id tBVN00oo082907; Fri, 1 Jan 2016 00:00:03 +0100 From: "Vittorio G (VittGam)" To: Date: Fri, 01 Jan 2016 00:00:05 +0100 Message-ID: In-Reply-To: References: Subject: [OpenWrt-Devel] [PATCH v4 2/4] [CC] ramips: Fix comment in rt3052 ethernet switch driver. X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: openwrt-devel-bounces@lists.openwrt.org Sender: "openwrt-devel" Line 461 is actually enabling all switch ports by setting the disable bits to 0. This needs to be done because the bootloader sets all ports to disabled by default (which is the case for at least one router based on RT5350). So, this patch fixes the comment in line 460. Signed-off-by: Vittorio Gambaletta --- a/target/linux/ramips/files/drivers/net/ethernet/ralink/esw_rt3052.c +++ b/target/linux/ramips/files/drivers/net/ethernet/ralink/esw_rt3052.c @@ -457,7 +457,7 @@ static void esw_hw_init(struct rt305x_esw *esw) (RT305X_ESW_PORTS_ALL << RT305X_ESW_PFC1_EN_VLAN_S), RT305X_ESW_REG_PFC1); - /* Enable Back Pressure, and Flow Control */ + /* Enable all ports, Back Pressure and Flow Control */ esw_w32(esw, ((RT305X_ESW_PORTS_ALL << RT305X_ESW_POC0_EN_BP_S) | (RT305X_ESW_PORTS_ALL << RT305X_ESW_POC0_EN_FC_S)),