| Message ID | owrt-patch-20151216-6@vittgam.net |
|---|---|
| State | Not Applicable |
| Headers | show |
Am 16.12.2015 um 05:42 schrieb Vittorio G (VittGam): > Signed-off-by: Vittorio Gambaletta <openwrt@vittgam.net> > > --- > > --- a/target/linux/lantiq/base-files/etc/board.d/01_leds > +++ b/target/linux/lantiq/base-files/etc/board.d/01_leds > @@ -38,6 +38,10 @@ BTHOMEHUBV5A) > ucidef_set_led_netdev "internet" "internet" "soc:blue:broadband" "pppoa-wan" > ucidef_set_led_default "dimmed" "dimmed" "dimmed" "0" > ;; > +TDW8970|TDW8980) > + ucidef_set_led_wlan "wifi" "wifi" "ath9k-phy0" "phy0tpt" > + ucidef_set_led_netdev "internet" "internet" "internet" "pppoe-wan" > + ;; > VGV7510KW22) > ucidef_set_led_default "power" "power" "power" "1" > ucidef_set_led_default "power2" "power2" "power2" "0" > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel > This look unnecessary to me. The default internet led configuration a few lines above, already adds an internet led with exactly the same values. The same applies to the wifi led. I can not yet explain why, but the ath9k-phy0 led has the phy0tpt trigger configured without having the wifi led defined in 01_led on my TDW8980.
On 16 December 2015 23:13:16 CET, Mathias Kresin <openwrt@kresin.me> wrote: >This look unnecessary to me. > >The default internet led configuration a few lines above, already adds >an internet led with exactly the same values. > >The same applies to the wifi led. I can not yet explain why, but the >ath9k-phy0 led has the phy0tpt trigger configured without having the >wifi led defined in 01_led on my TDW8980. Uh, okay. Actually I've just resurrected my old CC trunk patches from some months ago (I forgot to send them to the list before, sorry about that...), adapted them for current trunk and sent them to the ml, so maybe trunk takes care of it already.
--- a/target/linux/lantiq/base-files/etc/board.d/01_leds +++ b/target/linux/lantiq/base-files/etc/board.d/01_leds @@ -38,6 +38,10 @@ BTHOMEHUBV5A) ucidef_set_led_netdev "internet" "internet" "soc:blue:broadband" "pppoa-wan" ucidef_set_led_default "dimmed" "dimmed" "dimmed" "0" ;; +TDW8970|TDW8980) + ucidef_set_led_wlan "wifi" "wifi" "ath9k-phy0" "phy0tpt" + ucidef_set_led_netdev "internet" "internet" "internet" "pppoe-wan" + ;; VGV7510KW22) ucidef_set_led_default "power" "power" "power" "1" ucidef_set_led_default "power2" "power2" "power2" "0"
Signed-off-by: Vittorio Gambaletta <openwrt@vittgam.net> ---