From patchwork Fri Jul 9 14:35:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Ivanov X-Patchwork-Id: 1503199 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=wBii5ykp; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GLwkg5Qfdz9sWS for ; Sat, 10 Jul 2021 00:38:19 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:List-Help: Reply-To:List-Archive:List-Unsubscribe:List-Subscribe:From:List-Post:List-Id: Message-ID:MIME-Version:Date:Subject:To:Cc:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=kU1vu48AwrRY7znEFpXrp4Y5HkCy9i5X3nMe512mz/s=; b=wBii5ykprWS0bKfvWJVqt+/1+v CH41xnZhbDoVXB4ehZDDzcu1+sF5MlCXWauQbsOmswMkspNh9ettZiSRGaGokcWPQkTse/RH0Jyci FDlJTbGgY6f4ttvWPUdOZMEOO7mZZnUVaz+FmjJtiXmFdre/qQUX2z/gCI0Mqe1UIWCJng62D4luv kt1GKkdqDAmeJluh3/5+I8P+e2je3HXosAJ8ap88OicfDwzFnJVoBoG7Z9rWDW19XKkNuCJgpudAF xnHiIAYY9bsWo782eWp7saIz09ylk+McjUYcIcgqfZn8yvRDL98jMmiwea6IqCIkeNB7UiB2HKbUx jDwQJHuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1rbY-001wkB-G0; Fri, 09 Jul 2021 14:35:48 +0000 To: openwrt-devel@lists.openwrt.org Subject: [PATCH] relayd: don't break localhost Date: Fri, 09 Jul 2021 17:35:30 +0300 MIME-Version: 1.0 Message-ID: List-Id: OpenWrt Development List List-Post: X-Patchwork-Original-From: Dmitry Ivanov via openwrt-devel From: Dmitry Ivanov Precedence: list X-Mailman-Version: 2.1.34 X-BeenThere: openwrt-devel@lists.openwrt.org List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: Dmitry Ivanov List-Help: Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software. Relayd is adding default route to its routing tables when it's found in DHCP response. Adding default route to routing table associated with loopback interface makes no sense other than breaking localhost so that DNS requests to local dnsmasq and even "ping 127.0.0.1" go to default gateway. This patch prevents insertion of default route into "localhost" policy routing table created by relayd. Signed-off-by: Dmitry Ivanov --- route.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/route.c b/route.c index c552d1f..f7cf815 100644 --- a/route.c +++ b/route.c @@ -243,7 +243,7 @@ rtnl_route_set(struct relayd_host *host, struct relayd_route *route, bool add) rtnl_route_request(rif, host, route, add); } - if (local_route_table) + if (local_route_table && route && route->mask) rtnl_route_request(NULL, host, route, add); }