[buildbot] docker,worker: install g++-multilib

The sender domain has a DMARC Reject/Quarantine policy which disallows
sending mailing list messages using the original "From" header.

To mitigate this problem, the original message has been wrapped
automatically by the mailing list software.
From [openwrt/docker@5484951][1] (GitHub PR [#89][2]):

Node fails to cross-compile from a 64-bit build machine to 32-bit host
with the following error:

```
  In file included from /usr/include/c++/8/memory:62,
  from ../deps/v8/src/libplatform/default-foreground-task-runner.h:8,
  from ../deps/v8/src/libplatform/default-foreground-task-runner.cc:5:
  /usr/include/c++/8/bits/stl_algobase.h:59:10: fatal error: bits/c++config.h:
    No such file or directory
  #include <bits/c++config.h>
          ^~~~~~~~~~~~~~~~~~
  compilation terminated.
```

On Debian, `g++-multilib` can be installed to fix this.

[1]: https://gitlab.com/openwrt/docker/-/commit/54849510d7802028b94757051cca6d004a9ca1d1
[2]: https://github.com/openwrt/docker/pull/89

Fixes: https://github.com/openwrt/packages/issues/18476
Fixes: https://forum.openwrt.org/t/142722
Signed-off-by: Alois Klink <alois@aloisklink.com>
---

Notes:
    I've made a merge request on `openwrt/buildbot` GitLab too, see
    <https://gitlab.com/openwrt/buildbot/-/merge_requests/11>,
    but @hnyman on the OpenWRT forums recommended me to cross-post
    it to mailing list since GitLab isn't well used.

    (apologies if any formatting is wrong in this, it's my first time
     using `git send-email`)

    As of `Tue Nov 22 23:02:34 2022`, you can view
    https://downloads.openwrt.org/releases/faillogs-22.03/arm_cortex-a9_vfpv3-d16/packages/node/compile.txt
    and see the above error
    (I'm assuming that this buildbot is creating the above errors).

    We should probably also note in the OpenWRT wiki in
    https://openwrt.org/docs/guide-developer/toolchain/install-buildsystem#package_prerequisites
    that `node` requires `g++-multilib`.

    These changes are untested, but they're pretty simple so should work.
    The GitLab repo has some CI as well, but it doesn't seem to be working
    since my merge request is from a forked repo.

 docker/buildworker/Dockerfile | 1 +
 1 file changed, 1 insertion(+)

--
2.34.1

Thread OP is strangely formatted so my mail client isn't quoting the
message properly and I've just inline copied the original and top
posting.

I've seen no response to this so I presume that nothing is being done
about it and I'd like to see this fixed. Who is in charge of the build
server? How can this be brought to the attention of those who can do
something about it?

Glenn

On Wed, 23 Nov 2022 20:30:35 +0000
Alois Klink via openwrt-devel <openwrt-devel@lists.openwrt.org> wrote:

From: Alois Klink <alois@aloisklink.com>
To: openwrt-devel@lists.openwrt.org
Subject: [PATCH buildbot] docker,worker: install g++-multilib
Date: Wed, 23 Nov 2022 20:30:35 +0000

From [openwrt/docker@5484951][1] (GitHub PR [#89][2]):

Node fails to cross-compile from a 64-bit build machine to 32-bit host
with the following error:

```
  In file included from /usr/include/c++/8/memory:62,
  from ../deps/v8/src/libplatform/default-foreground-task-runner.h:8,
  from ../deps/v8/src/libplatform/default-foreground-task-runner.cc:5:
  /usr/include/c++/8/bits/stl_algobase.h:59:10: fatal error:
bits/c++config.h: No such file or directory
  #include <bits/c++config.h>
          ^~~~~~~~~~~~~~~~~~
  compilation terminated.
```

On Debian, `g++-multilib` can be installed to fix this.

[1]:
https://gitlab.com/openwrt/docker/-/commit/54849510d7802028b94757051cca6d004a9ca1d1
[2]: https://github.com/openwrt/docker/pull/89

Fixes: https://github.com/openwrt/packages/issues/18476
Fixes: https://forum.openwrt.org/t/142722
Signed-off-by: Alois Klink <alois@aloisklink.com>
---

Notes:
    I've made a merge request on `openwrt/buildbot` GitLab too, see
    <https://gitlab.com/openwrt/buildbot/-/merge_requests/11>,
    but @hnyman on the OpenWRT forums recommended me to cross-post
    it to mailing list since GitLab isn't well used.

    (apologies if any formatting is wrong in this, it's my first time
     using `git send-email`)

    As of `Tue Nov 22 23:02:34 2022`, you can view
    https://downloads.openwrt.org/releases/faillogs-22.03/arm_cortex-a9_vfpv3-d16/packages/node/compile.txt
    and see the above error
    (I'm assuming that this buildbot is creating the above errors).

    We should probably also note in the OpenWRT wiki in
    https://openwrt.org/docs/guide-developer/toolchain/install-buildsystem#package_prerequisites
    that `node` requires `g++-multilib`.

    These changes are untested, but they're pretty simple so should
    work. The GitLab repo has some CI as well, but it doesn't seem to
    be working since my merge request is from a forked repo.

 docker/buildworker/Dockerfile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/docker/buildworker/Dockerfile
b/docker/buildworker/Dockerfile index 5219f92..871b7b1 100644
--- a/docker/buildworker/Dockerfile
+++ b/docker/buildworker/Dockerfile
@@ -18,6 +18,7 @@ RUN \
 		ccache \
 		curl \
 		gawk \
+		g++-multilib \
 		gcc-multilib \
 		genisoimage \
 		git-core \
--
2.34.1

The sender domain has a DMARC Reject/Quarantine policy which disallows
sending mailing list messages using the original "From" header.

To mitigate this problem, the original message has been wrapped
automatically by the mailing list software.
On Thursday, December 1st, 2022 at 22:58, Glenn Washburn <development@efficientek.com> wrote:

> Thread OP is strangely formatted so my mail client isn't quoting the
> message properly and I've just inline copied the original and top
> posting.

That may be my fault! I did use `git send-email`, but it was my first time
using it, so I may have done something wrong
(or my email server broke the formatting).

I did try sending my patch to myself, and I could apply it locally, so at
least that bit should work.

I do have a merge request open on GitLab too,
see https://gitlab.com/openwrt/buildbot/-/merge_requests/11,
so if my patch formatting is bad, that can be used instead.

Petr did bring up using GitLab or GitHub to track buildbot development in
https://lists.openwrt.org/pipermail/openwrt-devel/2022-October/039555.html,
but as far as I'm aware, that discussion went nowhere, and so I cross-posted
my patch here as well on the recommendation of @hynman on the OpenWRT forums.

> I've seen no response to this so I presume that nothing is being done
> about it and I'd like to see this fixed. Who is in charge of the build
> server? How can this be brought to the attention of those who can do
> something about it?
> 
> Glenn

From a quick look at the https://gitlab.com/openwrt/buildbot
repository, it looks like Thibaut <hacks@slashdirt.org>
is the only person to commit on that repo in the last 8 months.

Petr Štetiar <ynezz@true.cz> was the main committer before then.

I've CC-ed them both in as they were both discussing the buildbot on this mailing
list last month, although as it is the holiday season, I wouldn't
be too surprised if they're both on vacation and take a while to respond.

Cheers,

Alois