diff mbox series

[6/8] realtek: fix place of fdb/mdb info messages

Message ID faaa05db58993f6091faeac7e01b850d7095ccb1.1665089731.git.sander@svanheule.net
State Accepted
Delegated to: Sander Vanheule
Headers show
Series realtek: various target cleanups | expand

Commit Message

Sander Vanheule Oct. 6, 2022, 8:56 p.m. UTC 
From: INAGAKI Hiroshi <musashino.open@gmail.com>

Those messages should be printed when entry was found (idx >= 0). Move
them to the right place to not print invalid entry indices.

Signed-off-by: INAGAKI Hiroshi <musashino.open@gmail.com>
[amden commit message]
Signed-off-by: Sander Vanheule <sander@svanheule.net>
---
 target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/dsa.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/dsa.c b/target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/dsa.c
index f54fdd298ac4..f08ede730b83 100644
--- a/target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/dsa.c
+++ b/target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/dsa.c
@@ -1689,8 +1689,8 @@  static int rtl83xx_port_fdb_del(struct dsa_switch *ds, int port,
 
 	idx = rtl83xx_find_l2_hash_entry(priv, seed, true, &e);
 
-	pr_info("Found entry index %d, key %d and bucket %d\n", idx, idx >> 2, idx & 3);
 	if (idx >= 0) {
+		pr_info("Found entry index %d, key %d and bucket %d\n", idx, idx >> 2, idx & 3);
 		e.valid = false;
 		dump_l2_entry(&e);
 		priv->r->write_l2_entry_using_hash(idx >> 2, idx & 0x3, &e);
@@ -1870,8 +1870,8 @@  int rtl83xx_port_mdb_del(struct dsa_switch *ds, int port,
 
 	idx = rtl83xx_find_l2_hash_entry(priv, seed, true, &e);
 
-	pr_debug("Found entry index %d, key %d and bucket %d\n", idx, idx >> 2, idx & 3);
 	if (idx >= 0) {
+		pr_debug("Found entry index %d, key %d and bucket %d\n", idx, idx >> 2, idx & 3);
 		portmask = rtl83xx_mc_group_del_port(priv, e.mc_portmask_index, port);
 		if (!portmask) {
 			e.valid = false;