| Message ID | d001eb10d2fff16c50f4e4366d6689f02915790b.1682539911.git.ehem+openwrt@m5p.com |
|---|---|
| State | New |
| Headers | show |
| Series | (mostly) x86 kernel configuration adjustments | expand |
On Tue, Apr 25, 2023 at 04:23:20PM -0700, Elliott Mitchell wrote: > I don't know what version of Linux this option disappeared at, but > it is clearly gone now. Then when I try to find it again (`find build_dir/target-$targ/linux-$targ/linux-5.15.108 -name Kconfig\* -print0 | xargs -0 grep -eFB_NOTIFY`) I discover it still exists. Since I've done several builds without it though, I'm pretty sure it is now simply unnecessary. Appears it gets turned on when CONFIG_FB=y, so the patch is correct.
Reviewed-by: Philip Prindeville <philipp@redfish-solutions.com> > On Apr 25, 2023, at 5:23 PM, Elliott Mitchell <ehem+openwrt@m5p.com> wrote: > > I don't know what version of Linux this option disappeared at, but > it is clearly gone now. > > Signed-off-by: Elliott Mitchell <ehem+openwrt@m5p.com> > --- > target/linux/generic/config-5.10 | 1 - > target/linux/generic/config-5.15 | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/target/linux/generic/config-5.10 b/target/linux/generic/config-5.10 > index cde0fdb0a0..f6f1fb0278 100644 > --- a/target/linux/generic/config-5.10 > +++ b/target/linux/generic/config-5.10 > @@ -1892,7 +1892,6 @@ CONFIG_FAT_DEFAULT_IOCHARSET="iso8859-1" > # CONFIG_FB_MXS is not set > # CONFIG_FB_N411 is not set > # CONFIG_FB_NEOMAGIC is not set > -CONFIG_FB_NOTIFY=y > # CONFIG_FB_NVIDIA is not set > # CONFIG_FB_OF is not set > # CONFIG_FB_OMAP2 is not set > diff --git a/target/linux/generic/config-5.15 b/target/linux/generic/config-5.15 > index 239a645231..ac75a480a1 100644 > --- a/target/linux/generic/config-5.15 > +++ b/target/linux/generic/config-5.15 > @@ -1979,7 +1979,6 @@ CONFIG_FAT_DEFAULT_IOCHARSET="iso8859-1" > # CONFIG_FB_MXS is not set > # CONFIG_FB_N411 is not set > # CONFIG_FB_NEOMAGIC is not set > -CONFIG_FB_NOTIFY=y > # CONFIG_FB_NVIDIA is not set > # CONFIG_FB_OF is not set > # CONFIG_FB_OMAP2 is not set > -- > (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) > \BS ( | ehem+openwrt@m5p.com PGP 87145445 | ) / > \_CS\ | _____ -O #include <stddisclaimer.h> O- _____ | / _/ > 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 > > > > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
On 4/26/23 01:23, Elliott Mitchell wrote: > I don't know what version of Linux this option disappeared at, but > it is clearly gone now. > > Signed-off-by: Elliott Mitchell <ehem+openwrt@m5p.com> > --- > target/linux/generic/config-5.10 | 1 - > target/linux/generic/config-5.15 | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/target/linux/generic/config-5.10 b/target/linux/generic/config-5.10 > index cde0fdb0a0..f6f1fb0278 100644 > --- a/target/linux/generic/config-5.10 > +++ b/target/linux/generic/config-5.10 > @@ -1892,7 +1892,6 @@ CONFIG_FAT_DEFAULT_IOCHARSET="iso8859-1" > # CONFIG_FB_MXS is not set > # CONFIG_FB_N411 is not set > # CONFIG_FB_NEOMAGIC is not set > -CONFIG_FB_NOTIFY=y > # CONFIG_FB_NVIDIA is not set > # CONFIG_FB_OF is not set > # CONFIG_FB_OMAP2 is not set > diff --git a/target/linux/generic/config-5.15 b/target/linux/generic/config-5.15 > index 239a645231..ac75a480a1 100644 > --- a/target/linux/generic/config-5.15 > +++ b/target/linux/generic/config-5.15 > @@ -1979,7 +1979,6 @@ CONFIG_FAT_DEFAULT_IOCHARSET="iso8859-1" > # CONFIG_FB_MXS is not set > # CONFIG_FB_N411 is not set > # CONFIG_FB_NEOMAGIC is not set > -CONFIG_FB_NOTIFY=y > # CONFIG_FB_NVIDIA is not set > # CONFIG_FB_OF is not set > # CONFIG_FB_OMAP2 is not set Some targets are activating CONFIG_FB=y, for these targets we also want to activate CONFIG_FB_NOTIFY for some reason. If a target does not set CONFIG_FB, it will also not set CONFIG_FB_NOTIFY Hauke
diff --git a/target/linux/generic/config-5.10 b/target/linux/generic/config-5.10 index cde0fdb0a0..f6f1fb0278 100644 --- a/target/linux/generic/config-5.10 +++ b/target/linux/generic/config-5.10 @@ -1892,7 +1892,6 @@ CONFIG_FAT_DEFAULT_IOCHARSET="iso8859-1" # CONFIG_FB_MXS is not set # CONFIG_FB_N411 is not set # CONFIG_FB_NEOMAGIC is not set -CONFIG_FB_NOTIFY=y # CONFIG_FB_NVIDIA is not set # CONFIG_FB_OF is not set # CONFIG_FB_OMAP2 is not set diff --git a/target/linux/generic/config-5.15 b/target/linux/generic/config-5.15 index 239a645231..ac75a480a1 100644 --- a/target/linux/generic/config-5.15 +++ b/target/linux/generic/config-5.15 @@ -1979,7 +1979,6 @@ CONFIG_FAT_DEFAULT_IOCHARSET="iso8859-1" # CONFIG_FB_MXS is not set # CONFIG_FB_N411 is not set # CONFIG_FB_NEOMAGIC is not set -CONFIG_FB_NOTIFY=y # CONFIG_FB_NVIDIA is not set # CONFIG_FB_OF is not set # CONFIG_FB_OMAP2 is not set
I don't know what version of Linux this option disappeared at, but it is clearly gone now. Signed-off-by: Elliott Mitchell <ehem+openwrt@m5p.com> --- target/linux/generic/config-5.10 | 1 - target/linux/generic/config-5.15 | 1 - 2 files changed, 2 deletions(-)