From patchwork Mon Mar 1 10:40:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Eckert X-Patchwork-Id: 1445515 X-Patchwork-Delegate: ynezz@true.cz Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.openwrt.org (client-ip=2001:8b0:10b:1231::1; helo=merlin.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=merlin.20170209 header.b=FY/xiGio; dkim-atps=neutral Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DpxfW2Ccqz9sSC for ; Mon, 1 Mar 2021 21:42:27 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:Subject:To:From:Date:MIME-Version: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=D7fMHVHt5P2d2y6szHiiJpZZfADH3hlxNZeJs5Niq+w=; b=FY/xiGiooEf1BAa6jXfWCWWVpW 977OVvDTa0mpz9pkcmy6u/Gk7LGyVz+D0W17G464F3SvqfxpklOuv25FJdBx991j02EZ7BUFEJFJK ovyipsTgWhP1BSq6f6IK68A8Cpcm1motBkjT2Dma9U3QDoAA/O1sc9r+yDpwaHEAYh9ZIbwEF0GWM hkh+idTwJ5a2nQ9CUWLL4nSA1opoPsy9e3HkgRTX9MUO9NOJbwrnfPdHrNn144Jl7XXiAHJ+wpGRT XvOYiXKT0LZcLT6DiUAg7RU1srxU6TcNs2Q+uyQA8UDObx8t7O2qHuMuWPSdVC7D3+pDxIPc4FYMn 6vUNfA8Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lGfz5-0003TT-Qc; Mon, 01 Mar 2021 10:41:03 +0000 Received: from mxout70.expurgate.net ([91.198.224.70]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lGfz2-0003SH-Em for openwrt-devel@lists.openwrt.org; Mon, 01 Mar 2021 10:41:01 +0000 Received: from [127.0.0.1] (helo=localhost) by relay.expurgate.net with smtp (Exim 4.92) (envelope-from ) id 1lGfyy-000TO0-HG; Mon, 01 Mar 2021 11:40:56 +0100 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lGfyx-000ALW-VD; Mon, 01 Mar 2021 11:40:55 +0100 Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id 675D7240041; Mon, 1 Mar 2021 11:40:55 +0100 (CET) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id 15883240040; Mon, 1 Mar 2021 11:40:55 +0100 (CET) Received: from mail.dev.tdt.de (localhost [IPv6:::1]) by mail.dev.tdt.de (Postfix) with ESMTP id 8D9D320043; Mon, 1 Mar 2021 11:40:54 +0100 (CET) MIME-Version: 1.0 Date: Mon, 01 Mar 2021 11:40:54 +0100 From: Florian Eckert To: bobafetthotmail@gmail.com, hauke@hauke-m.de Subject: Unnecessary extension of default packeges for x86 generic Message-ID: X-Sender: fe@dev.tdt.de User-Agent: Roundcube Webmail/1.3.16 X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.dev.tdt.de X-purgate: clean X-purgate-ID: 151534::1614595256-000052FF-E977B0D3/0/0 X-purgate-type: clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210301_054100_640350_C8E3A977 X-CRM114-Status: UNSURE ( 9.77 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.7 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [91.198.224.70 listed in list.dnswl.org] 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [91.198.224.70 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Openwrt Devel Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org Hello, Is it really necessary that we keep expanding the default package here [1]? The problem is, for example, that I don't need the whole AWS stuff. But now the whole package gets installed. If this is the case, then we should also install the vmware needed driver as default package. Maybe someone (like me) would like to run the image in a vmware environment. But I do not want to install this per default. I think this are all special image. Therefore it would be a good idea to create individual images. For example * define Device/aws * define Device/vmware Also, binary blobs are currently already get installed as a dependency that the default drivers work. Therefore I have changed the line before this change as following. So no binary blob dependency gets installed. I am also not clear why we need kmod-bnx2, kmod-forcedeth and kmod-r8169 as default, which have the binary blob dependency. TARGET_DEVICES += generic --- From my point of view, these are the minimum packets needed to make the generic image to work. Kind Regards Florian [1] https://github.com/openwrt/openwrt/commit/788ec9a7cfc843c8e46451331521cdc7d81866bd --- a/target/linux/x86/image/64.mk +++ b/target/linux/x86/image/64.mk @@ -1,7 +1,6 @@ define Device/generic DEVICE_TITLE := Generic x86/64 - DEVICE_PACKAGES += kmod-bnx2 kmod-e1000e kmod-e1000 kmod-forcedeth kmod-igb \ - kmod-ixgbe kmod-r8169 + DEVICE_PACKAGES += kmod-e1000e kmod-e1000 kmod-igb kmod-ixgbe GRUB2_VARIANT := generic endef