diff mbox series

rpcd: Add support for plugin command input via argv[3] ($3)

Message ID OF6778A327.70FF2B28-ON8525861D.0061E51C-8525861D.0061E51C@sercomm.com
State New
Headers show
Series rpcd: Add support for plugin command input via argv[3] ($3) | expand

Commit Message

Louis_Hampton@SERCOMM.COM Nov. 11, 2020, 5:49 p.m. UTC
This does not disable the current method of using plugin command
arguments (stdin), only adding the new feature.

Signed-off-by: Louis Hampton <louis_hampton@sercomm.com>
---
 plugin.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jo-Philipp Wich Nov. 11, 2020, 6:03 p.m. UTC | #1
Hi,

the request payload can theoretically become very big, something in the
few hundred kilobyte to one megabyte ballpark. I am not sure if it is a
good idea to pass that via the argv vector.

~ Jo
diff mbox series

Patch

diff --git a/plugin.c b/plugin.c
index b0315dc..f12b212 100644
--- a/plugin.c
+++ b/plugin.c
@@ -229,6 +229,7 @@  rpc_plugin_call(struct ubus_context *ctx, struct ubus_object *obj,
 	c->argv[0] = c->path;
 	c->argv[1] = "call";
 	c->argv[2] = c->method;
+	c->argv[3] = c->input;
 
 	rv = rpc_exec(c->argv, rpc_plugin_call_stdin_cb,
 	              rpc_plugin_call_stdout_cb, rpc_plugin_call_stderr_cb,