| Message ID | F51492713EF10846800D8C0ED37A7DCE01944456@SJEXCHMB15.corp.ad.broadcom.com |
|---|---|
| State | Rejected |
| Delegated to: | Rafał Miłecki |
| Headers | show |
On 12 May 2015 at 10:16, Hante Meuleman <meuleman@broadcom.com> wrote: > Do not mimic the vlan configuration in some devices like R8000 as the > configuration is to be used with SW accelerators not available in OpenWRT. > It is not possible to use the switch with vlan port configuration 0 1 2 3 5 7 8, > without making some huge modifications. When this configuration is used > the packets received will be without vlan tag (identified by status field in > gmac). This mode is used for an optimization which is not easily to be used > within the current OpenWRT driver framework. I think I fixed it now, with indeed few modifications, but not that huge ones after all. If you could test latest OpenWrt trunk/master it would be great. > The patch below will modify the existing vlanport configuration so it will work > on the r8000 with the existing opensource drivers. The problem with this patch (apart from S-o-b) was the silent way of handling R8000. You dropped code that recognized R8000 specific config just silently falling back to the default one. It would be much safer to leave R8000 case detection, just change the vlans config and add a proper comment. Just for the future :)
On 18 May 2015 at 12:12, Hante Meuleman <meuleman@broadcom.com> wrote: > Tested a clean checkout this morning and booted it. It is booting, but no > packets are received. At least the ifconfig shows no RX packets, could be > that the packets miss the vlan tag. Can you see swconfig forcing port 8 state? swconfig dev switch0 show | grep link Can you debug what else is missing in b53 to support switch port 8? I think we have all the other stuff already in place.
diff --git a/target/linux/bcm53xx/base-files/etc/board.d/02_network b/target/linux/bcm53xx/base-files/etc/board.d/02_network index 644d3d9..18958b8 100755 --- a/target/linux/bcm53xx/base-files/etc/board.d/02_network +++ b/target/linux/bcm53xx/base-files/etc/board.d/02_network @@ -23,10 +23,6 @@ if echo "$vlan1ports" | egrep -q "^1 2 3 4 5" && \ echo "$vlan2ports" | egrep -q "^0 5"; then ucidef_add_switch_vlan "switch0" "1" "1 2 3 4 5t" ucidef_add_switch_vlan "switch0" "2" "0 5t" -elif echo "$vlan1ports" | egrep -q "^0 1 2 3 5 7 8" && \ - echo "$vlan2ports" | egrep -q "^4 8"; then - ucidef_add_switch_vlan "switch0" "1" "0 1 2 3 5 7 8t" - ucidef_add_switch_vlan "switch0" "2" "4 8t" else ucidef_add_switch_vlan "switch0" "1" "0 1 2 3 5t" ucidef_add_switch_vlan "switch0" "2" "4 5t"