From patchwork Thu Jul 28 08:47:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: hasbaddana@outlook.com X-Patchwork-Id: 1661553 X-Patchwork-Delegate: hauke@hauke-m.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=tnB50ouT; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=outlook.com header.i=@outlook.com header.a=rsa-sha256 header.s=selector1 header.b=CM/KCdRW; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Ltkr834lgz9s5W for ; Thu, 28 Jul 2022 18:50:31 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To :From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=6h40p4TENruHavOBx22agrdi9CfyGU7DmTnQQj7Szv8=; b=tnB50ouTlDZxFI wiXq7PKv5W6ZigqwUcq9eM9uEeVrkEPgew2xzV4/RDSbJiKpU+4r58wtpfjVbDw+2C3DqWCCgaVsc vozEIsMasYwBuJD8Z1ga5EKRiKVSvaSFOzWldQ4pB4MGVb5MqhEr39VO/ZxYdrVSKdJpYKpwQPi/T DnkQdkgnfb0y4n5hHlzVFmoygyxrR/USRIyTHVQqi3lXGG+o4Vx4VCXn2WeNpq/kzK1q6nwhwsu7c 367ROiwSZJMXyI6MmWKTKS2aF/K3xI0Hx6VQBtFZaFaNm39ZnN9VrGliayDRKY4NPHc2B/c7nG14H N7R5LirFVqXMtLB+gvUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGzB5-005vQl-PN; Thu, 28 Jul 2022 08:47:32 +0000 Received: from mail-oln040092070080.outbound.protection.outlook.com ([40.92.70.80] helo=EUR03-AM5-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGzAr-005vIt-Az for openwrt-devel@lists.openwrt.org; Thu, 28 Jul 2022 08:47:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EoGFj5B2DqkeP+U5dwpbkVrs1jix0Y+yH1Wb+ACVaPZrVwXnZ6p1ba6HSqlZfAnSTX648ihJD4vAouv4bgFYMx6I/p6MOKuKWQ+AmIC+vbuRwnFL+tobsmNi3arpK98tzxX++FgLHQz4JeC28C9GxKWEXKEv/3/DRsTEHrUr9JgQhPz+P8AAO6zouusOnxGudVOdDvT2cRTyoWjEN3tnw5dyEjC/4gpwIYvZ+j0f+Qx8AUMaRk6/D3f2xRyksLQp6845CPegrveugMkG4+CDJyN4g83Sagek6SSCfm49AwGygDpZCebkbf3JfhOCr6yps1sXuUcBmllRq5f+v+XHeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OzQPpWN0axAtVOsTtt1g5iZZEyuLrESd/8v1ziekTms=; b=m+uFvPruGB2fA9y3sn/YzxMx1NKauU5nzLddLFRyXm3Kq7eB0pkeqDJwH8MR7pJmcbLBcvYG5hJUNGTRFz5pXRm5Oe87IxXuTD7xhRkIHz3IM35fhEfanhTvJuAIIa+GMiyjfUZDu8vcqZaW4ISLRTDA+WHDdtYHGb95IQ8314ii3pb6/882KMGlBWJtQvah7idicQFlUFWLuCAXd0QNV9rhkHgFqHk6d8Y50X8S7lBCHWTCc6DP8j3FV/8XYHMQ83ddWFl+K/l+iMpXtm2eq4jjZxv1ETLLiV2X+1w7mAyv8ny0h0n04lcG+31DxuV5Xolbz5ovnWtiwrgu828OTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OzQPpWN0axAtVOsTtt1g5iZZEyuLrESd/8v1ziekTms=; b=CM/KCdRWEdOTPnfEhWn7V4YAiUhy5EkQI6OfUyfuEjlQ4bsQTP9+aUZw8t7PIp93oMGxwkxuuIIbS4F9cVFa9i9MvrCiBLstIf1l9yqypVI0woUWae63I9MVQWWQpMCjeJ2z7UoCOS3PjB2qIiXJ+eW/syrYCINAAshACdgI+15imAno7o+545s4A1ctnbPPBWwZ0nbj6OE3GBQ46SID8uGUuaCPc8Y6IR3U7kTahfL3oIsdKwDaTXFZAhgXr1CJHDOpgfz97kDHTsPeCQhtaGZJr/fgLvj7V87ZfJPT70bX/H+u86O/97BoxRNrMqOnRfPMHKz87QeYupY3twJ5VQ== Received: from DBBPR08MB6265.eurprd08.prod.outlook.com (2603:10a6:10:207::18) by AM4PR08MB2900.eurprd08.prod.outlook.com (2603:10a6:205:e::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.10; Thu, 28 Jul 2022 08:47:13 +0000 Received: from DBBPR08MB6265.eurprd08.prod.outlook.com ([fe80::f82f:d84d:7ea5:70dd]) by DBBPR08MB6265.eurprd08.prod.outlook.com ([fe80::f82f:d84d:7ea5:70dd%4]) with mapi id 15.20.5482.010; Thu, 28 Jul 2022 08:47:13 +0000 From: hasbaddana@outlook.com To: openwrt-devel@lists.openwrt.org Subject: [PATCH] iwinfo: Add missing auth_suites mappings for WPA3 Date: Thu, 28 Jul 2022 10:47:09 +0200 Message-ID: X-Mailer: git-send-email 2.25.1 X-TMN: [HKN8RzXd77EmDgtZf0kUQ9/MwTQYTNVy] X-ClientProxiedBy: PAZP264CA0162.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:1f9::21) To DBBPR08MB6265.eurprd08.prod.outlook.com (2603:10a6:10:207::18) X-Microsoft-Original-Message-ID: <20220728084709.30919-1-hasbaddana@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0aceebc4-7f8e-49ad-e31e-08da7075c41a X-MS-TrafficTypeDiagnostic: AM4PR08MB2900:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: W8cXgH8+GmrMnExUM7X0SLpgysA6Kjq+JAzEwHxdLw92n+ya4972ub6CMwBdtGZAMYSiH3DSz1bquQ5ovAgKjagRym3fa4ThnCZyTWybgcvEoAlrrqEPXgNzshHjK3OKpTf3Use68Y8mWq0tUnqTN9Y6NrU/WgdPsiwizIzj9m+RKVt2lsYZYM66moXvO2heu19Nxd9AaGsrpECF4zKU5/5uzEMDgaiKF4EAPeNUjXaTNF462p4vslKqhhLeq0tB69iNZCv8SxCIdiW+Aw4pThPagH6OY1THxfWGMwwjePmE2DtUzK6h+LhVO1xxWe202g+/+i3ZxG01iBLPerphicJ8UcAzF482ZveTwGtJguSg5JC9m7E+s5ZkpNFhTbxrilxnwBOsP9wtfJJPqBuqicaNLt9cvJWINeV6ofsz1MvyKwAqIFW1+BrvJAu1xJgXrtLyRDoDkJHzimr8yxg52mN5f65QXQL0f131b+8fA1uqTlTTfcoP46iDaR+IoWEb+bV+HobI58j3xqcqnJcggAdO0UY650BPmdTE8LqHTmE5LHc9UTqLYPJAQCVcPQUeOc5kbSyWlftakWYYle0svyud/PhS17RuaN4Vbt5Y+o8ZSo4LHj2FlLdw1BIGL4ySkCW+gK7g6wOPbenCXfR3Yw== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: odl6J2PAzmNewZSFE0plVAaPlKJwFBE5UANkm0PcMON59yy7SwTMR5wIFzPMxyL+lF41g8MVviXLIsJQcraQBIO7cytQ/L+BHqqFCnft2dMQCFhEOt0uJcF4dSvHTV6nL0xCOGfZwhquaCQPsnXqIOIkQ4zi7oHnqZ5TVqxcAKMuoZUZRWIpq6l/1lZdZrsbVc4ogfMavO7fi4LPssUDLSpbhS6DeZWjx9sr41nT0qluaVF3hximzlsVe3ebHvuCGcuCZ0Fh2a1SYInjsPUycWj5VVuZ4m9sPJaFjeDvsdLKtqa5Ry3v9sXDHEFXw2qdpkKsRmxjjQop4A63B3hlk4Z8O6rTMBaE4QOp26JxLDtdigKn1tOp/xatW3xA37QOMi7SpnqNLh9JPhWvLYZLemQQjDYOfU5xrqVO0HRJQTEjnX9+lIgHXPg5uDhs0f1mlXh08HTRXgNRefAoeI2aHFiwxmnWZauQ721yJfFpn6Bp//FDTTe26bBicG7i8iPbgFMLyORB77BGRF4bhQD2naV49hTCXz6M/i7YBmu6684rBAy/HjOy0svGvv4D1hOzSzbMD5W8dsbXiQVic3gtM+FTWtlH7HCGm+fGl6BNgj7prpy2Q7RCMvx//ADSbl3WABAdihtI1HjgmkU4axhTiBvoo4Vm6UbdUf22/hEZy25j9v9CaqNGYYs3enRiX7P29ylnL15xgN4QmNJix3Vw8afg+/DyR3HwDvZ6etPgcFhxro9PimAWYwlLC8Heq2ZJ/6jxH1KZQbMw1P+ZIaLbT3fCliyOqrmJcvNovFHP34wBk44b9CjQSHIPUlF2tGPt6r/kAO5j2AJRJxJL3almcy1qSC+0SBvKoHD1ob3ijII4d+N9G63wlAW7NhHpcM9+B3u9sCztLswuDtIdbh4E8WNKhCjCsgpatiYfLBtgK64EosfE29wQQ2YNwBLKOfFofgFNmSWBCPDcXqgcgypoVx72g4vQUeIylnmkY/8AFsjqWzPxn92eKtTA6CF79cm5vHq2hppZNZeTcfrkGhZqXYcHt/A9/9jjLYedObIJpbGpTu8Tp3DdhjdHO/kUzaj5ahTFH97mVUyfkLHmYO91+s8sR14W2r7tkpPJM+qVkKgBs6yQ9Z0GMh6GPcQkldrADE/hpYVpw4HS3bjzAcjesnWeUQ9KXyzBOjnZXYgH/ps0hH12H6ndQprIZZp6Z/86nptTLVKtSEbsY0ETJUGPZmVCFv22H36rcKXXLYEfe16Kj4xOT0AiqKuFTD8sqwW9fHwrov6uRbNwpmQL0BgBmw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0aceebc4-7f8e-49ad-e31e-08da7075c41a X-MS-Exchange-CrossTenant-AuthSource: DBBPR08MB6265.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 08:47:13.2426 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2900 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220728_014717_436118_BF94FC7C X-CRM114-Status: UNSURE ( 7.55 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Tjeu Kayim `iwinfo.h` says: #define IWINFO_KMGMT_COUNT 5 ... extern const char *IWINFO_KMGMT_NAMES[IWINFO_KMGMT_COUNT]; Though only only 3 items are defined. The other two were forgotten when adding WPA3 support. The `auth_suites` table exposed via Lua never included the items "SAE" and "OWE" until this commit. Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [40.92.70.80 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [hasbaddana[at]outlook.com] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org From: Tjeu Kayim <15987676+TjeuKayim@users.noreply.github.com> `iwinfo.h` says: #define IWINFO_KMGMT_COUNT 5 ... extern const char *IWINFO_KMGMT_NAMES[IWINFO_KMGMT_COUNT]; Though only only 3 items are defined. The other two were forgotten when adding WPA3 support. The `auth_suites` table exposed via Lua never included the items "SAE" and "OWE" until this commit. Signed-off-by: Tjeu Kayim <15987676+TjeuKayim@users.noreply.github.com> --- Notes: Tested with OpenWRT v21.02.3 and iwinfo commit c45f0b584b4b86f8250f90ea19afca271c114fa2. Fortunately, `lua_pushstring` gracefully handled passing NULL, so the previous code didn't cause any errors. This commit just fixes the inconsistency that "SAE" and "OWE" are included in the iwinfo CLI output and the Lua `description` (in `iwinfo_crypto_print_suites()`), but not in the Lua `auth_suites`. This is probably not important enough to add it to openwrt/package /network/utils/iwinfo/patches, so that's why I didn't use a GitHub pull request. iwinfo_lib.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/iwinfo_lib.c b/iwinfo_lib.c index 70b080c..118fe58 100644 --- a/iwinfo_lib.c +++ b/iwinfo_lib.c @@ -37,6 +37,8 @@ const char *IWINFO_KMGMT_NAMES[] = { "NONE", "802.1X", "PSK", + "SAE", + "OWE", }; const char *IWINFO_AUTH_NAMES[] = {