| Message ID | 55F5B78D.9040400@iki.fi |
|---|---|
| State | Accepted |
| Headers | show |
Hannu Nyman schrieb am 13.09.2015 um 19:51: > Sorry, but what is the problem? Most importantly: laziness. In my case, I just keep hitting the next email button and have a quick look. Having to open the attachment, choose an editor, read, close the editor is just inconvenient (and then all the effort for just one changed line of code). There are probably more people giving a silent ack by not objecting. Secondly: Commenting inline is much more inconvenient, if the patch is attached rather than inline. > ozlabs patchwork list shows the properly recognised patch: > https://patchwork.ozlabs.org/patch/517209/ > > But in any case, inline below. > > Hannu > > Index: include/toplevel.mk > =================================================================== > --- include/toplevel.mk (revision 46894) > +++ include/toplevel.mk (working copy) > @@ -6,7 +6,7 @@ > # See /LICENSE for more information. > # > > -RELEASE:=Chaos Calmer > +RELEASE:=Designated Driver > PREP_MK= OPENWRT_BUILD= QUIET=0 > > export IS_TTY=$(shell tty -s && echo 1 || echo 0) > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel >
On 2015-09-13 19:51, Hannu Nyman wrote: > Sorry, but what is the problem? > ozlabs patchwork list shows the properly recognised patch: > https://patchwork.ozlabs.org/patch/517209/ > > But in any case, inline below. > > Hannu > > Index: include/toplevel.mk > =================================================================== > --- include/toplevel.mk (revision 46894) > +++ include/toplevel.mk (working copy) > @@ -6,7 +6,7 @@ > # See /LICENSE for more information. > # > > -RELEASE:=Chaos Calmer > +RELEASE:=Designated Driver > PREP_MK= OPENWRT_BUILD= QUIET=0 > > export IS_TTY=$(shell tty -s && echo 1 || echo 0) Sending the patch inline as a follow-up, but then not sending it with a proper description does not make things better in any way. One of the most important reasons to send patches inline is that it allows people to easily review patches and comment on specific parts. Patches should be easy to review *and* easy to apply at the same time. Please start respecting that policy from now on - it's there for a reason. - Felix
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hartmut Knaack <knaack.h@gmx.de> wrote: > Hannu Nyman schrieb am 13.09.2015 um 19:51: > > Sorry, but what is the problem? > > Most importantly: laziness. In my case, I just keep hitting the next > email > button and have a quick look. Having to open the attachment, choose an > editor, Your mail reader can't show you text attachments inline automatically? I know this is what we're all meant to do, but requiring the world to live in the 70s forever is just so.... well... old fashioned. > read, close the editor is just inconvenient (and then all the effort for > just > one changed line of code). There are probably more people giving a > silent ack > by not objecting. > Secondly: Commenting inline is much more inconvenient, if the patch is > attached > rather than inline. yes, this is valid, sure :) -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJV9fqGAAoJEBmotQ/U1cr2u6QP+wTmr+tMNw61KUzzm+NqQtq9 u0MO5A7YCs92S8D7IXp9xgsOqc3hrThRvQJ+Zd5ho2TGo2KhIDvHFt1WEJhpbMg1 GVNfISq7lHg6W8RNBdLlQpGyQ3+WcQZqM/CzQW77H2P1lwqsbojqgDloT71LTzqy hhQj2F2T5tEbDcDgcM8Z8+JGf0JK1PhmAsYlHQ60MPoreVVv0HanmsLWCQ+Q7vpN uQi6aSIZ9pOsN1JCGS5cxAYmIHPUjfEHcGMyo1l/WhQYiQjoJe4EcSIHxG3Za+oT o8j7N+E1a2+vRjvyszAkwWgRJYBkLMEVlBU7ANdF6AR5+NvavnDITm3NLFjbITeF peapcR9rgx3tPqW1Pujd0Cq8VZqlVbrXLeAarI3Jd4VPTw7KJFfngI6qK3T9x1Cd qmTOOQ8MKBD1AOnZwEfF28ZSF7k9bIYuD9/DkJdqkWSiWz++rFA/AkvbMSNtRXOh Ky+N5qjteOnGMeI7a6iRKvGALVUyqizTY0v/3eVonIEvE2wN7KoLZqK+nz7IJ8ga SaNOr1W1TUmgJtD5HO48eOKKviriFhzoqKj4LZLOLay/ZOkzFAThPVJFbOz1IUKQ 3zieX39AooZK2xsdnfmVexCxnLkezhwQt4ixRhxvg6MQrIpwtL8R8g56S5BnK/Lz d8CcQ09NEveZKWc4vjdH =+KwL -----END PGP SIGNATURE-----
On Mon, Sep 14, 2015 at 12:36 AM, Karl Palsson <karlp@tweak.net.au> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hartmut Knaack <knaack.h@gmx.de> wrote: >> Hannu Nyman schrieb am 13.09.2015 um 19:51: >> > Sorry, but what is the problem? >> >> Most importantly: laziness. In my case, I just keep hitting the next >> email >> button and have a quick look. Having to open the attachment, choose an >> editor, > > Your mail reader can't show you text attachments inline automatically? > I know this is what we're all meant to do, but requiring the world to > live in the 70s forever is just so.... well... old fashioned. The gmail web interface doesn't. And while Thunderbird shows it, it won't quote it when hitting reply, which makes it not much better. Jonas
Index: include/toplevel.mk =================================================================== --- include/toplevel.mk (revision 46894) +++ include/toplevel.mk (working copy) @@ -6,7 +6,7 @@ # See /LICENSE for more information. # -RELEASE:=Chaos Calmer +RELEASE:=Designated Driver PREP_MK= OPENWRT_BUILD= QUIET=0 export IS_TTY=$(shell tty -s && echo 1 || echo 0)